coreutils/src/basenc.c, branch v9.0

basenc: fix bug49741: using wrong decoding buffer length

2021-08-30T04:06:32Z

Emil Lundberg reports in https://bugs.gnu.org/49741 about a 'basenc --base64 -d' decoding bug. The input buffer length was not divisible by 3, resulting in decoding errors. * NEWS: Mention fix. * src/basenc.c (DEC_BLOCKSIZE): Change from 1024*5 to 4200 (35*3*5*8) which is divisible by 3,4,5,8 - satisfying both base32 and base64; Use compile-time verify() macro to enforce the above. * tests/misc/basenc.pl: Add test.

basenc: prefer signed to unsigned integers

2021-08-28T00:12:27Z

This patch modifies basenc to prefer signed integers to unsigned, as signed are less error-prone. This patch also updates Gnulib to to latest, which updates Gnulib’s base32 and base64 modules to prefer signed to unsigned integers. * src/basenc.c: Include idx.h. (struct base2_decode_context): Use unsigned char, not unsigned for an octet that must fit in an unsigned char. (base_encode, struct base_decode_context) (base64_decode_ctx_wrapper, prepare_inbuf, base64url_encode) (base64url_decode_ctx_wrapper, base32_decode_ctx_wrapper) (base32hex_encode, base32hex_decode_ctx_wrapper, base16_encode) (base16_decode_ctx, z85_encode, Z85_HI_CTX_TO_32BIT_VAL) (z85_decoding, z85_decode_ctx, base2msbf_encode) (base2lsbf_encode, base2lsbf_decode_ctx, base2msbf_decode_ctx) (wrap_write, do_encode, do_decode, main): Prefer signed integers to unsigned. (main): Treat extremely large wrap columns as if they were infinite; that’s good enough. Since we’re now using xstrtoimax, this allows ‘-w -0’ (same as ‘-w 0’). * tests/misc/base64.pl (gen_tests): -w-0 is no longer an error.

maint: while (1) → while (true)

2021-06-27T01:40:26Z

maint: use "char const " rather than "const char "

2021-04-11T17:33:45Z

* cfg.mk (sc_prohibit-const-char): Add a new syntax-check to enforce this style. * *.[ch]: sed -i 's/const char \*/char const */g'

maint: update all copyright year number ranges

2021-01-01T16:36:09Z

Run "make update-copyright" and then... * gnulib: Update to latest with copyright year adjusted. * tests/init.sh: Sync with gnulib to pick up copyright year. * bootstrap: Likewise. * tests/sample-test: Adjust to use the single most recent year.

doc: make blank lines before --help consistent

2020-10-27T19:23:46Z

* src/basenc.c (usage): Remove extraneous blank line, to be consistent with other utilities that have options. * src/realpath.c: Likewise. * src/runcon.c: Likewise. Addresses https://bugs.gnu.org/44248

basenc: avoid undefined behaviour in z85 processing

2020-03-04T12:38:27Z

* src/basenc.c (z85_decode_ctx_init): Ensure we're working with unsigned, as otherwise ubsan triggers with: src/basenc.c:767:18: runtime error: signed integer overflow: 43 * 52200625 cannot be represented in type 'int' (z85_encode): Likewise to avoid the usban error: src/basenc.c:630:26: runtime error: left shift of 134 by 24 places cannot be represented in type 'int'

maint: update all copyright year number ranges

2020-01-01T14:16:56Z

basenc: port to C99

2019-05-11T20:55:54Z

* src/basenc.c: Various minor style cleanups. (struct base_decode_context): Do not use anonymous unions, as they’re not in C99. Use a named union instead. All uses changed.

basenc: allocate buffers on heap

2019-01-06T00:14:07Z

Allocate the encoding/decoding buffers dynamically on the heap instead of using variable-length-array (VLA) on the stack. Discussed in https://lists.gnu.org/r/coreutils/2019-01/msg00004.html . * src/basenc.c (do_encode,do_decode): Allocate inbuf/outbuf using xmalloc, and free if using LINT.

coreutils/src/basenc.c, branch v9.0

basenc: fix bug49741: using wrong decoding buffer length

basenc: prefer signed to unsigned integers

maint: while (1) → while (true)

maint: use "char const *" rather than "const char *"

maint: update all copyright year number ranges

doc: make blank lines before --help consistent

basenc: avoid undefined behaviour in z85 processing

maint: update all copyright year number ranges

basenc: port to C99

basenc: allocate buffers on heap

maint: use "char const " rather than "const char "