coreutils/src/copy.c, branch v6.7

cp -p now clears special bits if it fails to preserve owner or group

2006-12-07T07:10:35Z

* NEWS: Document the cp -p fix for special bits. * src/copy.c (set_owner): Now returns a three-way result, so that the caller can clear the special bits. All callers changed. (copy_reg): Don't set the special bits if chown failed. (copy_internal): Likewise. * tests/cp/special-bits: Test this fix. Signed-off-by: Jim Meyering

* NEWS: Document the cp --preserve=ownership fix.

2006-12-06T19:44:08Z

* m4/jm-macros.m4 (coreutils_MACROS): Check for fchmod. * src/copy.c (fchmod_or_lchmod): New function. (copy_reg): New arg OMITTED_PERMISSIONS. All uses changed. Omit confusing and unused ", dst_mode" arg to 'open' without O_CREAT. When creating a file, use O_EXCL, so we're more likely to detect funny business by other processes. At the end, if permissions were omitted, chmod them back in. (copy_internal): If the ownership might change, omit some permissions at first, then restore them after chowning the file. * src/cp.c (make_dir_parents_private): Likewise. * src/copy.c (cached_umask): New function. * src/copy.h (cached_umask): New decl.

* src/copy.c (copy_internal): Add a comment saying why we prefer

2006-10-21T07:16:19Z

mknod over mkfifo.

* src/copy.c (copy_reg): Rewrite slightly to avoid duplicte code

2006-10-19T05:22:54Z

when opening dst_name. (copy_reg, copy_internal): Use (SYSCALL != 0) rather than plain (SYSCALL) to test for failure in a system call.

* src/copy.c (copy_internal): Use mknod rather than mkfifo to copy

2006-10-18T22:33:06Z

a fifo. This preserves the special mode bits on Solaris 10, which is compatible with what Solaris 10 cp -R does.

* src/copy.c (copy_internal): Remove redundant and confusing local

2006-10-18T21:02:27Z

variable src_type.

* src/copy.c (copy_internal): Don't pass mkdir a mode greater than

2006-10-18T20:56:38Z

7777. This matches historical 'cp' behavior and avoids some (though not all) implementation-defined behavior of mkdir. * src/cp.c (make_dir_parents_private): Likewise. * src/copy.c (copy_internal): Don't pass 'open' a mode greater than 777. This is required by POSIX. It doesn't make any difference in actual behavior on any host that I know of.

* NEWS: cp -r --backup dir1 dir2, would rename an existing dir1/dir2

2006-10-14T05:20:27Z

to dir1/dir2~. * src/copy.c (copy_internal): Although we do create a backup of each destination directory when in move mode, don't do that when copying. Reported by Peter Breitenlohner, in . * tests/cp/backup-dir: New file. Test for the above.

* NEWS: Mention these fixes.

2006-09-24T19:28:25Z

* src/copy.c (copy_reg): With --verbose (-v), print "removed `file_name'" just after unlinking a file. (copy_internal): Likewise, in three more places. Marc Lehman reported that "touch x; ln x y; mv -v x y" was silent.

* NEWS: Document fix for cp -i and mv -i.

2006-09-20T17:32:14Z

* src/copy.c (copy_internal): With -i, prompt even if the source is a directory and the destination is not. This is required by POSIX and gives the user a chance to bail out before failing. * tests/cp/Makefile.am (TESTS): Add cp-i. * tests/cp/cp-i: New file. * tests/mv/Makefile.am (TESTS): Add i-5. * tests/mv/i-5: New file.