coreutils/src/copy.c, branch v6.8

Adjust preceding change not to perform an unaligned access.

2007-02-22T15:32:45Z

* src/copy.c (copy_reg): Undo previous change. Instead, make it clearer that we're using a single-byte sentinel, and [lint]: Initialize uintptr_t-1 bytes after the sentinel. Reported by Andreas Schwab.

Placate valgrind, wrt ./cp --sparse=always

2007-02-22T11:50:36Z

* src/copy.c (copy_reg): Place the sentinel by setting a full word's worth of bits, not just a single byte's worth. This avoids a harmless (but distracting) case of memory being used-uninitialized.

* src/copy.c (cached_umask): Cast -1 to mode_t to avoid a warning

2007-02-21T16:23:05Z

about out-of-range initializer with Sun C 5.8.

* NEWS: Document fix for cp --preserve=mode.

2007-02-03T17:45:46Z

* src/copy.c (copy_internal): Omit the group- or other-writeable permissions when creating a directory, to avoid a race condition if the special mode bits aren't right just after the directory is created. * src/cp.c (make_dir_parents_private): Likewise. * tests/cp/parent-perm-race: Test for the "cp --preserve=mode" race fix in copy.c.

* src/copy.c (copy_internal): Use mkfifo as a fallback if mknod fails.

2007-01-03T09:46:25Z

Needed on MacOS X. Signed-off-by: Jim Meyering

* src/copy.c (copy_reg): Rewrite a comment that was rendered

2006-12-30T08:34:31Z

inaccurate by the 2006-10-18 change.

cp -p now clears special bits if it fails to preserve owner or group

2006-12-07T07:10:35Z

* NEWS: Document the cp -p fix for special bits. * src/copy.c (set_owner): Now returns a three-way result, so that the caller can clear the special bits. All callers changed. (copy_reg): Don't set the special bits if chown failed. (copy_internal): Likewise. * tests/cp/special-bits: Test this fix. Signed-off-by: Jim Meyering

* NEWS: Document the cp --preserve=ownership fix.

2006-12-06T19:44:08Z

* m4/jm-macros.m4 (coreutils_MACROS): Check for fchmod. * src/copy.c (fchmod_or_lchmod): New function. (copy_reg): New arg OMITTED_PERMISSIONS. All uses changed. Omit confusing and unused ", dst_mode" arg to 'open' without O_CREAT. When creating a file, use O_EXCL, so we're more likely to detect funny business by other processes. At the end, if permissions were omitted, chmod them back in. (copy_internal): If the ownership might change, omit some permissions at first, then restore them after chowning the file. * src/cp.c (make_dir_parents_private): Likewise. * src/copy.c (cached_umask): New function. * src/copy.h (cached_umask): New decl.

* src/copy.c (copy_internal): Add a comment saying why we prefer

2006-10-21T07:16:19Z

mknod over mkfifo.

* src/copy.c (copy_reg): Rewrite slightly to avoid duplicte code

2006-10-19T05:22:54Z

when opening dst_name. (copy_reg, copy_internal): Use (SYSCALL != 0) rather than plain (SYSCALL) to test for failure in a system call.