coreutils/src/csplit.c, branch v8.22Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/
https://git.shady.money/coreutils/atom?h=v8.222013-07-28T01:31:10Zmaint: avoid clang static analysis issues in csplit2013-07-28T01:31:10ZPádraig BradyP@draigBrady.com2013-07-28T01:21:07Zurn:sha1:3ab87d254db5b12804d5bd49d38e63fb59c40f2b
* src/csplit.c (find_lines): Assert that load_buffer() updates the
global buffers, thus "b" will be non NULL, thus suppressing subsequent
NULL pointer derefence warnings.
(process_regexp): Avoid a redundant assignment of the "line" pointer.
(process_line_count): Likewise. Also reduce the "line" pointer scope.
csplit: add the --suppress-matched option2013-04-10T13:34:52ZAssaf Gordonassafgordon@gmail.com2013-03-06T20:53:16Zurn:sha1:4114c93af398d7aecb5eb253f90d9b4cc0785643
With --suppress-matched, the lines that match the pattern will not be
printed in the output files. I.E. the first line from the second
and subsequent splits will be suppressed.
* src/csplit.c: process_regexp(),process_line_count(): Don't output the
matched lines. Since csplit includes "up to but not including" matched
lines in each split, the first line (in the next group) is the matched
line - so just skip it.
main(): Handle new option.
usage(): Mention new option.
* doc/coreutils.texi (csplit invocation): Mention new option, examples.
* tests/misc/csplit-suppress-matched.pl: New test script.
* tests/local.mk: Reference the new test.
* NEWS: Mention new feature.
maint: define usage note about mandatory args centrally2013-01-23T00:03:38ZBernhard Voelkermail@bernhard-voelker.de2013-01-23T00:03:38Zurn:sha1:4eaadb47430f21aee83eb920378be01945845a9a
Each program with at least one long option which is marked as
'required_argument' and which has also a short option for that
option, should print a note about mandatory arguments.
Define that well-known note centrally and use it rather than
literal printf/fputs, and add it where it was missing.
* src/system.h (emit_mandatory_arg_note): Add new function.
* src/cp.c (usage): Use it rather than literal printf/fputs.
* src/csplit.c, src/cut.c, src/date.c, src/df.c, src/du.c:
* src/expand.c, src/fmt.c, src/fold.c, src/head.c, src/install.c:
* src/kill.c, src/ln.c, src/ls.c, src/mkdir.c, src/mkfifo.c:
* src/mknod.c, src/mv.c, src/nl.c, src/od.c, src/paste.c:
* src/pr.c, src/ptx.c, src/shred.c, src/shuf.c, src/sort.c:
* src/split.c, src/stdbuf.c, src/tac.c, src/tail.c, src/timeout.c:
* src/touch.c, src/truncate.c, src/unexpand.c, src/uniq.c:
Likewise.
* src/base64.c (usage): Add call of the above new function
because at least one long option has a required argument.
* src/basename.c, src/chcon.c, src/date.c, src/env.c:
* src/nice.c, src/runcon.c, src/seq.c, src/stat.c, src/stty.c:
Likewise.
maint: update all copyright year number ranges2013-01-01T03:51:20ZJim Meyeringjim@meyering.net2013-01-01T02:54:51Zurn:sha1:77da73c75432f3c5b4beebae7b0797a1e33160bc
Run "make update-copyright", but then also run this,
perl -pi -e 's/2\d\d\d-//' tests/sample-test
to make that one script use the single most recent year number.
maint: avoid a static analysis warning in csplit2012-06-26T10:27:32ZPádraig BradyP@draigBrady.com2012-06-26T10:13:45Zurn:sha1:5958bb44c4d7cf3b69bb62955b3ece9d0715eb60
The Canalyze static code analyzer correctly surmised
that there is a use-after-free bug in free_buffer()
at the line "struct line *n = l->next", if that
function is called multiple times.
This is not a runtime issue since a list of lines
will not be present in the !lines_found case.
* src/csplit.c (free_buffer): Set list head to NULL so
that this function can be called multiple times.
(load_buffer): Remove a redundant call to free_buffer().
Reported-by: Xu Zhongxing
maint: use single copyright year range2012-01-27T10:35:24ZJim Meyeringmeyering@redhat.com2012-01-27T10:35:24Zurn:sha1:d7878454cd02518959b0d6036db3a5b6ff00ca57
Run "make update-copyright".
maint: src/*.c: change remaining quotes (without embedded spaces)2012-01-09T20:50:08ZJim Meyeringmeyering@redhat.com2012-01-08T14:08:30Zurn:sha1:a517386f1bf8c64ee7617cc2c9d0a16a1d85c8c4
Run this (twice):
git grep -E -l '`[^ ]+'\' src/*.c \
|xargs perl -pi -e 's/`([^ ]+'\'')/'\''$1/'
maint: convert `...' to '...' in --help output2012-01-09T20:50:08ZJim Meyeringmeyering@redhat.com2012-01-08T13:08:03Zurn:sha1:9af0dced5a2eb167ec7b9dfe3f358f214e45d41a
All affected lines end with \ or \n\, so run this command
until it produces no new changes (4 times):
git grep -E -l '`[^ ]+'\''.*\\' src \
|xargs perl -pi -e 's/`([^ ]+'\''.*\\)/'\''$1/'
maint: adjust quoting: emit '...', not `...' in diagnostics2012-01-09T20:50:08ZJim Meyeringmeyering@redhat.com2012-01-07T17:30:14Zurn:sha1:36b9a1b6ac2730e78c14552fd55795fe10862a3d
* src/csplit.c (parse_repeat_count, extract_regexp): As above.
* src/date.c (main): Likewise.
* src/ls.c (decode_switches): Likewise.
* src/od.c (decode_one_format, main): Likewise.
* src/pathchk.c (no_leading_hyphen): Likewise.
* src/pr.c (main, getoptarg): Likewise.
* src/rm.c (diagnose_leading_hyphen): Likewise.
* src/sort.c (key_warnings, incompatible_options, main): Likewise.
* src/stat.c (print_esc_char): Print '\x', not `\x' in diagnostic.
* src/test.c (main): Likewise.
* src/touch.c (main): Likewise.
* src/tr.c (build_spec_list, validate, append_range): Likewise.
* tests/misc/mktemp: This is an unusual case, since the affected
string contains only the ` of an `...' string. So we change
the long ` to a lone '.
* tests/pr/pr-tests: Manual quote adapting fix-up.
* tests/ln/hard-to-sym: Likewise.
* tests/split/suffix-length: Likewise.
* tests/mv/part-fail: Likewise.
* tests/misc/chcon: Likewise.
* tests/misc/stat-printf: Likewise.
maint: use new emit_try_help in place of equivalent fprintf2012-01-07T15:54:26ZJim Meyeringmeyering@redhat.com2012-01-07T15:54:26Zurn:sha1:101d1203c667ec3ab54a026dde43117563d4e944
Run this command:
perl -0777 -pi -e \
's/fprintf \(stderr, _\("Try `%s --help.*\n.*;/emit_try_help ();/m'\
src/*.c