coreutils/src/csplit.c, branch v8.9Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/
https://git.shady.money/coreutils/atom?h=v8.92011-01-01T21:16:47Zmaint: update all copyright year number ranges2011-01-01T21:16:47ZJim Meyeringmeyering@redhat.com2011-01-01T10:37:32Zurn:sha1:9d6231ef2a74671fa08bc263519edfe46e8d1805
Run "make update-copyright".
csplit: diagnose file counter wraparound2010-12-23T08:07:59ZPaul Eggerteggert@cs.ucla.edu2010-12-23T08:07:35Zurn:sha1:bc4e77927c6610d856bec90a60da931e33d3abbb
* src/csplit.c (create_output_file): Detect overflow when the
file counter wraps around, and exit with a diagnostic. Formerly
the code silently wrapped around and wrote to the wrong file,
losing output data.
maint: fix a new -Wpointer-sign gcc warning2010-11-16T00:38:12ZPádraig BradyP@draigBrady.com2010-11-16T00:31:05Zurn:sha1:0d1ba34494e5e5e21e205f2e86349afeb69ca84d
* src/csplit.c (max_out): Fix a new warning introduced with
commit 6568b173, 2010-11-10, "csplit: do not rely on..."
csplit: do not rely on undefined behavior in printf formats2010-11-11T07:16:24ZPaul Eggerteggert@cs.ucla.edu2010-11-11T04:34:52Zurn:sha1:6568b173db1c98f39a53eadd9b09e0a0e5c11920
* doc/coreutils.texi (csplit invocation): Say that %d and %i are
aliases for %u.
* src/csplit.c (FLAG_THOUSANDS, FLAG_ALTERNATIVE): New constants.
(get_format_flags): Now take char const * and int * and return
size_t. It now stores info about the flags instead of merely
scanning them. Also, it handles '0' correctly. Drop support for
the undocumented '+' and ' ' flags since the value is unsigned.
Add support for the (undocumented) "'" flag. All uses changed.
(get_format_width, get_format_prec): Remove.
(check_format_conv_type): Renamed from get_format_conv_type, with
a different signature. It now converts the format to one that is
compatible with unsigned int, and checks flags. All uses changed.
(max_out): Have snprintf compute the number of bytes needed rather
than attempting to do it ourselves (which doesn't work portably
with outlandish formats such as %4294967296d).
(check_format_conv_type, main): Check for overflow in size
calculations. Don't assume size_t fits in unsigned int.
* tests/misc/csplit: Check for proper handling of flags, with
%0#6.3x. Coreutils 8.6 mishandles this somewhat-weird example.
csplit: fix a memory leak per input buffer2010-11-11T01:40:12ZPádraig BradyP@draigBrady.com2010-11-10T14:35:17Zurn:sha1:0339eb4598600024cedca14a7e882c1737dd2d82
* src/csplit.c (free_buffer): Also free the line offsets buffers
(remove_line): Also free the containing structure
* tests/misc/csplit-heap: A new test to trigger with leaks of
this magnitude.
* tests/Makefile.am: Reference the new test
* NEWS: Mention the fix
Reported by David Hofstee
csplit: avoid buffer overrun when writing more than 999 files2010-11-10T13:28:03ZJim Meyeringmeyering@redhat.com2010-11-10T12:53:38Zurn:sha1:0cfd4f2161de5e942cbd7c273d03a90c1dfd2062
Without this fix, seq 1000 | csplit - /./ '{*}' would write
the NUL-terminated file name, xx1000, into a buffer of size 6.
* src/csplit.c (main): Use properly sized file name buffer.
* NEWS (Bug fixes): Mention it.
* tests/misc/csplit-1000: New test to trigger the bug.
* tests/Makefile.am (TESTS): Add misc/csplit-1000.
maint: replace each "for (;;)" with "while (true)"2010-05-31T09:02:21ZJim Meyeringmeyering@redhat.com2010-05-01T12:24:35Zurn:sha1:da7a704cd36e1d2015d14247e5139fb1999b2211
Run this command:
git ls-files | grep '\.[ch]$' \
| xargs perl -pi -e 's/for \(;;\)/while (true)/g'
...except for randint.c, which does not include stdbool.h.
In that case, use "while (1)".
* gl/lib/randint.c (randint_genmax): Use "while (1)" for infloops.
* src/cat.c (simple_cat, cat): Use "while (true)" for infloops.
* gl/lib/randread.c (readsource, readisaac): Likewise.
* src/copy.c (copy_reg): Likewise.
* src/csplit.c (record_line_starts, process_regexp): Likewise.
* src/cut.c (set_fields): Likewise.
* src/dd.c (iread, parse_symbols): Likewise.
* src/df.c (find_mount_point, main): Likewise.
* src/du.c (main): Likewise.
* src/expand.c (expand): Likewise.
* src/factor.c (factor_using_division, do_stdin): Likewise.
* src/fmt.c (get_space): Likewise.
* src/ls.c (decode_switches): Likewise.
* src/od.c (main): Likewise.
* src/pr.c (main, read_line): Likewise.
* src/shred.c (dopass, genpattern): Likewise.
* src/sort.c (initbuf, fillbuf, getmonth, keycompare): Likewise.
* src/split.c (bytes_split, lines_split): Likewise.
* src/tac.c (tac_seekable): Likewise.
* src/test.c (and, or): Likewise.
* src/tr.c (squeeze_filter, main): Likewise.
* src/tsort.c (search_item): Likewise.
* src/unexpand.c (unexpand): Likewise.
* src/uniq.c (main): Likewise.
* src/yes.c (main): Likewise.
maint: update all FSF copyright year lists to include 20102010-01-01T13:06:47ZJim Meyeringmeyering@redhat.com2010-01-01T09:56:28Zurn:sha1:1aa17dc89b3f313697661541adca0aa0defbdc09
Use this command:
git ls-files | grep -v COPYING \
| xargs env UPDATE_COPYRIGHT_USE_INTERVALS=1 \
build-aux/update-copyright
doc: mention the texinfo documentation in --help2009-09-21T11:37:57ZPádraig BradyP@draigBrady.com2009-09-18T22:06:21Zurn:sha1:5d4f09d83a7c69110b4db97443759e9046c149e1
* src/system.h: Rename emit_bug_reporting_address() to
emit_ancillary_info() and update it to not print the translation
project address in en_* locales, and _do_ print it in the 'C'
(and other) locales so that it's included in the default man page.
Also mention how to invoke the texinfo documentation for each command.
Also move the "hard-locale.h" include to the 8 files that now use it.
* man/help2man: Strip the newly added texinfo reference from the
--help output as a more verbose version is already added by help2man.
Suggestion from C de-Avillez
global: convert indentation-TABs to spaces2009-08-25T07:21:00ZJim Meyeringmeyering@redhat.com2009-08-22T16:56:06Zurn:sha1:5e778f7c8d1ecf3d8f11385db013af2ba026e2a5
Transformed via this shell code:
t=$'\t'
git ls-files \
| grep -vE '(^|/)((GNU)?[Mm]akefile|ChangeLog)|\.(am|mk)$' \
| grep -vE 'tests/pr/|help2man' \
| xargs grep -lE "^ *$t" \
| xargs perl -MText::Tabs -ni -le \
'$m=/^( *\t[ \t]*)(.*)/; print $m ? expand($1) . $2 : $_'