coreutils/src/dd.c, branch v6.8

Honor dd's noatime flag if possible, even if not supported on build fs

2007-02-22T18:09:35Z

* doc/coreutils.texi (dd invocation): Warn that noatime might not be reliable. * src/dd.c (flags, usage): Look at O_NOATIME, not HAVE_WORKING_O_NOATIME, to decide whether to support the noatime flag, so that dd attempts O_NOATIME even if the build file system does not support it. Problem reported by Jim Meyering today in bug-coreutils. * tests/dd/misc: Generate a warning, not a failure, if noatime exists but fails.

Remove excess leading spaces that would make help2man misbehave.

2007-02-10T21:30:18Z

* src/printf.c (usage): Remove excess spaces on 2nd line of %b desc. * src/nl.c (usage): Remove excess spaces on 2nd line of pBRE desc. * src/dd.c (usage): Remove excess spaces on 2nd line of sync desc. * src/date.c (usage): Use two spaces after each optional flag, not one. Reported by Thomas Huriaux in .

* src/dd.c (advance_input_after_read_error): Change diagnostic to

2007-01-26T15:37:37Z

say "invalid file offset" rather than "screwy file offset".

* NEWS: dd bs= operands now silently override later ibs= and obs=,

2006-12-22T09:09:37Z

as POSIX requires. * src/dd.c (scanargs): Implement it. * tests/dd/misc (outbytes): Test it. * doc/coreutils.texi (dd invocation): Specify that bs=N overrides later ibs and obs, undoing part of the previous change. (The behavior was wrong.)

Improve the check for departures from C89, and fix the departures

2006-11-27T10:27:46Z

I found. * Makefile.maint (my-distcheck): Also check for C89 compatibility as best we can with GCC. * src/stat.c (PRINTF_OPTION): Omit comma before } in enum declaration; C89 doesn't allow this. * src/dcgen: Don't generate string literals longer than what C89 requires support for. * src/cut.c (usage): Don't use string literals longer than what C89 requires support for. * src/date.c (usage): Likewise. * src/dd.c (usage): Likewise. * src/du.c (usage): Likewise. * src/ls.c (usage): Likewise. * src/od.c (usage): Likewise. * src/readlink.c (usage): Likewise. * src/seq.c (usage): Likewise. * src/shred.c (usage): Likewise.

Help valgrind see that there is no leak in dd.c.

2006-11-16T08:15:47Z

* src/dd.c (dd_copy): Declare real_buf and real_obuf to be static, so we need not free them at all. This is easier than freeing both buffers at each of the early "return"s.

* src/dd.c (usage): Use two spaces (not one) to separate the

2006-10-17T13:51:47Z

"fdatasync" option string from its description, so help2man formats the derived man page properly. Reported by Samuel Thibault in .

* src/dd.c (flags): noatime and nofollow now depend on

2006-10-05T21:39:12Z

HAVE_WORKING_O_NOATIME and HAVE_WORKING_O_NOFOLLOW, too. (usage): Output info about noatime and nofollow only if they are known to work. * src/remove.c (AD_push): Inspect HAVE_WORKING_O_NOFOLLOW rather than O_NOFOLLOW, when testing whether it's possible to avoid a race condition reliably.

Fix bugs when printing plurals of numbers that are not

2006-08-16T19:36:46Z

unsigned long int values. * src/system.h (select_plural): New function. * src/md5sum.c (digest_check): Use select_plural to avoid bug. * src/uptime.c (print_uptime): Likewise. * src/dd.c (print_stats): Likewise. Also, don't use ngettext to print a floating point number, as reducing to 0 or 1 doesn't work for some languages. Instead, just use "s" for seconds since it doesn't need a plural form.

* src/dd.c (print_stats): Don't substitute "1" for number, as this

2006-08-15T20:50:22Z

causes confusion for the Hungarian translators. Problem reported by Egmont Koblinger.