coreutils/src/env.c, branch v9.0

env: fix usage typo

2021-07-26T07:59:36Z

* src/env.c (usage): Fix pluralization typo.

maint: use "char const " rather than "const char "

2021-04-11T17:33:45Z

* cfg.mk (sc_prohibit-const-char): Add a new syntax-check to enforce this style. * *.[ch]: sed -i 's/const char \*/char const */g'

env: simplify --split-string memory management

2021-03-30T04:44:58Z

* bootstrap.conf (gnulib_modules): Add idx. * src/env.c: Include idx.h, minmax.h. Prefer idx_t to ptrdiff_t when values are nonnegative. (valid_escape_sequence, escape_char, validate_split_str) (CHECK_START_NEW_ARG): Remove; no longer needed now that we validate as we go. (struct splitbuf): New type. (splitbuf_grow, splitbuf_append_byte, check_start_new_arg) (splitbuf_finishup): New functions. (build_argv): New arg ARGC. Validate and process in one go, using the new functions; this is simpler and more reliable than the old approach (as witness the recent bug). Avoid integer overflow in the unlikely case where the string contains more than INT_MAX arguments. (parse_split_string): Simplify by exploiting the new build_argv.

env: prefer ptrdiff_t

2021-03-26T22:17:28Z

* src/env.c (usvars_used, vnlen, unset_envvars, expansion) (build_argv): Prefer ptrdiff_t to size_t when either will do.

env: improve whitespace warning

2021-03-26T22:17:28Z

* src/env.c (main): Issue -S warning for any whitespace, not just space.

env: use GNU coding style

2021-03-26T22:17:28Z

* src/env.c: Use GNU coding style for recentish changes.

env: remove asserts

2021-03-26T22:17:28Z

The assertions didn’t help catch the most recent bug which was in their area, and kind of get in the way. * src/env.c: Do not include , and remove all assertions. These seem to have been put in to pacify gcov, but surely there’s a better way. (escape_char): Pacify GCC with 'assume' instead.

env: fix address violation with '\v' in -S

2021-03-26T20:50:16Z

Problem reported by Frank Busse (Bug#47412). * src/env.c (C_ISSPACE_CHARS): New macro. (shortopts, build_argv, main): Treate all C-locale space characters like space and tab, for compatibility with FreeBSD. (validate_split_str, build_argv, parse_split_string): Use the C locale, not the current locale, to determine whether a byte is a space character.

maint: update all copyright year number ranges

2021-01-01T16:36:09Z

Run "make update-copyright" and then... * gnulib: Update to latest with copyright year adjusted. * tests/init.sh: Sync with gnulib to pick up copyright year. * bootstrap: Likewise. * tests/sample-test: Adjust to use the single most recent year.

maint: avoid warnings from GCC's -fanalyzer

2020-05-11T20:18:47Z

* src/env.c (build_argv): Add an assert() to avoid: warning: use of NULL 'n' where non-null expected [CWE-690] [-Wanalyzer-null-argument] note: argument 1 of 'getenv' must be non-null * src/dd.c (alloc_ibuf): Don't discard the allocated pointer, to avoid: [CWE-401] [-Wanalyzer-malloc-leak] (alloc_obuf): Likewise. (cleanup): Deallocate the now tracked buffers which also avoids "possibly lost" warnings from valgrind. * src/tsort.c (search_item): Add asserts to avoid: [CWE-690] [-Wanalyzer-null-dereference] (record_relation): An assert doesn't suffice here, so disable the warning for this function. * src/comm.c: Suppress the following false positive for the whole file: [CWE-457] [-Wanalyzer-use-of-uninitialized-value] * src/chown-core.c: Suppress the following false positive for the file: [CWE-415] [-Wanalyzer-double-free]

coreutils/src/env.c, branch v9.0

env: fix usage typo

maint: use "char const *" rather than "const char *"

env: simplify --split-string memory management

env: prefer ptrdiff_t

env: improve whitespace warning

env: use GNU coding style

env: remove asserts

env: fix address violation with '\v' in -S

maint: update all copyright year number ranges

maint: avoid warnings from GCC's -fanalyzer

maint: use "char const " rather than "const char "