Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/ https://git.shady.money/coreutils/atom?h=v8.22 2013-09-21T12:15:45Z 2013-09-21T12:15:45Z Bernhard Voelker mail@bernhard-voelker.de 2013-09-21T12:15:45Z urn:sha1:2a0d241f69f7f3f5b826656a97f9bafb20bd8711 * src/group-list.h (print_group_list): Add a parameter for the delimiter of type char. * src/group-list.c (print_group_list): Likewise, and use it instead of a white space character to delimit the group entries. * src/groups.c (main): Pass white space character to print_group_list(). * src/id.c (longopts): Add array element for the new long option. (usage): Document the new option. While at it, fix the alignment of the descriptions to match that of HELP_OPTION_DESCRIPTION. (main): Define the bool flag opt_zero indicating the use of the new option. In the getopt_long loop, handle it. Output an error diagnostic in the case the --zero option has been specified together with the default format. In the case of -gG, pass either a NUL or a white space character to print_group_list() - depending on the above new flag. Likewise change the printing of the final newline character: output a NUL instead if the --zero option has been specified. * doc/coreutils.texi (id invocation): Document the new option. While at it, move the @exitstatus macro down after the macro @primaryAndSupplementaryGroups in order to be consistent with other texinfo documents. (groups invocation): Move @exitstatus down after the macro @primaryAndSupplementaryGroups here, too. * tests/misc/id-zero.sh: Add new test exercising the new option. * tests/local.mk (all_tests): Reference it. * NEWS (New features): Mention the new option. Fixes http://bugs.gnu.org/9987 2013-01-01T03:51:20Z Jim Meyering jim@meyering.net 2013-01-01T02:54:51Z urn:sha1:77da73c75432f3c5b4beebae7b0797a1e33160bc Run "make update-copyright", but then also run this, perl -pi -e 's/2\d\d\d-//' tests/sample-test to make that one script use the single most recent year number. 2012-05-20T15:29:32Z Jim Meyering meyering@redhat.com 2012-01-01T21:31:41Z urn:sha1:b663bc8eb0b87c21584b931872db5fd82cf72f49 * src/id.c (gidtostr, uidtostr): Define macros. (gidtostr_ptr, uidtostr_ptr): Define safer functions. Use gidtostr and uidtostr to print GID and UID without need/risk of casts. * src/group-list.c: Likewise. 2012-04-27T17:54:03Z Jim Meyering meyering@redhat.com 2012-04-27T11:28:32Z urn:sha1:032a549481444395558286b433296c97c09c721d ... i.e., don't use the getpw* functions. Before this change, running groups or id with no user name argument would include a group name or ID from /etc/passwd. Thus, under unusual circumstances (default group is changed, but has not taken effect for a given session), those programs could print a name or ID that is neither real nor effective. To demonstrate, run this: echo 'for i in 1 2; do id -G; sleep 1.5; done' \ |su -s /bin/sh ftp - & sleep 1; perl -pi -e 's/^(ftp:x:\d+):(\d+)/$1:9876/' /etc/passwd Those id -G commands printed the following: 50 50 9876 With this change, they print this: 50 50 Similarly, running those programs set-GID could make them print one ID too many. * src/group-list.c (print_group_list): When username is NULL, pass egid, not getpwuid(ruid)->pw_gid), to xgetgroups, per the API requirements of xgetgroups callee, mgetgroups. When not using the password database, don't call getpwuid. * NEWS (Bug fixes): Mention it. * tests/misc/id-setgid: New file. * tests/Makefile.am (TESTS): Add it. (root_tests): It's a root-only test, so add it here, too. Originally reported by Brynnen Owen as http://bugs.gnu.org/7320. Raised again by Marc Mengel in http://bugzilla.redhat.com/816708. 2012-01-01T09:04:06Z Jim Meyering meyering@redhat.com 2012-01-01T08:47:10Z urn:sha1:5111aa42968262bd4d44eeca277b194020bb5007 Run "make update-copyright". 2011-01-01T21:16:47Z Jim Meyering meyering@redhat.com 2011-01-01T10:37:32Z urn:sha1:9d6231ef2a74671fa08bc263519edfe46e8d1805 Run "make update-copyright". 2010-01-01T13:06:47Z Jim Meyering meyering@redhat.com 2010-01-01T09:56:28Z urn:sha1:1aa17dc89b3f313697661541adca0aa0defbdc09 Use this command: git ls-files | grep -v COPYING \ | xargs env UPDATE_COPYRIGHT_USE_INTERVALS=1 \ build-aux/update-copyright 2009-12-05T02:18:06Z Eric Blake ebb9@byu.net 2009-12-04T15:06:55Z urn:sha1:9b4b38f56e854f8f1343fed9dbc225ffbb1d77d4 If getgroups failed with ENOSYS, mgetgroups would unnecessarily fail, and that provoked id into freeing an uninitialized pointer. Meanwhile, we were not using xalloc_die properly. Both issues are better solved in gnulib, by introducing xgetgroups; this patch uses the new interface. Regression introduced by commit 6a31fd8d7. * gnulib: Update, for mgetgroups improvments. * src/id.c (print_full_info): Adjust caller to die on allocation failure, and no longer worry about ENOSYS. * src/group-list.c (print_group_list): Likewise. * src/setuidgid.c (main): Likewise. * NEWS: Mention the fix. * THANKS: Update. Reported by Scott Harrison. 2009-11-13T14:50:20Z Eric Blake ebb9@byu.net 2009-11-12T18:59:09Z urn:sha1:6a31fd8d732afd232d6a99708192170e13129374 A replacement getgroups is now guaranteed to exist, but it may fail with ENOSYS. mgetgroups is moved to gnulib, and now takes gid_t instead of GETGROUPS_T (but setgroups still needs GETGROUPS_T). * gnulib: Update to latest. * gl/modules/mgetgroups: Delete, moved to gnulib. * gl/m4/mgetgroups.m4: Likewise. * gl/lib/mgetgroups.h: Likewise. * gl/lib/mgetgroups.c: Likewise. * src/group-list.c (print_group_list): Adjust callers. * src/id.c (print_full_info): Likewise. 2009-08-25T07:21:00Z Jim Meyering meyering@redhat.com 2009-02-27T16:15:43Z urn:sha1:e2808a3999233c7186ee349278dbff5a046250db * src/getlimits.c: Likewise. * src/group-list.c: Likewise. * src/groups.c: Likewise. * src/mktemp.c: Likewise. * src/setuidgid.c: Likewise. * src/stdbuf.c: Likewise. * src/timeout.c: Likewise. * src/truncate.c: Likewise. * gl/lib/mbsalign.c: Likewise. * tests/test-lib.sh: Likewise. * bootstrap: Likewise. * README-hacking: Likewise.