coreutils/src/head.c, branch v8.22Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/
https://git.shady.money/coreutils/atom?h=v8.222013-07-11T23:25:42Zhead: avoid redundant allocations when reading empty files2013-07-11T23:25:42ZPádraig BradyP@draigBrady.com2013-07-09T17:45:34Zurn:sha1:5fdb50825f598035d52ea8a26be7611e1a906703
* src/head.c (elide_tail_lines_file): For seekable empty files,
or seekable files where the current offset is after the
end of the file, return immediately. Previously the short
circuit code could not be reached due to logic error.
Spotted by coverity.
head: with --bytes=-N only allocate memory as needed2013-04-14T00:01:21ZPádraig BradyP@draigBrady.com2013-01-23T12:34:46Zurn:sha1:1fe218888aace1703f78e0af0059d7a15485bf7f
* src/head.c (elide_tail_bytes_pipe): Don't use calloc as that
bypasses memory overcommit due to the zeroing requirement.
Also realloc rather than malloc the pointer array to avoid
dependence on overcommit entirely.
* tests/misc/head-c.sh: Add a test case.
Fixes http://bugs.gnu.org/13530
maint: improve error messages upon failed read, write, access, close2013-02-06T15:57:34ZBenno Schulenbergbensberg@justemail.net2013-01-04T21:45:34Zurn:sha1:a1ee5cd714c0825b0244d09bbaa0a61c883ac18f
Note we use "failed to {access,close}" for those single operations,
and "error {read,writ}ing" for those partial operation failures.
* src/copy.c: Improve error messages for failing read, write and close.
* src/cp.c: Improve error messages for failing access.
* src/dd.c: Improve error messages for failing read, write and open.
* src/head.c: Improve error message for failing close.
* src/install.c: Improve error messages for failing access.
* src/ln.c: Likewise.
* src/mv.c: Likewise.
* src/touch.c: Improve error message for failing close.
* src/truncate.c: Likewise.
maint: define usage note about mandatory args centrally2013-01-23T00:03:38ZBernhard Voelkermail@bernhard-voelker.de2013-01-23T00:03:38Zurn:sha1:4eaadb47430f21aee83eb920378be01945845a9a
Each program with at least one long option which is marked as
'required_argument' and which has also a short option for that
option, should print a note about mandatory arguments.
Define that well-known note centrally and use it rather than
literal printf/fputs, and add it where it was missing.
* src/system.h (emit_mandatory_arg_note): Add new function.
* src/cp.c (usage): Use it rather than literal printf/fputs.
* src/csplit.c, src/cut.c, src/date.c, src/df.c, src/du.c:
* src/expand.c, src/fmt.c, src/fold.c, src/head.c, src/install.c:
* src/kill.c, src/ln.c, src/ls.c, src/mkdir.c, src/mkfifo.c:
* src/mknod.c, src/mv.c, src/nl.c, src/od.c, src/paste.c:
* src/pr.c, src/ptx.c, src/shred.c, src/shuf.c, src/sort.c:
* src/split.c, src/stdbuf.c, src/tac.c, src/tail.c, src/timeout.c:
* src/touch.c, src/truncate.c, src/unexpand.c, src/uniq.c:
Likewise.
* src/base64.c (usage): Add call of the above new function
because at least one long option has a required argument.
* src/basename.c, src/chcon.c, src/date.c, src/env.c:
* src/nice.c, src/runcon.c, src/seq.c, src/stat.c, src/stty.c:
Likewise.
maint: update all copyright year number ranges2013-01-01T03:51:20ZJim Meyeringjim@meyering.net2013-01-01T02:54:51Zurn:sha1:77da73c75432f3c5b4beebae7b0797a1e33160bc
Run "make update-copyright", but then also run this,
perl -pi -e 's/2\d\d\d-//' tests/sample-test
to make that one script use the single most recent year number.
maint: mark new diagnostic for translation2012-06-05T20:41:06ZJim Meyeringmeyering@redhat.com2012-06-05T20:38:26Zurn:sha1:020851e467071face71df533f99cce971eb9bb38
* src/head.c (elide_tail_lines_seekable): Mark new diagnostic.
I will look at the results of "make syntax-check", I will look...
head: with --lines=-N (-n-N) reset file pointer on seekable input2012-06-05T17:55:26ZJim Meyeringmeyering@redhat.com2012-06-05T10:24:49Zurn:sha1:295ee521bc1a4f473ee8b7b5a4be32c5b5c7386f
* src/head.c (elide_tail_lines_seekable): Reset file pointer
after printing up to an end-relative line-counted offset.
Anoop Sharma reported the problem and suggested the fix.
* tests/misc/head-pos: Add coverage via a very similar, existing test.
Also add coverage for a previously untested block of code.
* tests/misc/head-elide-tail ($READ_BUFSIZE): Update to 8192, to
match the value of BUFSIZ I see today on Fedora 17/x86_64 (unrelated
to this fix).
* NEWS (Bug fixes): Mention it.
Improved-by: Pádraig Brady
maint: use single copyright year range2012-01-27T10:35:24ZJim Meyeringmeyering@redhat.com2012-01-27T10:35:24Zurn:sha1:d7878454cd02518959b0d6036db3a5b6ff00ca57
Run "make update-copyright".
maint: src/*.[ch]: convert more `...' to '...'2012-01-09T20:51:59ZJim Meyeringmeyering@redhat.com2012-01-08T20:03:22Zurn:sha1:3ba8b044267a5f7cfa8a7b0d7f19dab3f21431da
Run this (twice):
git grep -E -l '`.+'\' src/*.[ch] \
|xargs perl -pi -e 's/`(.+?'\'')/'\''$1/'
maint: src/*.c: change remaining quotes (without embedded spaces)2012-01-09T20:50:08ZJim Meyeringmeyering@redhat.com2012-01-08T14:08:30Zurn:sha1:a517386f1bf8c64ee7617cc2c9d0a16a1d85c8c4
Run this (twice):
git grep -E -l '`[^ ]+'\' src/*.c \
|xargs perl -pi -e 's/`([^ ]+'\'')/'\''$1/'