coreutils/src/install.c, branch v8.26Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/
https://git.shady.money/coreutils/atom?h=v8.262016-11-28T16:17:31Zinstall,mkdir: fix handling of -DZ and -pZ, respectively2016-11-28T16:17:31ZKamil Dudkakdudka@redhat.com2016-11-28T15:21:42Zurn:sha1:d8104265f229ababd5a68a46eeccbccc07e72cdc
... in the case where two or more directories nested in each other are
created and each of them defaults to a different SELinux context.
* src/install.c (make_ancestor): When calling defaultcon(), give it the
same path that is given to mkdir(). The other path is not always valid
wrt. current working directory.
* src/mkdir.c (make_ancestor): Likewise.
* NEWS: Mention the bug fix.
Reported at https://bugzilla.redhat.com/1398913
cp: improve status message when omitting directories2016-11-19T17:05:33ZPádraig BradyP@draigBrady.com2016-11-19T11:26:43Zurn:sha1:f1799198483171c8565a4ff8fc1205d0a52fce37
* src/copy.h (cp_options): Add a new flag for install(1).
* src/copy.c (copy_internal): For cp, also output remediation
advice which also indicates why directories aren't copied by default.
The message is unchanged for install(1).
* src/cp.c (cp_option_init): Init install_mode to false.
* src/mv.c (cp_option_init): Likewise.
* src/install.c (cp_option_init): Init install_mode to true.
* tests/install/basic-1.sh: Add a test case.
* tests/cp/link-deref.sh: Adjust test case.
Fixes http://bugs.gnu.org/24958
maint: refactor printing of backup suffix --help2016-11-07T17:09:35ZPádraig BradyP@draigBrady.com2016-11-02T23:56:53Zurn:sha1:7ce2589b77d6f78548d6d025ab7d8f5a57199ef8
* src/system.h (emit_backup_suffix_note): A new function to
output the backup suffix info. The strings are unchanged,
so translations are not impacted.
* src/cp.c (usage): Use the new function.
* src/ln.c (usage): Likewise.
* src/mv.c (usage): Likewise.
* src/install.c (usage): Likewise.
maint: simplify handling of backup --suffix in various tools2016-11-07T17:09:35ZRishabh Daverishabhddave@gmail.com2016-11-02T23:43:47Zurn:sha1:ec946718ae7c329ba4d4ef46a467bba125c141a6
* src/cp.c (main): Avoid the getenv("SIMPLE_BACKUP_SUFFIX") call,
which is now done if needed in the gnulib backupfile module.
Also avoid the redundant strdup, as we don't modify this suffix.
* src/install.c (main): Likewise.
* src/ln.c (main): Likewise.
* src/mv.c (main): Likewise.
Fixes http://bugs.gnu.org/23153
all: use die() rather than error(EXIT_FAILURE)2016-10-16T11:23:55ZPádraig BradyP@draigBrady.com2016-10-15T22:10:35Zurn:sha1:492dcb2eb191b844a2fd5e51db3eed85289bea1f
die() has the advantage of being apparent to the compiler
that it doesn't return, which will avoid warnings in some cases,
and possibly generate better code.
* cfg.mk (sc_die_EXIT_FAILURE): A new syntax check rule to
catch any new uses of error (CONSTANT, ...);
build: add die.h; avoid new warnings from GCC 72016-10-15T15:41:42ZJim Meyeringmeyering@fb.com2016-10-05T02:20:46Zurn:sha1:dad7ab0b7b322a800e6b1012b777169169068388
* src/die.h (die): New file/function from grep.
Note: we expect this file to migrate to gnulib.
* src/csplit.c: Include die.h.
(check_format_conv_type): Use die in place of error-nonzero;break;
* src/install.c (strip): Likewise.
* src/nl.c (proc_text): Likewise. This also suppresses a new warning
from GCC 7's -Werror=strict-overflow.
* src/tail.c (parse_options): Likewise.
* src/basename.c (main): Adjust "fall through" comment
so that GCC 7's -Wimplicit-fallthrough honors it.
* src/cp.c (main): Add a "fall through" comment.
* src/ls.c (gobble_file): Likewise.
(get_funky_string): Adjust a "fall through" comment so it is
recognized.
* cfg.mk (exclude_file_name_regexp--sc_system_h_headers): Add die.h
to this list of exempt src/*.h files.
install: with -Z, set default SELinux context for created directories2016-07-08T17:40:23ZKamil Dudkakdudka@redhat.com2016-07-08T16:59:35Zurn:sha1:502518b44039138d148e2e15157d125c82d02af0
* doc/coreutils.texi (install invocation): Update -Z documentation.
* src/install.c (make_ancestor): Set default security context before
calling mkdir() if the -Z option is given.
(process_dir): Call restorecon() on the destination directory if the
-Z option is given.
(usage): Update -Z documentation.
* tests/install/install-Z-selinux.sh: A new test for 'install -Z -D'
and 'install -Z -d' based on tests/mkdir/restorecon.sh.
* tests/local.mk: Reference the test.
* NEWS: Mention the improvement.
Reported at https://bugzilla.redhat.com/1339135
Fixes http://bugs.gnu.org/23868
doc: mention in more places that -D will create --target-directory2016-01-03T12:58:39ZPádraig BradyP@draigBrady.com2016-01-02T22:22:55Zurn:sha1:1dd02b4f8c459a4e720343a3f2d1eedf9bdbe657
* src/install.c (usage): Mention this commonly required functionality
in the -D option description.
* doc/coreutils.texi (install invocation): Likewise for the
--target-directory description.
install: only attempt to create a target dir once2016-01-03T12:58:39ZPádraig BradyP@draigBrady.com2016-01-02T22:14:41Zurn:sha1:73055581c9ef167faff210338775f668277603ee
* src/install.c (main): As an optimization, when calling
install_file_in_dir() for each file, only attempt to create
the target directory once, as this is invariant over the loop.
install: fix relative copies to absolute directory with -D2016-01-03T12:58:39ZPádraig BradyP@draigBrady.com2016-01-02T18:38:37Zurn:sha1:6c65ce4c643b038c61bd332aab5ea87a75117273
* src/install.c (mkancesdirs_safe_wd): Unconditionally
restore the current working directory when possibly called
multiple times (from install_file_in_dir()).
* tests/install/create-leading.sh: Add a test case.
* NEWS: Mention the fix.
Fixes http://bugs.gnu.org/21497