Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/ https://git.shady.money/coreutils/atom?h=v8.22 2013-12-03T09:03:51Z 2013-12-03T09:03:51Z Bernhard Voelker mail@bernhard-voelker.de 2013-12-03T07:02:57Z urn:sha1:f65a3841606fcbc256c5dfcb7bd3ef90a7adec10 Add a new rule to ensure the use of quote() instead of '%s' or `%s' in format strings of diagnostics messages. * cfg.mk (sc_prohibit_quotes_notation): Add rule. * TODO: Remove the entry regarding the '%s' notation. * src/mkfifo.c (main): Remove the offending and in this case even duplicate quoting in the format string of the error diagnostic. * src/mknod.c (main): Likewise. * src/df.c (decode_output_arg): Change two invocations of error() according to the above new rule. * src/numfmt.c: Fix numerous wrong quote notations to fit the above new rule, mostly in internal debugging diagnostic messages. 2013-08-02T06:31:36Z Bernhard Voelker mail@bernhard-voelker.de 2013-08-01T02:18:00Z urn:sha1:dffaa8db2d4990e61df7016b8cd8918c850e5b32 Run "make update-copyright". * src/numfmt.c: Update copyright year number range. This file has obviously been added to coreutils after and without the annual update. * tests/misc/numfmt.pl: Likewise. 2013-02-20T04:04:25Z Joachim Schmitz jojo@schmitz-digital.de 2013-02-19T11:09:44Z urn:sha1:04b035670de49429d48dea726125caa613c1629f * src/numfmt.c (): Use the more standard _GL_ATTRIBUTE_PURE which is elided where required. Reported in http://bugs.gnu.org/10305 2013-02-14T03:24:46Z Pádraig Brady P@draigBrady.com 2013-02-14T02:32:22Z urn:sha1:302564444383169087fbbec36983789abbac9aa5 On linkers that don't remove unused functions, there will be a reference to a missing dev_debug symbol in the devmsg() function. So for now ... * src/system.h: ... move devmsg() from here ... * src/numfmt.c: ... to here, and document future cleanup. * src/factor.c: Likewise. 2013-02-13T22:20:10Z Assaf Gordon assafgordon@gmail.com 2013-02-12T20:28:22Z urn:sha1:fff11aca4faaee33a032cb11d7453c6e938b71b7 src/numfmt.c (parse_format_string): On some systems, strtol() returns EINVAL if no conversion was performed. So only handle ERANGE here, and handle other format errors directly. 2013-02-11T10:24:26Z Pádraig Brady P@draigBrady.com 2013-02-11T09:27:22Z urn:sha1:6c1a3b0a29d353f65ddfd5c65d2adeff62d93fed * src/numfmt.c (usage): Keep a single space between the "K = 1000", so that it's not displayed on a separate line. Also place ',' between each unit entry to improve readability. 2013-02-10T22:00:54Z Benno Schulenberg bensberg@justemail.net 2013-02-10T22:00:48Z urn:sha1:b5f45b640cfec88bc6dce243a7bc07ba3a344ec2 * src/numfmt.c (usage): Correct synopsis and make command description clearer. Start option descriptions with lowercase letter; use semicolon instead of period where needed; indent continuation lines; gettextize single options for ease of translation and maintenance; sort options alphabetically. * doc/coreutils.texi (numfmt invocation): Sort numfmt options alphabetically. Enforce double-blank-after-period style. This addresses http://bugs.gnu.org/13681. Improved-by: Bernhard Voelker 2013-02-10T20:30:53Z Pádraig Brady P@draigBrady.com 2013-02-10T12:47:23Z urn:sha1:3309e880fb2b5d4316809c5ceef4f5b2b8d34a38 Both factor and numfmt recently introduced debug messages for developers, enabled by --verbose and ---devdebug respectively. There were a few issues though: 1. They used different mechanisms to enable these messages. 2. factor used --verbose which might be needed for something else 3. They used different methods to output the messages, and numfmt used error() which added an unwanted newline 4. numfmt marked all these messages for translation and factor marked a couple. We really don't need these translated. So we fix the above issues here while renaming the enabling option for both commands to ---debug (still undocumented). * src/factor.c (verbose): Rename to dev_debug and change from int to bool as it's just a toggle flag. (long_options): Rename --verbose to ---debug. * src/system.h (devmsg): A new inline function to output a message if enabled by a global dev_debug variable in the compilation unit. * src/numfmt.c: Use devmsg() rather than error(). Also remove the translation tags from these messages. Also change debug flag to bool from int. * tests/misc/numfmt.pl: Adjust for the ---devdebug to ---debug change. * cfg.mk (sc_marked_devdiagnostics): Add a syntax check to ensure translations are not added to devmsg calls. Reported by Göran Uddeborg in http://bugs.gnu.org/13665 2013-02-05T16:16:19Z Assaf Gordon assafgordon@gmail.com 2013-02-05T16:04:41Z urn:sha1:6a404ec16555bc0757ff06d99af96c12bfbc235e * src/numfmt.c (usage): Change erroneous "G" to "M". 2013-02-05T15:49:42Z Pádraig Brady P@draigBrady.com 2013-02-05T15:37:47Z urn:sha1:51b3ba842d1196f165e242d77e1d5f092d3b840d Prompted by the continuous integration build failure at: http://hydra.nixos.org/build/4010493 * src/numfmt.c (parse_format_string): Correct both sign and size of a printf format, which only gives a warning on 32 bit builds.