coreutils/src/pinky.c, branch v8.22Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/
https://git.shady.money/coreutils/atom?h=v8.222013-07-11T23:24:13Zmaint: avoid a valgrind memory leak warning from pinky2013-07-11T23:24:13ZPádraig BradyP@draigBrady.com2013-07-10T00:07:57Zurn:sha1:90e0e9bf58fd5c9b6aa86c22c6351d830ed1c6eb
Similarly to commit v8.21-84-g8d2da3f in src/uptime.c
avoid a "definitely lost" error from valgrind. Note this
only happens with pinky when compiled without optimization,
in which case certain paths aren't eliminated casuing
valgrind to trigger the message. Note also that coverity
flags this "resource leak" too.
* src/pinky.c (short_pinky): free utmp_buf for developer builds.
maint: update all copyright year number ranges2013-01-01T03:51:20ZJim Meyeringjim@meyering.net2013-01-01T02:54:51Zurn:sha1:77da73c75432f3c5b4beebae7b0797a1e33160bc
Run "make update-copyright", but then also run this,
perl -pi -e 's/2\d\d\d-//' tests/sample-test
to make that one script use the single most recent year number.
pinky,who: fix bug in latest change2012-07-15T17:11:45ZJim Meyeringmeyering@redhat.com2012-07-15T16:18:03Zurn:sha1:ac00d23e1a90dc5a8cd0f6de0e61eb401d5089d5
* src/system.h (stzncpy): New function.
* src/pinky.c (print_entry): Use stzncpy, not stpncpy.
The latter does not NUL-terminate. I assumed that strncpy was
the only function with such a horrible API. Today I learned that
stpncpy also may not NUL-terminate its result.
The bugs were introduced in commit v8.17-48-gf79263d.
* src/who.c (print_user): Likewise.
Thanks to Erik Auerswald for spotting my error.
maint: remove unwarranted uses of strncpy2012-07-15T11:43:49ZJim Meyeringmeyering@redhat.com2012-07-15T09:38:51Zurn:sha1:f79263da4da048bf3a071e22530a0d2c02aff0df
* src/pinky.c (print_entry): Remove unwarranted uses of strncpy.
Instead, use stpcpy and stpncpy.
* src/who.c (print_user): Likewise.
* cfg.mk: Remove strncpy exemptions.
maint: use single copyright year range2012-01-27T10:35:24ZJim Meyeringmeyering@redhat.com2012-01-27T10:35:24Zurn:sha1:d7878454cd02518959b0d6036db3a5b6ff00ca57
Run "make update-copyright".
maint: quote 'like this' or "like this", not `like this'2012-01-22T23:26:38ZPaul Eggerteggert@cs.ucla.edu2012-01-22T23:26:00Zurn:sha1:80bc8651fd6b0a41be00ab4ee82e920287b15cbc
* doc/coreutils.texi (Formatting the file names):
coreutils now quotes 'like this'.
* man/help2man:
* src/timeout.c (usage): Quote 'like this' in diagnostics.
* HACKING, Makefile.am, NEWS, README, README-hacking, TODO, cfg.mk:
* doc/Makefile.am, doc/coreutils.texi, m4/jm-macros.m4:
* man/Makefile.am, man/help2man, src/Makefile.am, src/copy.h:
* src/extract-magic, src/ls.c, src/pinky.c, src/pr.c, src/sort.c:
* src/split.c, src/timeout.c, src/who.c, tests/dd/skip-seek-past-file:
* tests/pr/pr-tests: Quote 'like this' in commentary.
* cfg.mk (old_NEWS_hash): Update due to changed old NEWS.
maint: src/*.c: change remaining quotes (without embedded spaces)2012-01-09T20:50:08ZJim Meyeringmeyering@redhat.com2012-01-08T14:08:30Zurn:sha1:a517386f1bf8c64ee7617cc2c9d0a16a1d85c8c4
Run this (twice):
git grep -E -l '`[^ ]+'\' src/*.c \
|xargs perl -pi -e 's/`([^ ]+'\'')/'\''$1/'
maint: convert `...' to '...' in --help output2012-01-09T20:50:08ZJim Meyeringmeyering@redhat.com2012-01-08T13:08:03Zurn:sha1:9af0dced5a2eb167ec7b9dfe3f358f214e45d41a
All affected lines end with \ or \n\, so run this command
until it produces no new changes (4 times):
git grep -E -l '`[^ ]+'\''.*\\' src \
|xargs perl -pi -e 's/`([^ ]+'\''.*\\)/'\''$1/'
maint: use new emit_try_help in place of equivalent fprintf2012-01-07T15:54:26ZJim Meyeringmeyering@redhat.com2012-01-07T15:54:26Zurn:sha1:101d1203c667ec3ab54a026dde43117563d4e944
Run this command:
perl -0777 -pi -e \
's/fprintf \(stderr, _\("Try `%s --help.*\n.*;/emit_try_help ();/m'\
src/*.c
maint: update all copyright year number ranges2012-01-01T09:04:06ZJim Meyeringmeyering@redhat.com2012-01-01T08:47:10Zurn:sha1:5111aa42968262bd4d44eeca277b194020bb5007
Run "make update-copyright".