coreutils/src/pr.c, branch v8.7Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/
https://git.shady.money/coreutils/atom?h=v8.72010-07-22T00:04:47Zprovide POSIX_FADV_SEQUENTIAL hint to appropriate utils2010-07-22T00:04:47ZPádraig BradyP@draigBrady.com2010-07-20T17:51:01Zurn:sha1:47076e3c7c22fc7557f388ad3d47228b922da71e
Following on from commit dae35bac, 01-03-2010,
"sort: inform the system about our input access pattern"
apply the same hint to all appropriate utils.
This currently gives around a 5% speedup for reading
large files from fast flash devices on GNU/Linux.
* src/base64.c: Call fadvise (..., FADVISE_SEQUENTIAL);
* src/cat.c: Likewise.
* src/cksum.c: Likewise.
* src/comm.c: Likewise.
* src/cut.c: Likewise.
* src/expand.c: Likewise.
* src/fmt.c: Likewise.
* src/fold.c: Likewise.
* src/join.c: Likewise.
* src/md5sum.c: Likewise.
* src/nl.c: Likewise.
* src/paste.c: Likewise.
* src/pr.c: Likewise.
* src/ptx.c: Likewise.
* src/shuf.c: Likewise.
* src/sum.c: Likewise.
* src/tee.c: Likewise.
* src/tr.c: Likewise.
* src/tsort.c: Likewise.
* src/unexpand.c: Likewise.
* src/uniq.c: Likewise.
* src/wc.c: Likewise, unless we don't actually read().
maint: make spacing around "=" consistent, even in IF_LINT2010-05-31T09:02:21ZJim Meyeringmeyering@redhat.com2010-05-15T17:36:56Zurn:sha1:c0cfa0defe06fa750530f08d6e0a54521f83292d
E.g.,
- size_t desired_width IF_LINT (= 0);
+ size_t desired_width IF_LINT ( = 0);
Use this command:
g grep -l IF_LINT | grep '\.[ch]$' \
| xargs perl -pi -e 's/(IF_LINT \()= /$1 = /'
maint: replace each "for (;;)" with "while (true)"2010-05-31T09:02:21ZJim Meyeringmeyering@redhat.com2010-05-01T12:24:35Zurn:sha1:da7a704cd36e1d2015d14247e5139fb1999b2211
Run this command:
git ls-files | grep '\.[ch]$' \
| xargs perl -pi -e 's/for \(;;\)/while (true)/g'
...except for randint.c, which does not include stdbool.h.
In that case, use "while (1)".
* gl/lib/randint.c (randint_genmax): Use "while (1)" for infloops.
* src/cat.c (simple_cat, cat): Use "while (true)" for infloops.
* gl/lib/randread.c (readsource, readisaac): Likewise.
* src/copy.c (copy_reg): Likewise.
* src/csplit.c (record_line_starts, process_regexp): Likewise.
* src/cut.c (set_fields): Likewise.
* src/dd.c (iread, parse_symbols): Likewise.
* src/df.c (find_mount_point, main): Likewise.
* src/du.c (main): Likewise.
* src/expand.c (expand): Likewise.
* src/factor.c (factor_using_division, do_stdin): Likewise.
* src/fmt.c (get_space): Likewise.
* src/ls.c (decode_switches): Likewise.
* src/od.c (main): Likewise.
* src/pr.c (main, read_line): Likewise.
* src/shred.c (dopass, genpattern): Likewise.
* src/sort.c (initbuf, fillbuf, getmonth, keycompare): Likewise.
* src/split.c (bytes_split, lines_split): Likewise.
* src/tac.c (tac_seekable): Likewise.
* src/test.c (and, or): Likewise.
* src/tr.c (squeeze_filter, main): Likewise.
* src/tsort.c (search_item): Likewise.
* src/unexpand.c (unexpand): Likewise.
* src/uniq.c (main): Likewise.
* src/yes.c (main): Likewise.
doc: remove extraneous periods from --help output2010-02-11T08:01:15ZPádraig BradyP@draigBrady.com2010-02-10T17:05:34Zurn:sha1:45b46f4951758e6d3564537bbc8535cf76e9114a
* src/join.c (usage): Mention "fields" rather than repeating "line"
so that it's more obvious that the fields are still parsed, and
thus -o is still honored for headers. Also remove an extraneous
'.' reported by Stéphane Raimbault.
* src/base64.c (usage): Remove extraneous blank line and order
the options alphabetically. Also remove an extraneous '.'
* src/chown.c (usage): Remove extraneous '.'
* src/cp.c (usage): Likewise.
* src/mktemp.c (usage): Likewise.
* src/pr.c (usage): Likewise.
* src/stat.c (usage): Likewise.
* src/uniq.c (usage): Likewise.
pr: avoid two over-allocations2010-01-18T11:03:06ZJim Meyeringmeyering@redhat.com2010-01-18T06:53:44Zurn:sha1:cd349fdca2f3368d1c2441a432dda2f064e4c455
* src/pr.c (init_store_cols): Allocate N*sizeof(*VAR) bytes,
not N*sizeof(int*). The latter would mistakenly allocate double
the required space on a system with 8-byte pointers.
pr: ensure the page header line is of the required format2010-01-07T04:07:23ZEric Blakeebb9@byu.net2010-01-07T03:57:40Zurn:sha1:67d3e263504115144380dfaffd41c9cef3cf68a4
Before this change, with too long a file name, the name would
abut the date field on the left and possibly also the "Page N"
field on the right, rather than leaving a one-space separator
in each case. Fixes a regression introduced on Mar 6 2009,
by commit a4053c5291d5797734b3e4f042f9e1adf3944fd6
* src/pr.c (print_header): Ensure that there is at least one
space before and after the file name part of the header line.
* NEWS: Mention it.
* tests/pr/W20l24f-ll: s/xPage/ x Page/.
* THANKS: Update.
Reported by Denis McKeon, in https://savannah.gnu.org/bugs/?28492.
maint: update all FSF copyright year lists to include 20102010-01-01T13:06:47ZJim Meyeringmeyering@redhat.com2010-01-01T09:56:28Zurn:sha1:1aa17dc89b3f313697661541adca0aa0defbdc09
Use this command:
git ls-files | grep -v COPYING \
| xargs env UPDATE_COPYRIGHT_USE_INTERVALS=1 \
build-aux/update-copyright
pr --help: add missing space between short and long options usage message2010-01-01T13:06:47ZStéphane Raimbaultstephane.raimbault@makina-corpus.com2009-12-31T15:52:25Zurn:sha1:6c8d432b1f70c80213b0a2244e2427ae3c1394ef
* src/pr.c (usage): Add missing space.
pr --help: improve a line-break2010-01-01T13:06:47ZStéphane Raimbaultstephane.raimbault@makina-corpus.com2009-12-31T15:52:34Zurn:sha1:f1ab2e02270bcd42444186b6f8e75971ce55736f
* src/pr.c (usage): Move the newline character a bit farther.
maint: Use logical rather than bitwise operators on bools2009-09-23T13:33:40ZPádraig BradyP@draigBrady.com2009-09-23T09:10:51Zurn:sha1:a037e838e15c9a698f1634398e0fe2726398d575
This is because bitwise operators are:
- confusing and inconsistent in a boolean context
- non short circuiting
- brittle in C89 where bool can be an int (so > 1)