coreutils/src/ptx.c, branch v8.26Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/
https://git.shady.money/coreutils/atom?h=v8.262016-11-24T16:21:59Zptx: fix an invalid heap reference with short --width2016-11-24T16:21:59ZPádraig BradyP@draigBrady.com2016-11-24T15:56:01Zurn:sha1:ca99c524e828cc1a1cfeff3cdfc5349f87143829
* src/ptx.c (fix_output_parameters): Ensure line_width doesn't
go negative, which can happen when the --width is less
than the --gap-size.
* tests/misc/ptx-overrun.sh: Add a test case that triggers
with ASAN. (Note the longer filename is needed to trigger).
Fixes http://bugs.gnu.org/25011
all: use die() rather than error(EXIT_FAILURE)2016-10-16T11:23:55ZPádraig BradyP@draigBrady.com2016-10-15T22:10:35Zurn:sha1:492dcb2eb191b844a2fd5e51db3eed85289bea1f
die() has the advantage of being apparent to the compiler
that it doesn't return, which will avoid warnings in some cases,
and possibly generate better code.
* cfg.mk (sc_die_EXIT_FAILURE): A new syntax check rule to
catch any new uses of error (CONSTANT, ...);
ptx: avoid new warning/error from upcoming gcc-7.x2016-08-29T15:37:08ZJim Meyeringmeyering@fb.com2016-08-29T05:53:50Zurn:sha1:d591776d81c547ef9a24b95fc88698593d81d5e7
* src/ptx.c (fix_output_parameters): Switch to an unsigned type that
matches the OCCURS.file_index type. This avoids the following error
from gcc-7.0.0 20160829 (experimental):
src/ptx.c:1220:14: error: assuming signed overflow does not occur \
when simplifying conditional to constant [-Werror=strict-overflow]
if (file_index > 0)
maint: update all copyright year number ranges2016-01-01T14:10:41ZPádraig BradyP@draigBrady.com2016-01-01T14:10:41Zurn:sha1:b16e999f553b682e74e0a56750f649da05130c4f
Run "make update-copyright" and then...
* gnulib: Update to latest with copyright year adjusted.
* tests/init.sh: Sync with gnulib to pick up copyright year.
* bootstrap: Likewise.
* tests/sample-test: Adjust to use the single most recent year.
maint: remove form feed characters from sources2015-12-14T02:35:10ZPádraig BradyP@draigBrady.com2015-12-13T20:16:59Zurn:sha1:5f87f1ac1cb2ef44aac4284d8103e7556597a842
These are no longer useful and can impact viewing
patches in some mail programs for example.
* src/cksum.c: Remove ^L characters.
* src/comm.c: Likewise.
* src/kill.c Likewise.
* src/ln.c Likewise.
* src/nl.c Likewise.
* src/pr.c Likewise.
* src/ptx.c Likewise.
* src/split.c Likewise.
* src/tr.c Likewise.
* src/tsort.c Likewise.
* src/uniq.c Likewise.
* src/wc.c Likewise.
* cfg.mk (sc_prohibit-form-feed): A new syntax check.
all: avoid quoting file names when possible2015-11-04T23:30:14ZPádraig BradyP@draigBrady.com2015-11-01T18:53:26Zurn:sha1:08e8fd7e38f2dae7c69c54eb22d508b6517e66e5
Quote file names using the "shell-escape" or "shell-escape-always"
methods, which quote as appropriate for most shells,
and better support copy and paste of presented names.
The "always" variant is used when the file name is
embedded in an error message with surrounding spaces.
* cfg.mk (sc_error_shell_quotes): A new syntax check rule
to suggest quotef() where appropriate.
(sc_error_shell_always_quotes): Likewise for quoteaf().
* src/system.h (quotef): A new define to apply shell quoting
when needed. I.E. when shell character or ':' is present.
(quoteaf): Likewise, but always quote.
* src/*.c: Use quotef() and quoteaf() rather than quote()
where appropriate.
* tests/: Adjust accordingly.
all: quote string arguments in error messages2015-10-27T17:24:54ZPádraig BradyP@draigBrady.com2015-10-27T13:13:59Zurn:sha1:6796698c9945d87236ffcc939137d0919ef04931
These strings are often file names or other user specified
parameters, which can give confusing errors in
the presence of unexpected characters for example.
* cfg.mk (sc_error_quotes): A new syntax check rule.
* src/*.c: Wrap error() string arguments with quote().
* tests/: Adjust accordingly.
* NEWS: Mention the improvement.
ls,ptx: restrict quotearg use to file name output2015-09-03T00:11:32ZPádraig BradyP@draigBrady.com2015-08-16T15:47:17Zurn:sha1:895a56c53118ea1ed97e0641a413ca4793afaa20
* src/ls.c (getenv_quoting_style, decode_switches, parse_ls_color):
Use quote() rather than quotearg(), as the latter defaults to
outputting the input unquoted.
* src/ptx.c (main): Likewise.
maint: avoid undefined behavior in qsort call2015-06-24T18:15:31ZPádraig BradyP@draigBrady.com2015-06-24T18:14:47Zurn:sha1:77547ba7b26aa65fc0f6dfcc0cb8235686699611
GCC 5.1.1 -fsanitize=undefined with glibc 2.21 is returning:
"runtime error: null pointer passed as argument 1,
which is declared to never be null"
* src/ptx.c (sort_found_occurs): Avoid the call with no entries.
doc: standardize messages about the '-' stdin FILE2015-04-30T17:25:01ZPádraig BradyP@draigBrady.com2015-04-30T13:02:46Zurn:sha1:e981643ae3e57affdf3f4f6aa8bf53cf06433f17
* src/system.h (emit_stdin_note): A new function, refactoring
the usage note about the '-' FILE implying stdin.
* src/base64.c (usage): Use the new function to emit the
note in a standard location and with standard separation.
* src/cat.c (usage): Likewise.
* src/csplit.c (usage): Likewise.
* src/cut.c (usage): Likewise.
* src/expand.c (usage): Likewise.
* src/fmt.c (usage): Likewise.
* src/head.c (usage): Likewise.
* src/md5sum.c (usage): Likewise.
* src/nl.c (usage): Likewise.
* src/od.c (usage): Likewise.
* src/paste.c (usage): Likewise.
* src/pr.c (usage): Likewise.
* src/ptx.c (usage): Likewise.
* src/shred.c (usage): Likewise.
* src/shuf.c (usage): Likewise.
* src/sort.c (usage): Likewise.
* src/sum.c (usage): Likewise.
* src/tac.c (usage): Likewise.
* src/tail.c (usage): Likewise.
* src/tsort.c (usage): Likewise.
* src/unexpand.c (usage): Likewise.
* src/wc.c (usage): Likewise.
* src/join.c (usage): Adjust the separation used for
the message referring to FILE1 or FILE2 as stdin.
* src/comm.c (usage): Add a message using the same
wording (translation) as used in join.
* src/split.c (usage): Reword to using FILE rather than
INPUT, allowing use of emit_stdin_note(). Also remove
the mention of "fixed-size" pieces as this isn't now
always the case.
Fixes http://pad.lv/1450179