coreutils/src/remove.c, branch v6.2

* src/remove.c (remove_dir): Move new cache_stat_init call onto

2006-09-11T13:22:04Z

it's own line. (rm_1): Move declaration of "st" and new cache_stat_init call "down" to nearer where they're used.

Don't include dirname.h, since system.h does it now.

2006-09-03T02:54:51Z

(cache_fstatat, cache_stat_init): New functions. (cache_statted, cache_stat_ok): New functions. (write_protected_non_symlink): Remove struct stat ** buf_p arg, which is no longer needed with the new functions. All callers changed. (prompt, is_dir_lstat, remove_entry, remove_dir): New struct stat * arg. All callers changed. (write_protected_non_symlink, prompt, is_dir_lstat, remove_entry): (remove_cwd_entries, remove_dir, rm_1): Use and maintain the file status cache. (prompt, remove_entry): Omit the first "directory" in the diagnostic "Cannot remove directory `foo': is a directory". This causes "rm" to pass a test case that it would otherwise fail now that it "knows" more about its argument. I think the diagnostic is better without the first "directory" anyway. (prompt): Remove the no-longer-needed IS_DIR arg; all callers changed. (rm_1): Reject attempts to remove /, ./, or ../.

* src/system.h (DOT_OR_DOTDOT): Remove macro. Rewrite as a...

2006-08-27T19:34:28Z

(dot_or_dotdot): ...new static inline function. * src/remove.c (rm_1): Reflect this renaming. * src/ls.c (basename_is_dot_or_dotdot): Likewise.

Plug another unusual leak.

2006-07-03T17:38:20Z

(AD_mark_helper): Free malloc'd filename if hash_insert says that string is already in the hash table.

The dev/inode of the topmost directory in each hierarchy were not

2006-07-03T15:10:35Z

being recorded. * src/remove.c (remove_cwd_entries): Don't call cycle_check here. (AD_push): Call it from here instead.

Fix two small leaks.

2006-07-03T13:14:01Z

* src/remove.c (AD_stack_clear): New function. (rm_1): Use it. (AD_pop_and_chdir): Free *prev_dir just before longjmp.

* src/system.h (CLOSEDIR): Remove. All uses changed to closedir.

2006-06-28T22:21:48Z

Attempt rmdir (actually, unlinkat-with-AT_REMOVEDIR) upon any

2006-06-26T13:29:48Z

fd_to_subdirp failure, not just when errno == EACCES. * src/remove.c (remove_dir): Use unlinkat-with-AT_REMOVEDIR, not rmdir, here, even though rmdir may happen to be adequate.

* NEWS: rm no longer fails to remove an empty, unreadable directory

2006-06-26T13:02:01Z

* src/remove.c (remove_cwd_entries): If we can't open a directory, and the failure is not being ignored, try to remove the directory with rmdir (aka unlinkat-with-AT_REMOVEDIR), in case it's empty. Problem report and test case from Paul Eggert in . * tests/rm/empty-inacc: New test, for the above.

tweak grammar in comment

2006-06-25T19:27:19Z