coreutils/src/remove.c, branch v6.8

Make "rm --interactive=never ..." never prompt.

2007-01-17T16:15:20Z

* NEWS: Mention this. * src/remove.h (enum rm_interactive): New ternary type. (struct rm_options) [interactive]: Use it, here -- rather than bool. * src/remove.c (prompt): Reflect type change. * src/mv.c (rm_option_init): Initialize to RMI_NEVER now. * src/rm.c (main): Add a FIXME comment for '-d' option. Adapt to type change of rm_options.interactive. * tests/rm/i-never: New file. Test for the above fix. * tests/rm/Makefile.am (TESTS): Add i-never.

* src/remove.c (remove_dir): Don't use errno in diagnostic.

2007-01-15T09:39:32Z

Root-only test failure reported by Alex van Hout and Jon Grosshart in .

Clean up after the change of 2006-12-28.

2006-12-30T15:12:23Z

* src/remove.c (AD_pop_and_chdir): Change **DIRP parameter to *DIRP, now that this function never modifies the pointer. Adjust comments and code accordingly. (remove_dir): Set "dirp" to NULL right after AD_pop_and_chdir call, now that AD_pop_and_chdir no longer does that.

When moving "up" the hierarchy, be careful to remove a just-emptied

2006-12-28T18:37:07Z

directory before opening ".", to avoid trouble with file system implementations that cache readdir results at opendir-time. * src/remove.c (AD_pop_and_chdir): Add a file descriptor parameter. Don't update **DIRP. Don't call fdopendir here. (remove_dir): Call fdopendir here instead. Report and patch from Mikulas Patocka:

"rm -rf /etc/motd" (run by non-root) now prints a diagnostic.

2006-12-21T07:58:11Z

* src/remove.c (remove_entry): Handle EACCES for a non-directory, too. Karl Berry reported that a cross-partition "mv /etc/issue ~" failed with the um,... suboptimal diagnostic, "mv: cannot remove `/etc/issue': Not a directory". * tests/rm/Makefile.am (TESTS): Add fail-eacces. * tests/rm/fail-eacces: New file. * NEWS: Mention that both mv and rm are affected.

* src/remove.c (fd_to_subdirp): Remove unused parameter, ds.

2006-11-26T17:47:54Z

Update callers.

Port parts of the code to C89 to minimize the need for c99-to-c89.diff,

2006-11-26T16:40:38Z

while trying to retain the readability of C99 as much as possible. * src/remove.c (close_preserve_errno): Remove. (fd_to_subdirp): Rewrite to avoid the need for decl after statement. Signed-off-by: Paul Eggert

* src/remove.c (rm): Move cycle_check_init call into callee...

2006-11-26T16:40:37Z

Use an else clause in place of a "continue" statement. Signed-off-by: Paul Eggert

* src/remove.c (AD_ensure_initialized): New function.

2006-11-26T16:40:16Z

after statement. Signed-off-by: Paul Eggert

* src/remove.c (AD_pop_and_chdir): Return prev_dir rather than storing through

2006-11-26T16:39:53Z

a pointer argument. All uses changed. Signed-off-by: Paul Eggert