coreutils/src/shred.c, branch v6.7

Improve the check for departures from C89, and fix the departures

2006-11-27T10:27:46Z

I found. * Makefile.maint (my-distcheck): Also check for C89 compatibility as best we can with GCC. * src/stat.c (PRINTF_OPTION): Omit comma before } in enum declaration; C89 doesn't allow this. * src/dcgen: Don't generate string literals longer than what C89 requires support for. * src/cut.c (usage): Don't use string literals longer than what C89 requires support for. * src/date.c (usage): Likewise. * src/dd.c (usage): Likewise. * src/du.c (usage): Likewise. * src/ls.c (usage): Likewise. * src/od.c (usage): Likewise. * src/readlink.c (usage): Likewise. * src/seq.c (usage): Likewise. * src/shred.c (usage): Likewise.

* src/ls.c (quote_name): Use initializer rather than memset to

2006-10-10T22:57:07Z

initialize an object to zero. This is easier to read and is less likely to introduce an runtime error due to a mixup. It causes gcc -W to issue a warning, but you can work around this by appending -Wno-missing-field-initializers. * src/pathchk.c (portable_chars_only): Likewise. * src/shred.c (main): Likewise. * src/stty.c (main): Likewise. * src/tr.c (card_of_complement): Likewise. * src/wc.c (wc): Likewise.

Don't include dirname.h, since system.h does it now.

2006-09-03T02:53:16Z

Include unconditionally, since we now assume config.h exists.

2006-08-26T06:55:57Z

Fix typo in previous checkin; a "&" went missing.

2006-08-25T23:12:01Z

Rewrite to avoid some unnecessary casts, macros, literals.

2006-08-25T23:08:58Z

(DEFAULT_PASSES, VERBOSE_UPDATE): Now constants, not macros. (SECTOR_SIZE, SECTOR_MASK): New constants. (fillpattern, dopass, do_wipefd, main): Remove unnecessary casts, and use the SECTOR_* constants when applicable. Check for size < 0 rather than size == -1, since negative-size files are a sign of trouble anyway. (dopass): Assume a continuable error if EIO even if the current position is not a multiple of 512.

* src/shred.c (usage): Don't indent the second line of an item.

2006-08-13T21:21:52Z

Otherwise, help2man would misformat the output. Reported by Adam Buchbinder in .

Use new random-number interface rather than rand-isaac.c.

2006-08-08T22:19:39Z

Don't include rand-isaac.c; include randint.h and randread.h instead. (RANDOM_SOURCE_OPTION): New enum. (long_opts, usage, main): New option --random-source. (struct irand_state, irand_init, irand32, irand_mod): Remove. All callers changed to use randint interface. (fillrand): Remove. All callers changed to use randread interface. (dopass): Remove dependency on ISAAC buffer size. (genpattern): Don't wipe the random state here. (randint_source): New static var. (clear_random_data): New function. (main): Allocate random source, and arrange to wipe it on exit.

(fillrand): The assertion was way too weak, due to

2006-04-19T06:27:43Z

what must be a typo. Strengthen it to its intended value. (dopass): Don't use alloca; it's not worth the aggravation here, since it's used only to get a page-aligned buffer, and page alignment doesn't buy us much here. I'm suspicious that alloca causes problems on some hosts, due to a recent bug report by Adam Waltman.

(wipename): Use new last_component, in place of base_name.

2006-03-26T12:07:59Z