coreutils/src/sort.c, branch v8.18

sort: by default, do not exceed 3/4 of physical memory

2012-07-10T23:16:33Z

* src/sort.c (default_sort_size): Do not exceed 3/4 of total memory. See Jeff Janes's bug report in .

sort: fix exit-status typo

2012-07-02T23:46:59Z

* src/sort.c (stream_open): EXIT_FAILURE -> SORT_FAILURE. Suggested by Pádraig Brady in .

sort: simplify -o handling to avoid fdopen, assert

2012-07-02T23:46:59Z

* src/sort.c (outfd): Remove. All uses replaced by STDOUT_FILENO. (stream_open): When writing, use stdout rather than fdopen. (move_fd_or_die): Renamed from dup2_or_die, with the added functionality of closing its first argument. All uses changed. (avoid_trashing_input): Special case for !outfile no longer needed. (check_output): Arrange for standard output to go to the file, rather than storing the fd in outfd.

sort: avoid redundant processing with inaccessible inputs or output

2012-07-02T19:14:29Z

* src/sort.c (check_inputs): A new function to verify all inputs are accessible before further processing. (check_output): A new function to open or create a specified output file, before futher processing. (stream_open): Adjust to truncating the previously opened output file rather than opening directly. (avoid_trashing_input): Optimize to stat the output file descriptor, rather than the file name. (main): Call the new functions to check accessibility of inputs and output, before processing starts. * tests/misc/sort: Adjust to the changed error message. * tests/misc/sort-merge-fdlimit: Account for the earlier opened file descriptor of the specified output file. * tests/misc/sort-exit-early: A new test to exercise the improvements. * tests/Makefile.am: Reference the new test. * NEWS: Mention the improvement. Suggested-by: Bernhard Voelker

maint: sort: style adjustment to help clarify size determination

2012-06-20T06:12:17Z

* src/sort.c (default_sort_size): Move physmem code "down" to first use.

maint: add assertions to placate static analysis tools

2012-05-16T05:36:26Z

A static analysis tool (http://labs.oracle.com/projects/parfait/) produced some false positive diagnostics. Add assertions to help it understand that the code is correct. * src/stty.c: Include . (display_changed): Add an assertion to placate parfait. (display_all): Likewise. * src/sort.c: Include . (main): Add an assertion to placate parfait. * src/fmt.c: Include . (get_paragraph): Add an assertion to placate parfait.

maint: rely on gnulib's new sys_resource module

2012-05-04T10:13:26Z

* bootstrap.conf (gnulib_modules): Add sys_resource. * src/sort.c: Remove #if HAVE_SYS_RESOURCE_H guard around inclusion of and move the inclusion "up" into the alphabetized list of its peers. This also avoids a failure of the sc_prohibit_always_true_header_tests syntax-check rule. * m4/jm-macros.m4 (gl_CHECK_ALL_HEADERS): Remove sys/resource.h.

sort: default to physmem/8, not physmem/16

2012-02-25T18:34:57Z

* src/sort.c (default_sort_size): Don't divide advice by 2. Just divide the hard limits by 2. This matches the comments. Reported by Rogier Wolff in http://bugs.gnu.org/10877

maint: sort: remove the last uses of "'%s'" in diagnostics

2012-01-30T19:43:58Z

* src/sort.c (key_warnings): Use quote (quote_n, since there are two) rather than literal single quotes ('%s') in diagnostic.

maint: use single copyright year range

2012-01-27T10:35:24Z