coreutils/src/sort.c, branch v8.26Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/
https://git.shady.money/coreutils/atom?h=v8.262016-10-16T18:28:39Zmaint: we use die; remove now-unnecessary uses of abort2016-10-16T18:28:39ZJim Meyeringmeyering@fb.com2016-10-16T18:28:39Zurn:sha1:f8b8bbc1b97c9cb7a56aae79451bf87ab7307cd2
* src/expr.c (integer_overflow): Remove an abort-after-die.
* src/paste.c (write_error): Likewise.
* src/sort.c (badfieldspec): Likewise.
* src/tr.c (string2_extend): Likewise. Also remove a few
break statements, each after an abort.
all: use die() rather than error(EXIT_FAILURE)2016-10-16T11:23:55ZPádraig BradyP@draigBrady.com2016-10-15T22:10:35Zurn:sha1:492dcb2eb191b844a2fd5e51db3eed85289bea1f
die() has the advantage of being apparent to the compiler
that it doesn't return, which will avoid warnings in some cases,
and possibly generate better code.
* cfg.mk (sc_die_EXIT_FAILURE): A new syntax check rule to
catch any new uses of error (CONSTANT, ...);
sort: port to strict C + valgrind2016-09-08T02:51:12ZPaul Eggerteggert@cs.ucla.edu2016-09-08T02:49:55Zurn:sha1:d47090d964d31bb4af9872525275372efd3bfdce
* bootstrap.conf (gnulib_modules): Add flexmember.
* src/sort.c: Include flexmember.h.
(struct tempnode): Make the last member flexible.
(create_temp_file): Port to strict C11/C99 rules for
allocation alignment with flexible array members.
sort: with -h, disallow thousands separator between number and unit2016-07-18T21:24:26ZKamil Dudkakdudka@redhat.com2016-07-18T17:04:45Zurn:sha1:0f9fc7b3b9aee1d001ca60de1125e6e714e70ac7
* src/sort.c (traverse_raw_number): Accept thousands separator only
if it is immediately followed by a digit.
* tests/misc/sort-h-thousands-sep.sh: Cover the fix for this bug.
Suggested by Pádraig Brady in http://bugs.gnu.org/24015
sort: make -h work with -k and blank used as thousands separator2016-07-18T21:12:32ZKamil Dudkakdudka@redhat.com2016-07-18T17:04:44Zurn:sha1:dfbc945a562f870f6647672374c00d4f1ffb6097
* src/sort.c (traverse_raw_number): Allow to skip only one occurrence
of thousands_sep to avoid finding the unit in the next column in case
thousands_sep matches as blank and is used as column delimiter.
* tests/misc/sort-h-thousands-sep.sh: Add regression test for this bug.
* tests/local.mk: Reference the test.
* NEWS: Mention the bug fix.
Reported at https://bugzilla.redhat.com/1355780
Fixes http://bugs.gnu.org/24015
maint: sort.c: deduplicate code for traversing numbers2016-07-18T21:09:07ZKamil Dudkakdudka@redhat.com2016-07-18T17:04:43Zurn:sha1:5cc804337b06d46a2fe34f018e26e8bb8148b117
* src/sort.c (traverse_raw_number): New function for traversing numbers.
(find_unit_order): Use traverse_raw_number() instead of open-coding it.
(debug_key): Likewise.
sort: modify 'leading spaces' debug warning scenarios2016-06-01T01:29:52ZAssaf Gordonassafgordon@gmail.com2016-06-01T00:19:38Zurn:sha1:6223bf94bfeac75fb4252095864a80545ba00a0d
Print warning regardless of locale, avoid warning if key is zero width.
Problem reported by Karl Berry in http://bugs.gnu.org/23665 .
* src/sort.c: (key_warnings): change conditions for 'leading spaces'
warning.
* tests/misc/sort-debug-warn.sh: adjust tests accordingly.
all: be less strict about usage if POSIX 20082016-02-23T09:05:10ZPaul Eggerteggert@cs.ucla.edu2016-02-23T09:03:55Zurn:sha1:a7f5d3d6d671bb4e9117b1f72971a19eed135fed
sort, tail, and uniq now support traditional usage like 'sort +2'
and 'tail +10' on systems conforming to POSIX 1003.1-2008 and later.
* NEWS: Document this.
* doc/coreutils.texi (Standards conformance, tail invocation)
(sort invocation, uniq invocation, touch invocation):
Document new behavior, or behavior's dependence on POSIX 1003.1-2001.
* src/sort.c (struct keyfield.traditional_used):
Rename from obsolete_used, since implementations are now allowed
to support it. All uses changed.
(main): Allow traditional usage if _POSIX2_VERSION is 200809.
* src/tail.c (parse_obsolete_option): Distinguish between
traditional usage (which POSIX 2008 and later allows) and obsolete
(which it still does not).
* src/uniq.c (strict_posix2): New function.
(main): Allow traditional usage if _POSIX2_VERSION is 200809.
* tests/misc/tail.pl: Test for new behavior.
sort: with --debug, flag setlocale() failures on OpenBSD2016-01-14T01:26:00ZPádraig BradyP@draigBrady.com2016-01-14T01:17:57Zurn:sha1:611e7e02bff8898e622d6ad582a92f2de746b614
Locale categories are not equivalent on OpenBSD,
and LC_COLLATE only supports "C" for example.
Now LC_ALL is supported to set multiple other categories
on OpenBSD, so setlocale(LC_ALL, "") returns a string
indicating which categories were updated and which ignored.
Therefore...
* src/sort.c (main): ...Call setlocale(LC_COLLATE, "")
to explicitly check whether a specified LC_ALL or
LC_COLLATE environment variable value is supported
for the LC_COLLATE category. Also use !! to explicitly
convert to bool to support c89 systems where bool is an int,
and thus would get values > 1.
Reported by Assaf Gordon.
join,sort,uniq: with -z, treat '\n' as a field separator2016-01-13T10:59:18ZPádraig BradyP@draigBrady.com2016-01-12T16:29:32Zurn:sha1:b2eadd109c3a508011705761dfe24a35180d925d
* NEWS: Mention the change in behavior.
* doc/coreutils.texi (newlineFieldSeparator): A new description,
referenced from ({join,sort,uniq} invocation).
* src/system.h (field_sep): A new inline function to determine
if a character is a field separator.
* src/join.c (usage): s/whitespace/blank/ to be more accurate
wrt which characters are field separators.
(xfields): s/isblank/field_sep/.
* src/sort.c (inittables): Likewise.
* src/uniq.c (find_field): Likewise.
* tests/misc/join.pl: Adjust -z test, and add a test/example
for processing the whole record with field processing.
* tests/misc/sort.pl: Add -z test cases, including case with '\n'.
* tests/misc/uniq.pl: Add -z -f test case with \n.