coreutils/src/tac.c, branch v8.7Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/
https://git.shady.money/coreutils/atom?h=v8.72010-09-01T15:17:31Ztac: suppress technically unneeded "free"2010-09-01T15:17:31ZJim Meyeringmeyering@redhat.com2010-08-28T19:54:17Zurn:sha1:fc9d948d7e6ff916b3ddb3ed371a6f8aa7f2c624
* src/tac.c (main): Guard final free with #ifdef lint.
Suggested by Paul Eggert.
tac: avoid double free2010-08-28T17:28:20ZJim Meyeringmeyering@redhat.com2010-08-28T15:45:29Zurn:sha1:777024889c0043004962834f4d9353cfa6847dd6
* src/tac.c (main): Reading a line longer than 16KiB would cause
tac to realloc its primary buffer. Then, just before exit, tac
would mistakenly free the original (now free'd) buffer.
This bug was introduced by commit be6c13e7, "maint: always free a
buffer, to avoid even semblance of a leak".
* NEWS (Bug fixes): Mention it.
* tests/misc/tac (double-free): New test, to exercise this.
Reported by Salvo Tomaselli in <http://bugs.debian.org/594666>.
maint: replace each "for (;;)" with "while (true)"2010-05-31T09:02:21ZJim Meyeringmeyering@redhat.com2010-05-01T12:24:35Zurn:sha1:da7a704cd36e1d2015d14247e5139fb1999b2211
Run this command:
git ls-files | grep '\.[ch]$' \
| xargs perl -pi -e 's/for \(;;\)/while (true)/g'
...except for randint.c, which does not include stdbool.h.
In that case, use "while (1)".
* gl/lib/randint.c (randint_genmax): Use "while (1)" for infloops.
* src/cat.c (simple_cat, cat): Use "while (true)" for infloops.
* gl/lib/randread.c (readsource, readisaac): Likewise.
* src/copy.c (copy_reg): Likewise.
* src/csplit.c (record_line_starts, process_regexp): Likewise.
* src/cut.c (set_fields): Likewise.
* src/dd.c (iread, parse_symbols): Likewise.
* src/df.c (find_mount_point, main): Likewise.
* src/du.c (main): Likewise.
* src/expand.c (expand): Likewise.
* src/factor.c (factor_using_division, do_stdin): Likewise.
* src/fmt.c (get_space): Likewise.
* src/ls.c (decode_switches): Likewise.
* src/od.c (main): Likewise.
* src/pr.c (main, read_line): Likewise.
* src/shred.c (dopass, genpattern): Likewise.
* src/sort.c (initbuf, fillbuf, getmonth, keycompare): Likewise.
* src/split.c (bytes_split, lines_split): Likewise.
* src/tac.c (tac_seekable): Likewise.
* src/test.c (and, or): Likewise.
* src/tr.c (squeeze_filter, main): Likewise.
* src/tsort.c (search_item): Likewise.
* src/unexpand.c (unexpand): Likewise.
* src/uniq.c (main): Likewise.
* src/yes.c (main): Likewise.
maint: always free a buffer, to avoid even semblance of a leak2010-01-05T08:08:03ZJim Meyeringmeyering@redhat.com2010-01-04T15:49:30Zurn:sha1:be6c13e7e0abc46121c4250c82019179fd5e85c2
* src/tac.c (main): Free the input buffer in most cases.
maint: update all FSF copyright year lists to include 20102010-01-01T13:06:47ZJim Meyeringmeyering@redhat.com2010-01-01T09:56:28Zurn:sha1:1aa17dc89b3f313697661541adca0aa0defbdc09
Use this command:
git ls-files | grep -v COPYING \
| xargs env UPDATE_COPYRIGHT_USE_INTERVALS=1 \
build-aux/update-copyright
doc: mention the texinfo documentation in --help2009-09-21T11:37:57ZPádraig BradyP@draigBrady.com2009-09-18T22:06:21Zurn:sha1:5d4f09d83a7c69110b4db97443759e9046c149e1
* src/system.h: Rename emit_bug_reporting_address() to
emit_ancillary_info() and update it to not print the translation
project address in en_* locales, and _do_ print it in the 'C'
(and other) locales so that it's included in the default man page.
Also mention how to invoke the texinfo documentation for each command.
Also move the "hard-locale.h" include to the 8 files that now use it.
* man/help2man: Strip the newly added texinfo reference from the
--help output as a more verbose version is already added by help2man.
Suggestion from C de-Avillez
global: convert indentation-TABs to spaces2009-08-25T07:21:00ZJim Meyeringmeyering@redhat.com2009-08-22T16:56:06Zurn:sha1:5e778f7c8d1ecf3d8f11385db013af2ba026e2a5
Transformed via this shell code:
t=$'\t'
git ls-files \
| grep -vE '(^|/)((GNU)?[Mm]akefile|ChangeLog)|\.(am|mk)$' \
| grep -vE 'tests/pr/|help2man' \
| xargs grep -lE "^ *$t" \
| xargs perl -MText::Tabs -ni -le \
'$m=/^( *\t[ \t]*)(.*)/; print $m ? expand($1) . $2 : $_'
maint: update all Copyright year lists to include 20092009-06-23T20:33:15ZJim Meyeringmeyering@redhat.com2009-06-23T20:33:15Zurn:sha1:2232b4d08fdc8ff3ae8e7aa1fa28c8315c41d9aduse xfreopen in place of unchecked freopen2008-11-10T07:11:59ZJim Meyeringmeyering@redhat.com2008-10-12T12:50:02Zurn:sha1:03911ef780eae7d060963bf01ccaf594779b9420
* bootstrap.conf (modules): Add xfreopen.
* src/cat.c (main): Include "xfreopen.h". Use xfreopen.
* src/cksum.c (cksum): Likewise.
* src/head.c (head_file, main): Likewise.
* src/md5sum.c (digest_file): Likewise.
* src/od.c (open_next_file): Likewise.
* src/split.c (type_undef): Likewise.
* src/sum.c (bsd_sum_file, sysv_sum_file): Likewise.
* src/tac.c (tac_file, main): Likewise.
* src/tail.c (tail_file, main): Likewise.
* src/tee.c (tee_files): Likewise.
* src/tr.c (main): Likewise.
* src/wc.c (wc_file): Likewise.
* po/POTFILES.in: Add lib/xfreopen.c
mktemp, sort, tac: don't use undefined after mkstemp failure2008-08-14T12:37:37ZJim Meyeringmeyering@redhat.com2008-08-13T18:53:12Zurn:sha1:22999697b81acf3e8683c95c310a36926e7af96f
When mkstemp fails, the template buffer may have undefined
contents, so we must not print it.
* src/sort.c (create_temp_file): Use temp_dir, not "file"
when diagnosing failed mkstemp, because "file" may be undefined.
* tests/misc/sort-merge: Adjust for new expected output.
Jeph Cowan and Ralf Wildenhues reported the test failure:
http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/14235/focus=14257
* src/tac.c (copy_to_temp): Don't use template buffer after
failed mkstemp call, since its contents may be undefined.
* tests/misc/tac (pipe-bad-tmpdir): New test for the above.
* src/mktemp.c (main): Save a copy of the template string,
solely for use in case mkstemp fails.
* tests/misc/mktemp (pipe-bad-tmpdir): New test for the above.