coreutils/src/tail.c, branch v8.18Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/
https://git.shady.money/coreutils/atom?h=v8.182012-08-03T12:54:01Ztail: avoid rare error-path FD leak2012-08-03T12:54:01ZJim Meyeringmeyering@redhat.com2012-07-27T21:42:05Zurn:sha1:e11a2cf3198bcec9a5e10205bf3ebe66dc7edc59
* src/tail.c (tail_forever): Close FD to avoid leak after a
failed fstat.
tail: avoid misleading diagnostic upon fstat failure2012-07-25T17:00:22ZJim Meyeringmeyering@redhat.com2012-07-25T16:35:36Zurn:sha1:a6e8e3a3e116f2cdaa452eb66032d912092d0026
* src/tail.c (check_fspec): Save fstat-induced errno *before*
calling close_fd, not after. Otherwise, the close could well
clobber the global errno, making tail print an invalid diagnostic.
This could happen only with tail -f, and even then, only when
a valid file descriptor were to provoke fstat failure.
maint: use single copyright year range2012-01-27T10:35:24ZJim Meyeringmeyering@redhat.com2012-01-27T10:35:24Zurn:sha1:d7878454cd02518959b0d6036db3a5b6ff00ca57
Run "make update-copyright".
maint: src/*.[ch]: convert more `...' to '...'2012-01-09T20:51:59ZJim Meyeringmeyering@redhat.com2012-01-08T20:03:22Zurn:sha1:3ba8b044267a5f7cfa8a7b0d7f19dab3f21431da
Run this (twice):
git grep -E -l '`.+'\' src/*.[ch] \
|xargs perl -pi -e 's/`(.+?'\'')/'\''$1/'
maint: src/*.c: change remaining quotes (without embedded spaces)2012-01-09T20:50:08ZJim Meyeringmeyering@redhat.com2012-01-08T14:08:30Zurn:sha1:a517386f1bf8c64ee7617cc2c9d0a16a1d85c8c4
Run this (twice):
git grep -E -l '`[^ ]+'\' src/*.c \
|xargs perl -pi -e 's/`([^ ]+'\'')/'\''$1/'
maint: convert `...' to '...' in --help output2012-01-09T20:50:08ZJim Meyeringmeyering@redhat.com2012-01-08T13:08:03Zurn:sha1:9af0dced5a2eb167ec7b9dfe3f358f214e45d41a
All affected lines end with \ or \n\, so run this command
until it produces no new changes (4 times):
git grep -E -l '`[^ ]+'\''.*\\' src \
|xargs perl -pi -e 's/`([^ ]+'\''.*\\)/'\''$1/'
maint: use new emit_try_help in place of equivalent fprintf2012-01-07T15:54:26ZJim Meyeringmeyering@redhat.com2012-01-07T15:54:26Zurn:sha1:101d1203c667ec3ab54a026dde43117563d4e944
Run this command:
perl -0777 -pi -e \
's/fprintf \(stderr, _\("Try `%s --help.*\n.*;/emit_try_help ();/m'\
src/*.c
build: tail: avoid type/format mismatch warning from gcc2012-01-02T21:35:36ZJim Meyeringmeyering@redhat.com2012-01-02T20:28:15Zurn:sha1:3a189ae0ce8b34aa5f2dd15ccb3aaf33459cbb1c
Without this change, gcc's -Werror=format would complain that
the '%lx' format requires 'long unsigned int', not 'int'.
* src/tail.c (fremote): Use a temporary variable.
maint: update all copyright year number ranges2012-01-01T09:04:06ZJim Meyeringmeyering@redhat.com2012-01-01T08:47:10Zurn:sha1:5111aa42968262bd4d44eeca277b194020bb5007
Run "make update-copyright".
tail: avoid theoretically undefined behavior2011-12-28T17:53:32ZJim Meyeringmeyering@redhat.com2011-12-28T17:30:50Zurn:sha1:6e00315bf290310895036fce979a7e0210871b63
* src/tail.c (start_lines): Do not form potentially-invalid address.
Use safe_read's return value as a pointer offset only after
ensuring that it is not SAFE_READ_ERROR (size_t)(-1).
Spotted by coverity.
Also, move declaration of "p" to be closer to first use.