coreutils/src, branch v9.5

ls: avoid ENOENT from readdir() on FreeBSD 14

2024-03-26T18:57:32Z

* src/ls.c (print_dir): readdir() on FreeBSD 14 was seen to pass ENOENT through. ENOENT in this context means "Directory unlinked but still open". Reported by Bruno Haible with tests/ls/removed-directory.sh

cp: with --no-preserve=mode ensure set-group-ID bits maintained on dirs

2024-03-25T22:27:15Z

This issue was introduced in commit v8.19-145-g24ebca6 * src/copy.c (copy_internal): On systems that don't support ACLs, the fallback default chmod done on directories should maintain the set-group-ID, as that's generally auto-set by the system. * NEWS: Mention the fix. Reported by Bruno Haible on Alpine (with tests/cp/preserve-mode.sh)

doc: fix translation issue in chown/chgrp amalgamation

2024-03-24T20:25:37Z

* src/chown-core.h (emit_from_option_description): The conditional string composition here caused issues for translators. Instead move to a more general description ... (src/chown.c (usage): ... here. Fixes https://bugs.gnu.org/69985

doc: fix various translation issues

2024-03-24T19:57:29Z

src/chown.c (usage): Translate parameterized strings. src/copy.c (copy_internal): Translate each part of ternary. * src/cp.c (usage): Fix typo; s/exisiting/existing/.

mv: treat --exchange more like non-exchange

2024-03-23T01:39:27Z

Also, improve quality of diagnostics. Problems/suggestions by Bernhard Voelker in . * src/copy.c (emit_verbose): New arg FORMAT. All uses changed, to improve quality of diagnostics when --exchange is used. (copy_internal): Don’t try to optimize --exchange so much; this simplifies the code and keeps it closer to the non --exchange case.

cp,ln,mv: improve dir vs nondir diagnostics

2024-03-23T01:39:27Z

* src/copy.c (copy_internal): Simplify logic for copying from directory to non-directory or vice versa, and always diagnose with both source and destination file names.

env: add -a,--argv0 to set the first argument passed to exec

2024-03-22T13:12:52Z

Using the shell's exec -a feature can be awkward so add support for setting overriding argv[0]. This gives env full control over the arguments it passes. * src/env.c: Accept -a,--argv0 and set argv[0] appropriately. * tests/env/env.sh: Add test cases. * doc/coreutils.texi (env invocation): Describe -a,--argv0. * NEWS: Mention the new feature.

mv: new option --exchange

2024-03-20T21:40:29Z

* src/copy.h (struct cp_options): New member 'exchange'. * src/copy.c (copy_internal): Support the new member. * src/mv.c (EXCHANGE_OPTION): New constant. (long_options): Add --exchange. (usage): Document --exchange. (main): Support --exchange. * tests/mv/mv-exchange.sh: New test case. * tests/local.mk (all_tests): Add it.

chmod: fix TOCTOU security issue with symlink replacement

2024-03-19T23:56:45Z

This is an issue with -[H]R mode, where an attacker may replace a traversed file with a symlink between where we stat() the file and chmod() the file. * src/chmod.c (process_file): Remove the first !S_ISLNK guard as that's now just an optimization, and instead consistently apply fchmodat() to files/symlinks. Ensure AT_SYMLINK_NOFOLLOW is set when traversing in default (-H) mode. * NEWS: Mention the bug fix. Fixes https://bugs.gnu.org/11108

chmod: add support for -h, -H,-L,-P, --dereference options

2024-03-19T23:43:53Z

There have been various requests to add -h to avoid following symlinks for security reasons. This wasn't provided previously as chmod(1) already ignored symlinks unless specified on the command line. Note chmod defaults to -H mode rather than the chown default of -P, as usually chown can work directly on symlinks and so defaults to not traversing those specified on the command line. Note FreeBSD chmod does default to -P mode, but we retain the -H mode default also for compatibility with existing chmod behavior. Adding -HLP will allow chmod to disable traversing CLI symlinks to dirs. Adding -h will allow to disable following CLI symlinks to files/dirs, also operating on all symlinks on systems that support that. Adding --dereference will be significant with -H (the default). I.e. symlinks to dirs not recursed, but symlinks are dereferenced. Adding these options will also be consistent with chown(1), chgrp(1), and chmod(1) on other systems. Note since chmod(1) currently ignores symlinks by default, and -h is primarily a mechanism to avoid following symlinks, rather than for operating on the symlink itself, we make -h try to chmod a symlink, but ignore ENOTSUP. In that way we're consistent with chown(1) where it also ignores ENOTSUP for symlinks, and we don't fail when trying to be extra secure with command line params. * doc/coreutils.texi (chmod invocation): Reference the -H,-L,-P descriptions, and adjust the corresponding macros to say the default is -H or -P as appropriate. Add --dereference and -h,--no-dereference descriptions. * man/chmod.x: Adjust discussion of symlink handling. * src/chmod.c (main): Accept new options and set fts flags appropriately. (process_file): Process / dereference symlinks as necessary. * src/system.h (emit_symlink_recurse_options): A new function refactored from chown.c and chmod.c usage(). * tests/chmod/symlinks.sh: New test for the new options. * tests/local.mk: Reference the new test. * NEWS: Mention the new feature.