coreutils/tests/cp/same-file, branch v8.8Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/
https://git.shady.money/coreutils/atom?h=v8.82010-12-03T19:09:27Ztests: cleanup rm -rf fails under NFS2010-12-03T19:09:27ZPaul Eggerteggert@cs.ucla.edu2010-12-03T19:08:48Zurn:sha1:b6ef652e50f49e55871c5d08c43ee250950f1cbb
This problem was observed on RHEL 5.5 x86-64 when running as a
client of a NetApp FAS2050.
* tests/cp/cp-mv-backup: Don't leave a file descriptor open to
a file in a directory that will be cleaned up with "rm -rf".
Under NFS, when the rm unlinks that file, it is instead renamed
to .nfsXXXX and then rm cannot remove the parent directory,
and the test fails.
* tests/cp/same-file: Likewise.
tests: substitute the single-program $VERBOSE/--version uses2010-11-17T20:45:51ZJim Meyeringmeyering@redhat.com2010-11-17T20:35:31Zurn:sha1:293c37b9061c1afd0acd143bbded637a8f00b3a0
Automatically make all of the changes like this:
-test "$VERBOSE" = yes && chgrp --version
+print_ver_ chgrp
git grep -l 'VERBOSE.*--version'|xargs perl -pi -e \
's/test "\$VERBOSE" = yes && (\w+) --version/print_ver_ $1/'
tests: convert first batch of tests from test-lib.sh to init.sh2010-11-17T19:48:57ZJim Meyeringmeyering@redhat.com2010-11-14T10:05:05Zurn:sha1:f38becab02472e6872048a1951b249b2a3c054df
Initially, I did this,
git grep -l srcdir/test-lib.sh|xargs perl -p0i -e '~180-byte script'
but that line would have been much longer than the maximum permitted
by coreutils' commit hook, and wasn't readable besides, so here's a
more readable version:
lhs=$(printf '%s\\n' \
'if test "$VERBOSE" = yes; then' \
' set -x' \
' touch --version' \
'fi' \
'' \
'. $srcdir/test-lib.sh' \
| sed 's/\$/\\\$/g;s/touch/(\\w+)/')
rhs=$(printf '%s\\n' \
'. "${srcdir=.}/init.sh"; path_prepend_ ../src' \
'test "$VERBOSE" = yes && FIXME --version' \
| sed 's/\$/\\\$/g;s/FIXME/\$1/')
git grep -l srcdir/test-lib.sh|xargs perl -p0i -e "s,$lhs,$rhs,"
maint: update all FSF copyright year lists to include 20102010-01-01T13:06:47ZJim Meyeringmeyering@redhat.com2010-01-01T09:56:28Zurn:sha1:1aa17dc89b3f313697661541adca0aa0defbdc09
Use this command:
git ls-files | grep -v COPYING \
| xargs env UPDATE_COPYRIGHT_USE_INTERVALS=1 \
build-aux/update-copyright
tests: factor 350 fail=0 initializations into test-lib.sh2009-10-30T11:50:12ZJim Meyeringmeyering@redhat.com2009-10-30T09:50:21Zurn:sha1:3c88587b2eadee11413f4207abbbf13af07c438d
Run this command to remove the factored-out "fail=0" lines.
perl -ni -e '/^fail=0$/ or print' $(g grep -l '^fail=0$')
* tests/test-lib.sh: Initialize fail=0 here, not in 300+ scripts.
* tests/...: nearly all bourne shell scripts
Suggested by Eric Blake.
tests: don't let a fail=1 env. setting induce unwarranted test failure2009-10-29T15:51:07ZJim Meyeringmeyering@redhat.com2009-10-29T13:40:40Zurn:sha1:39da66f979c206946e5593dbd432e88905a9e383
* cfg.mk (sc_fail_is_initialized): New rule.
Fix the offenders:
* tests/cp/acl: Set fail=0
* tests/cp/backup-is-src: Likewise.
* tests/cp/file-perm-race: Likewise.
* tests/cp/reflink-auto: Likewise.
* tests/cp/same-file: Likewise.
* tests/ln/backup-1: Likewise.
* tests/misc/su-fail: Likewise.
* tests/misc/truncate-owned-by-other: Likewise.
* tests/mkdir/p-3: Likewise.
* tests/mkdir/selinux: Likewise.
* tests/mkdir/special-1: Likewise.
* tests/mv/acl: Likewise.
* tests/mv/backup-is-src: Likewise.
* tests/mv/diag: Likewise.
* tests/mv/force: Likewise.
* tests/mv/hard-link-1: Likewise.
* tests/mv/into-self-3: Likewise.
* tests/mv/sticky-to-xpart: Likewise.
* tests/touch/now-owned-by-other: Likewise.
global: convert indentation-TABs to spaces2009-08-25T07:21:00ZJim Meyeringmeyering@redhat.com2009-08-22T16:56:06Zurn:sha1:5e778f7c8d1ecf3d8f11385db013af2ba026e2a5
Transformed via this shell code:
t=$'\t'
git ls-files \
| grep -vE '(^|/)((GNU)?[Mm]akefile|ChangeLog)|\.(am|mk)$' \
| grep -vE 'tests/pr/|help2man' \
| xargs grep -lE "^ *$t" \
| xargs perl -MText::Tabs -ni -le \
'$m=/^( *\t[ \t]*)(.*)/; print $m ? expand($1) . $2 : $_'
maint: update all Copyright year lists to include 20092009-06-23T20:33:15ZJim Meyeringmeyering@redhat.com2009-06-23T20:33:15Zurn:sha1:2232b4d08fdc8ff3ae8e7aa1fa28c8315c41d9adfix minor shell issues in test suite2008-09-10T11:20:27ZRalf WildenhuesRalf.Wildenhues@gmx.de2008-09-09T17:45:25Zurn:sha1:9dcebc51be915fb6d0ab2eca36168f3ab12a45c7
* tests/misc/help-version: Fix bad quoting.
* tests/cp/same-file: Fix unportable shell quoting.
* tests/mv/part-symlink: Likewise.
tests: use "Exit $fail", not (exit $fail); exit $fail2008-09-10T11:20:10ZJim Meyeringmeyering@redhat.com2008-09-07T08:31:27Zurn:sha1:68561594ca022703e255b3ef5686f176317e5fd4
* tests/test-lib.sh (Exit): New function by Ralf Wildenhues in automake
http://git.sv.gnu.org/gitweb/?p=automake.git;a=commitdiff;h=20594c08f63
* tests/**: Convert all uses:
This restrictive change converted the vast majority:
git grep -l '^(exit \$fail); exit \$fail$' \
| xargs perl -pi -e 's/'^\(exit \$fail\); exit \$fail$/Exit \$fail/'
And this did the rest, plus a few undesirable ones, so I manually
backed out the changes to ChangeLog-* and build-aux/check.mk:
git grep -l -E '\(exit [^)]+\); exit ' \
| xargs perl -pi -e 's/\(exit (.+?)\); exit \1/Exit $1/'