coreutils/tests/factor/factor.pl, branch v9.8Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/
https://git.shady.money/coreutils/atom?h=v9.82025-07-10T00:12:39Zfactor: switch from mp to single when doable2025-07-10T00:12:39ZPaul Eggerteggert@cs.ucla.edu2025-06-04T17:12:29Zurn:sha1:831623ba6683d8a8254b0ebcb1ee98191729a190
This significantly improves performance when a number exceeds
2**(W_TYPE_SIZE - 1) and is the product of a prime less than
FIRST_OMITTED_PRIME and another prime less than 2**(W_TYPE_SIZE - 1).
On my platform, for example, it doubled the speed of factoring
4999 * (2**128 - 159).
* src/factor.c (mp_size, mp_finish_in_single): New functions.
(mp_factor_using_division, mp_factor_using_pollard_rho):
Finish using single precision when possible.
* tests/factor/factor.pl (lt-5000-times-128-bit): New test.
factor: fix test case name2025-07-10T00:12:39ZPaul Eggerteggert@cs.ucla.edu2025-05-20T21:15:01Zurn:sha1:badc24c30cc7ab440335270765810ee1f1970727
* tests/factor/factor.pl (bug-gmp-plus_2_sup_127_plus_1):
Rename from bug-gmp-plus_2_sup_128_plus_1, so that
it accurately reflects the test case.
factor: fix bug with 128-bit uintmax_t2025-05-18T04:49:22ZPaul Eggerteggert@cs.ucla.edu2025-05-18T04:42:37Zurn:sha1:fe51b33859d2e7286425d6d5600288ce9ae43bd1
On so-far-only-theoretical platforms with 128-bit uintmax_t,
'factor' would misbehave by not factoring enough.
Work around the bug (at a performance cost)
and document the issue. I hope someone with
more time and expertise can fix the performance cost
that this introduces.
To reproduce the correctness bug, build with
'gcc -DUSE_INT128 -DEXHIBIT_INT128_BUG';
'make check' should fail due to the new test case.
* src/factor.c (USE_INT128): New macro.
(wide_uint, wide_int, W_TYPE_SIZE, WIDE_UINT_MAX):
Define to proper values if USE_INT128.
(prime_p) [!EXHIBIT_INT128_BUG]: Work around bug
with 128-bit wide_uint, at some performance cost.
* tests/factor/factor.pl (bug-with-128-bit-uintmax_t):
New test.
maint: tests: remove duplicate uses of 'my' in Perl2025-01-20T15:45:03ZCollin Funkcollin.funk1@gmail.com2025-01-20T05:15:35Zurn:sha1:91d5a512365726b89868b7113d9df5cbe6cab270
* tests/env/env-S.pl (cf): Remove uses of 'my' after the variable has
been declared.
* tests/factor/factor.pl (t): Likewise.
* tests/misc/fold.pl (prog): Remove duplicate assignment.
maint: update all copyright year number ranges2025-01-01T09:33:08ZPádraig BradyP@draigBrady.com2025-01-01T09:14:56Zurn:sha1:28b176085f04a6227d7fadd28a129b5cb02dfbf5
Update to latest gnulib with new copyright year.
Run "make update-copyright" and then...
* gnulib: Update included in this commit as copyright years
are the only change from the previous gnulib commit.
* tests/init.sh: Sync with gnulib to pick up copyright year.
* bootstrap: Likewise.
* tests/sample-test: Adjust to use the single most recent year.
maint: update all copyright year number ranges2024-01-01T13:27:23ZPádraig BradyP@draigBrady.com2024-01-01T13:22:42Zurn:sha1:a966dcdb69e2f49f2587e1b7d4ade7efcff29f40
Update to latest gnulib with new copyright year.
Run "make update-copyright" and then...
* gnulib: Update included in this commit as copyright years
are the only change from the previous gnulib commit.
* tests/init.sh: Sync with gnulib to pick up copyright year.
* bootstrap: Manually update copyright year,
until we fully sync with gnulib at a later stage.
* tests/sample-test: Adjust to use the single most recent year.
tests: move tests to a directory per utility2023-06-19T12:12:37ZSylvestre Ledrusylvestre@debian.org2023-06-11T09:55:56Zurn:sha1:15925d0e5b80467c354fe27cb1205d6b6e3da11d
* cfg.mk: Adjust syntax check exclusion paths.
* tests/local.mk: Adjust for renamed tests.