coreutils/tests/factor, branch master

tests: factor,numfmt: verify embedded NUL handling

2026-02-25T14:52:57Z

* tests/factor/factor.pl: Verify that embedded NULs on stdin terminate the _number_. * tests/numfmt/numfmt.p: Verify that embedded NULs on stdin terminate the _line_. https://github.com/coreutils/coreutils/pull/196

maint: run 'make update-copyright'

2026-01-01T18:56:16Z

tests: factor: add suggested large prime tests

2025-10-02T16:22:28Z

* tests/factor/create-test.sh: Add 2 new large primes from: https://github.com/coreutils/coreutils/issues/65 * tests/local.mk: Reference the 2 new generated tests.

factor: don’t prove primality

2025-07-10T00:12:40Z

Suggested for consideration by Torbjörn Granlund in: https://lists.gnu.org/r/coreutils/2025-01/msg00000.html * src/factor.c (PROVE_PRIMALITY): Now defaults to false. (mp_prime_p): Help the compiler by telling it mpz_prob_prime_p returns nonnegative. * tests/factor/create-test.sh (bigprime): Test 2^400 - 593, since that’s now practical. * tests/local.mk (factor_tests): Add new test.

factor: switch from mp to single when doable

2025-07-10T00:12:39Z

This significantly improves performance when a number exceeds 2**(W_TYPE_SIZE - 1) and is the product of a prime less than FIRST_OMITTED_PRIME and another prime less than 2**(W_TYPE_SIZE - 1). On my platform, for example, it doubled the speed of factoring 4999 * (2**128 - 159). * src/factor.c (mp_size, mp_finish_in_single): New functions. (mp_factor_using_division, mp_factor_using_pollard_rho): Finish using single precision when possible. * tests/factor/factor.pl (lt-5000-times-128-bit): New test.

factor: fix test case name

2025-07-10T00:12:39Z

* tests/factor/factor.pl (bug-gmp-plus_2_sup_127_plus_1): Rename from bug-gmp-plus_2_sup_128_plus_1, so that it accurately reflects the test case.

factor: fix bug with 128-bit uintmax_t

2025-05-18T04:49:22Z

On so-far-only-theoretical platforms with 128-bit uintmax_t, 'factor' would misbehave by not factoring enough. Work around the bug (at a performance cost) and document the issue. I hope someone with more time and expertise can fix the performance cost that this introduces. To reproduce the correctness bug, build with 'gcc -DUSE_INT128 -DEXHIBIT_INT128_BUG'; 'make check' should fail due to the new test case. * src/factor.c (USE_INT128): New macro. (wide_uint, wide_int, W_TYPE_SIZE, WIDE_UINT_MAX): Define to proper values if USE_INT128. (prime_p) [!EXHIBIT_INT128_BUG]: Work around bug with 128-bit wide_uint, at some performance cost. * tests/factor/factor.pl (bug-with-128-bit-uintmax_t): New test.

maint: tests: remove duplicate uses of 'my' in Perl

2025-01-20T15:45:03Z

* tests/env/env-S.pl (cf): Remove uses of 'my' after the variable has been declared. * tests/factor/factor.pl (t): Likewise. * tests/misc/fold.pl (prog): Remove duplicate assignment.

maint: update all copyright year number ranges

2025-01-01T09:33:08Z

Update to latest gnulib with new copyright year. Run "make update-copyright" and then... * gnulib: Update included in this commit as copyright years are the only change from the previous gnulib commit. * tests/init.sh: Sync with gnulib to pick up copyright year. * bootstrap: Likewise. * tests/sample-test: Adjust to use the single most recent year.

factor: port to platforms

2024-09-28T00:42:58Z

* src/factor.c (mod2): Work even if cntd <= cnta. The old version of the code assumed that shifts by N had unspecified behavior unless 0 <= N < wordsize. Although this assumption is portable to all known practical platforms, the C standard says these shifts have undefined behavior and some pedantic platforms check this. * tests/factor/create-test.sh: * tests/local.mk (factor_tests): New test t37.