Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/ https://git.shady.money/coreutils/atom?h=master 2012-08-30T16:55:59Z 2012-08-30T16:55:59Z Stefano Lattarini stefano.lattarini@gmail.com 2012-08-30T12:13:12Z urn:sha1:9eb4c31eb78c28dd9f72d1cbb940270311be343c Not only this shrinks the size of the generated Makefile (from > 6300 lines to ~3000), but will allow further simplifications in future changes. * tests/Makefile.am (TEST_EXTENSIONS): Add '.sh' and '.pl'. (PL_LOG_COMPILER, SH_LOG_COMPILER): New, still defined simply to $(LOG_COMPILER) for the time being. (TESTS, root_tests): Adjust as described. * All tests: Rename as described. 2012-04-04T10:20:56Z Jim Meyering meyering@redhat.com 2012-04-03T18:32:44Z urn:sha1:e43d30eab3215bc9ff49ec7db3d3e2baa95ba070 Exempt init.sh because it runs before we're assured to have a shell that groks $(...). Exempt *.mk because "$" would have to be doubled, and besides, any `...` expression in a .mk file is almost certainly evaluated before init.sh is run. Finally, also exempt the perl-based tests, because perl's `...` cannot be converted to $(...). Do that by running this command: git grep -l '`.*`' tests \ | grep -Ev 'init\.sh|\.mk$' | xargs grep -Lw perl \ | xargs perl -pi -e 's/`(.*?)`/\$($1)/g' One minor fix-up change was required after that, due to how quoting differs: diff --git a/tests/chmod/equals b/tests/chmod/equals - expected_perms=$(eval 'echo \$expected_'$dest) + expected_perms=$(eval 'echo $expected_'$dest) Another was to make these required quoting adjustments: diff --git a/tests/misc/stty b/tests/misc/stty ... - rev=$(eval echo "\\\$REV_$opt") + rev=$(eval echo "\$REV_$opt") ... - rev1=$(eval echo "\\\$REV_$opt1") - rev2=$(eval echo "\\\$REV_$opt2") + rev1=$(eval echo "\$REV_$opt1") + rev2=$(eval echo "\$REV_$opt2") Also, transform two files that were needlessly excluded above: (both use perl, but are mostly bourne shell) perl -pi -e 's/`(.*?)`/\$($1)/g' \ tests/du/long-from-unreadable tests/init.cfg 2012-01-27T10:35:24Z Jim Meyering meyering@redhat.com 2012-01-27T10:35:24Z urn:sha1:d7878454cd02518959b0d6036db3a5b6ff00ca57 Run "make update-copyright". 2012-01-09T20:50:08Z Jim Meyering meyering@redhat.com 2012-01-07T16:47:58Z urn:sha1:dd0e4c5621ca2fa9255aef4eee0e7cf41cd335d2 Exempt lines with '$' or '=', since those are prone to improper conversion. Run this: git grep -l "\`[^']*'" tests \ |xargs perl -pi -e '/[=\$]/ and next;s/\`([^'\''"]*?'\'')/'\''$1/g' 2012-01-01T09:04:06Z Jim Meyering meyering@redhat.com 2012-01-01T08:47:10Z urn:sha1:5111aa42968262bd4d44eeca277b194020bb5007 Run "make update-copyright". 2011-11-22T09:34:43Z Jim Meyering meyering@redhat.com 2011-11-22T09:18:30Z urn:sha1:9d98634b3908786bb048b72624da244e681f87b9 * tests/install/basic-1: Use compare, not diff. * tests/mkdir/p-v: Likewise. * tests/mv/part-fail: Likewise. * tests/rm/rm1: Likewise. * tests/rm/rm2: Likewise. * tests/touch/not-owner: Likewise. 2011-08-08T08:11:48Z Stefano Lattarini stefano.lattarini@gmail.com 2011-08-04T18:52:31Z urn:sha1:554caaf6ffc721fe83debe0eb5e555136b01f0bb These changes were mostly mechanical, made by running the following command: git grep -lw framework_failure | grep -v ChangeLog \ | xargs perl -pi -e 's/\b(framework_failure)\b/${1}_/' and then editing init.cfg and `tests/cp/cp-a-selinux' by hand. * tests/init.cfg (framework_failure): Remove, `framework_failure_' from init.sh should be used instead in the tests. Remove now-obsolete "FIXME" comment. (is_local_dir_, require_strace_, require_membership_in_two_groups_, require_sparse_support_, skip_if_mcstransd_is_running_, mkfifo_or_skip_) Use `framework_failure_', not `framework_failure'. * Many test scripts: Likewise. 2011-01-01T21:16:47Z Jim Meyering meyering@redhat.com 2011-01-01T10:37:32Z urn:sha1:9d6231ef2a74671fa08bc263519edfe46e8d1805 Run "make update-copyright". 2010-12-28T20:30:42Z Paul Eggert eggert@cs.ucla.edu 2010-12-28T20:28:48Z urn:sha1:b0097f3d2180352896a4434fb8eaeb076f12794c * cfg.mk (LINE_LEN_MAX, FILTER_LONG_LINES): New macros. (sc_long_lines): New rule. * HACKING: Use shorter URLs to the same material. * doc/Makefile.am, doc/coreutils.texi, m4/boottime.m4: * man/help2man, man/stdbuf.x, src/Makefile.am, src/cat.c, src/copy.c: * src/cp.c, src/dd.c, src/df.c, src/du.c, src/groups.c, src/install.c: * src/ls.c, src/md5sum.c, src/mv.c, src/od.c, src/pinky.c, src/ptx.c: * src/readlink.c, src/remove.c, src/rmdir.c, src/setuidgid.c: * src/sort.c, src/tail.c, src/touch.c, tests/Coreutils.pm: * tests/cp/existing-perm-race, tests/cp/perm, tests/cp/preserve-gid: * tests/du/2g, tests/du/long-from-unreadable, tests/init.sh: * tests/install/basic-1, tests/ls/nameless-uid: * tests/ls/readdir-mountpoint-inode, tests/misc/chroot-credentials: * tests/misc/cut, tests/misc/date, tests/misc/join, tests/misc/md5sum: * tests/misc/sha1sum, tests/misc/sha224sum, tests/misc/sort: * tests/misc/sort-continue, tests/misc/sort-files0-from: * tests/misc/sort-rand, tests/misc/stdbuf, tests/misc/tr: * tests/misc/uniq, tests/mv/atomic, tests/mv/part-fail: * tests/mv/part-symlink, tests/mv/sticky-to-xpart, tests/pr/pr-tests: * tests/rm/fail-2eperm, tests/rm/interactive-always: Reformat to fit within 80 columns. * doc/Makefile.am (BAD_POSIX_PERL): New macro. * doc/coreutils.texi: Reword slightly, to make menus and index lines shorter. * src/md5sum.c: Redo --help output so that it fits within 79 columns, since that's a bit more portable and all the other --help strings fit in 79 columns. 2010-12-13T07:29:42Z Jim Meyering meyering@redhat.com 2010-12-13T07:19:12Z urn:sha1:0c70708db7ed32d2b379116dc6bf64f07539aaf1 * tests/install/basic-1 (just_built_dd): Use warn_, rather than cat and exit 77.