Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/ https://git.shady.money/coreutils/atom?h=v8.5 2010-04-15T23:26:21Z 2010-04-15T23:26:21Z Pádraig Brady P@draigBrady.com 2010-04-14T14:32:27Z urn:sha1:3a1595a3fbb07c53ea920c969667f0346a10534c * tests/ls/color-norm: Use the "time" output by `ls -l` to check normal style. Previously we used the size from `ls -s`, but the size of "empty" files can vary depending on whether SELinux is enabled for example. 2010-04-14T13:48:31Z Jim Meyering meyering@redhat.com 2010-04-14T13:48:31Z urn:sha1:05bee6f116d81084f5796b2ab1ec12135fb72fc2 * tests/ls/capability: Adjust this test not to expect the no-op escape sequence that was removed from all other tests by 2010-01-30 commit 5d43617e, "ls --color: don't emit a final no-op escape sequence". 2010-02-17T23:25:12Z Moritz Orbach ml-coreutils@apfelboymchen.homeunix.net 2010-02-16T22:48:00Z urn:sha1:f5268e2749d5649a3364550ef54bf31d9aa9c4e1 Output the NORMAL attribute before non file name text. This attribute will continue into file names that would not otherwise be colored unless FILE is also set. The regression was introduced with commit 483297d5, 28-02-2009, "ls --color no longer outputs unnecessary escape sequences". * src/ls.c (set_normal_color): A new function to output the NORMAL attribute sequence if it's enabled. (print_current_files): Output NORMAL before printing long format info. (print_file_name_and_frills): Output NORMAL before printing file name. (print_color_indicator): Reset the attributes before a file name with attributes so that NORMAL attributes will not combine with them. (print_name_with_quoting): Ensure attributes are reset after printing the file name if NORMAL attributes were output. * tests/ls/color-norm: A new test for NORMAL and FILE combinations. * tests/Makefile.am: Reference the new test. * NEWS: Mention the fix. Reported in https://savannah.gnu.org/bugs/?26512 2010-02-02T15:16:40Z Pádraig Brady P@draigBrady.com 2010-02-02T10:47:48Z urn:sha1:dd2253f49da057a677199b18b8673cc09bd1f2f5 Prompted by the continuous integration build failure at: http://hydra.nixos.org/build/277485 * tests/misc/timeout: Set all expected timeouts to 1s and all unexpected timeouts to 10s. In this way, tests normally proceed quickly but may delay up to 10s before reporting failures. * tests/ls/infloop: Likewise. * tests/tail-2/pid: Likewise. * tests/tail-2/pipe-f: Likewise. * tests/tail-2/wait: Likewise. * tests/dd/skip-seek-past-dev: Likewise. 2010-02-01T07:26:12Z Jim Meyering meyering@redhat.com 2010-01-30T22:52:46Z urn:sha1:5d43617e8ad863ed041309edefd018fdcaa87038 * src/ls.c (main): With --color, avoid emitting the final color- resetting escape sequence when it would be a no-op. * tests/ls/color-clear-to-eol: Adjust expected output accordingly. * tests/ls/color-dtype-dir: Likewise. * tests/ls/multihardlink: Likewise. * tests/ls/stat-free-symlinks: Likewise. * tests/misc/ls-misc: Likewise. * NEWS (Changes in behavior): Mention it. C de-Avillez rebased and adapted four of the new sl-dangle* tests in tests/misc/ls-misc. Reported by Jim Avera in http://bugs.launchpad.net/ubuntu/+source/coreutils/+bug/494663 2010-01-23T22:53:52Z Pádraig Brady P@draigBrady.com 2010-01-22T19:26:16Z urn:sha1:014fead953b630560f308fe577cf5488f4c95bc0 * tests/cp/acl: Support USE_ACL not being defined. * tests/mv/acl: Likewise. Also fix typo in skip message. * tests/cp/preserve-slink-time: Support HAVE_UTIMENSAT being 0. * tests/touch/no-dereference: Likewise. * tests/ls/capability: Normalize so 1 is not required to be last char. 2010-01-13T09:55:55Z Jim Meyering meyering@redhat.com 2010-01-13T09:53:32Z urn:sha1:f28c7d959be30be0b216880878e8b0909d810a18 * tests/ls/infloop: OpenBSD4.5's /bin/sh would mistakenly include "set -x"-output in an application's stderr stream when stderr is redirected before stdout. This was causing one spurious test failure. The work-around: redirect stdout first. Reported by Nelson Beebe. 2010-01-01T13:06:47Z Jim Meyering meyering@redhat.com 2010-01-01T09:56:28Z urn:sha1:1aa17dc89b3f313697661541adca0aa0defbdc09 Use this command: git ls-files | grep -v COPYING \ | xargs env UPDATE_COPYRIGHT_USE_INTERVALS=1 \ build-aux/update-copyright 2009-12-06T07:48:51Z Jim Meyering meyering@redhat.com 2009-12-05T16:41:28Z urn:sha1:d8cadda3b9b656870d54fe89dc94e72ecd496013 * tests/ls/readdir-mountpoint-inode: With some systems, stat can succeed on a mount point and report that the inode number is 0. Since ls displays "?" for those, that would otherwise show up as a difference. Skip such mount points. Reported by Sergei Steshenko in http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/19142 2009-11-09T08:16:20Z Pádraig Brady P@draigBrady.com 2009-11-08T03:45:27Z urn:sha1:10d97b31910b0030f7716474a48b3fc8e00dd216 Capability checking was incorrectly done on just the base name rather than on the whole path. Consequently there could be both false positives and negatives when coloring files with capabilities. Also capability checking was not done at all in certain cases for non executable files. Note passing absolute rather than relative names to cap_get_file() reduces the has_capability() overhead from around 33% to 30%. I.E. ls --color is now around 3% faster. * src/ls.c (struct fileinfo): Add a has_capability member. (print_color_indicator): Refactor to pass just a fileinfo pointer and a flag to say if we're dealing with a symlink target. (print_name_with_quoting): Likewise. (gobble_file): Set has_capability in the fileinfo struct. Also do a capability check even if executable coloring is disabled. Ditto for SETUID and SETUID coloring. Comment on how expensive has_capability() is. (print_long_format): Adjust to refactored print_name_with_quoting. (quote_name): Likewise. (print_file_name_and_frills): Likewise. * tests/ls/capability: Test the various false positive and negatives. * THANKS: Add reporter (Ivan Labath). * NEWS: Mention the fix.