coreutils/tests/mv, branch v8.8Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/
https://git.shady.money/coreutils/atom?h=v8.82010-12-22T10:52:11Zmaint: correct test-related comments2010-12-22T10:52:11ZJim Meyeringmeyering@redhat.com2010-12-22T10:49:25Zurn:sha1:887d530e62f7495de3a8289d07bf11a76390555b
* tests/mv/i-3: Adjust comment to match just-changed code.
Spotted by Pádraig Brady.
* tests/init.cfg (retry_delay_): Correct spelling of function name
in usage example.
tests: mv/i-3: avoid false-positive failure on a slow/busy system2010-12-22T09:29:30ZJim Meyeringmeyering@redhat.com2010-12-22T09:29:30Zurn:sha1:a300cfd43ccb3f48f5110a2abf6fe234fece3dc3
* tests/mv/i-3: Quadruple the timeout duration.
Without this, I saw an expired timeout on a heavily-loaded system.
tests: avoid new false-positive failure on at least FreeBSD 8.12010-12-21T08:30:55ZJim Meyeringmeyering@redhat.com2010-12-20T13:27:08Zurn:sha1:7ca55ef3d1ac512aaa99871adcdd8f21eb5af775
* tests/mv/trailing-slash: Accommodate different diagnostic
on FreeBSD 8.1.
cp: give a better diagnostic for nonexistent dest/2010-11-22T08:04:50ZPaul Eggerteggert@cs.ucla.edu2010-11-22T02:50:41Zurn:sha1:013d95af11f41cbe05abdb73c997040dce4301f8
This patch was written by Jim Meyering and myself.
* src/copy.c (copy_reg): Turn EISDIR to ENOTDIR to improve the
quality of diagnostics for commands like "cp a nosuch/". Reported
by Марк Коренберг and Alan Curry in the thread starting at:
http://lists.gnu.org/archive/html/bug-coreutils/2010-11/msg00178.html
* THANKS: Update.
* tests/mv/trailing-slash: Add a test.
tests: convert the multi-prog $VERBOSE/--version uses2010-11-17T20:46:25ZJim Meyeringmeyering@redhat.com2010-11-17T20:38:38Zurn:sha1:8f9be76b0d6995919ee960ce5864715faa11ea5b
E.g.,
-test "$VERBOSE" = yes && { env -- pwd --version; readlink --version; }
+print_ver_ pwd readlink
-test "$VERBOSE" = yes && { stdbuf --version; mv --version; }
+print_ver_ stdbuf mv
Use this command:
git grep -l 'VERBOSE.*--version'|xargs perl -ni \
-e '/^test "\$VERBOSE" = yes && { .*--version/ or print,next;' \
-e 's/env -- //g;' \
-e 's/test "\$VERBOSE" = yes && { /print_ver_ /;' \
-e ' s/(\w+) --version;/$1/g; s/ *}$//; print'
tests: substitute the single-program $VERBOSE/--version uses2010-11-17T20:45:51ZJim Meyeringmeyering@redhat.com2010-11-17T20:35:31Zurn:sha1:293c37b9061c1afd0acd143bbded637a8f00b3a0
Automatically make all of the changes like this:
-test "$VERBOSE" = yes && chgrp --version
+print_ver_ chgrp
git grep -l 'VERBOSE.*--version'|xargs perl -pi -e \
's/test "\$VERBOSE" = yes && (\w+) --version/print_ver_ $1/'
tests: convert remaining uses of test-lib.sh to init.sh2010-11-17T19:48:57ZJim Meyeringmeyering@redhat.com2010-11-14T11:07:57Zurn:sha1:fbcc100f5bc4e5d57370544093fc9edfbde411d3
RHS='. "\${srcdir=.}/init.sh"; path_prepend_ ../src'
git grep -l test-lib.sh \
| xargs perl -pi -e 's,^\. \$srcdir/test-lib\.sh$,'"$RHS",
tests: convert 'if test "$VERBOSE" = yes; then' to test ... &&2010-11-17T19:48:57ZJim Meyeringmeyering@redhat.com2010-11-14T11:02:39Zurn:sha1:ff7f0ff85c40174f1885ec61fa4ab6b73d02b555tests: convert first batch of tests from test-lib.sh to init.sh2010-11-17T19:48:57ZJim Meyeringmeyering@redhat.com2010-11-14T10:05:05Zurn:sha1:f38becab02472e6872048a1951b249b2a3c054df
Initially, I did this,
git grep -l srcdir/test-lib.sh|xargs perl -p0i -e '~180-byte script'
but that line would have been much longer than the maximum permitted
by coreutils' commit hook, and wasn't readable besides, so here's a
more readable version:
lhs=$(printf '%s\\n' \
'if test "$VERBOSE" = yes; then' \
' set -x' \
' touch --version' \
'fi' \
'' \
'. $srcdir/test-lib.sh' \
| sed 's/\$/\\\$/g;s/touch/(\\w+)/')
rhs=$(printf '%s\\n' \
'. "${srcdir=.}/init.sh"; path_prepend_ ../src' \
'test "$VERBOSE" = yes && FIXME --version' \
| sed 's/\$/\\\$/g;s/FIXME/\$1/')
git grep -l srcdir/test-lib.sh|xargs perl -p0i -e "s,$lhs,$rhs,"
tests: avoid portability problem with dash vs. symlinked ttys2010-11-09T12:43:20ZPádraig BradyP@draigBrady.com2010-11-09T12:43:20Zurn:sha1:425503c8073a17df5ace9bb9330ce283804b07e1
* tests/mv/i-3: Adjust so that the symlink is resolved
before redirecting to the background command, as otherwise
the stdin descriptor passed to the command will fail the
isatty() or ttyname() test.