coreutils/tests/split, branch v9.2Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/
https://git.shady.money/coreutils/atom?h=v9.22023-03-07T21:41:46Zsplit: support split -n on larger pipe input2023-03-07T21:41:46ZPaul Eggerteggert@cs.ucla.edu2023-03-07T20:58:12Zurn:sha1:bb9dbcbbfd5c3159f975f39336a33319c6c5df04
* bootstrap.conf (gnulib_modules): Add free-posix, tmpfile.
* src/split.c (copy_to_tmpfile): New function.
(input_file_size): Use it to split larger files when sizes cannot
easily be determined via fstat or lseek. See Bug#61386#235.
* tests/split/l-chunk.sh: Mark tests of /dev/zero as
very expensive since they exhaust /tmp.
split: handle large numbers better2023-03-04T22:49:46ZPaul Eggerteggert@cs.ucla.edu2023-03-04T19:42:16Zurn:sha1:3434cdcec18c918de992bc28b0e9f52b6f168d9b
Prefer signed types to uintmax_t, as this allows for better
runtime checking with gcc -fsanitize=undefined.
Also, when an integer overflows just use the maximal value
when the code will do the right thing anyway.
* src/split.c (set_suffix_length, bytes_split, lines_split)
(line_bytes_split, lines_chunk_split, bytes_chunk_extract)
(lines_rr, parse_chunk, main):
Prefer a signed type (typically intmax_t) to uintmax_t.
(strtoint_die): New function.
(OVERFLOW_OK): New macro. Use it elsewhere, where we now allow
LONGINT_OVERFLOW because the code then does the right thing on all
practical platforms (they have int wide enough so that it cannot
be practically exhausted). We can do this now that we can safely
assume intmax_t has at least 64 bits.
(parse_n_units): New function.
(parse_chunk, main): Use it.
(main): Do not worry about integer overflow when the code
will do the right thing anyway with the extreme value.
Just use the extreme value.
* tests/split/fail.sh: Adjust to match new behavior.
split: port ‘split -n N /dev/null’ better to macOS2023-03-04T22:49:45ZPaul Eggerteggert@cs.ucla.edu2023-03-04T19:42:16Zurn:sha1:aa266f1b3dc4e12acdc46cc0f562adc03c2c0b8f
* src/split.c (input_file_size): Do not bother with lseek if the
initial read probe reaches EOF, since the file size is known then.
This works better on macOS, which doesn’t allow lseek on /dev/null.
Do not special-case size-zero files, as the issue can occur
with any size file (though /proc files are the most common).
If the current position is past end of file, treat this as
size zero regardless of whether the file has a usable st_size.
Pass through lseek -1 return values rather than using ‘return -1’;
this makes the code a bit easier to analyze (and a bit faster).
Avoid undefined behavior if the size calculation overflows.
(lines_chunk_split): Do not bother with lseek if it would have
no effect if successful. This works better on macOS, which
doesn’t allow lseek on /dev/null.
* tests/split/l-chunk.sh: Adjust to match fixed behavior.
split: split more evenly with -n2023-03-04T22:49:45ZPaul Eggerteggert@cs.ucla.edu2023-03-04T19:41:03Zurn:sha1:fb6fc7f3ce6b0b70a5df7f605e71c4f8541e256b
* src/split.c (bytes_split): New arg REM_BYTES.
Use this to split more evenly. All callers changed.
(lines_chunk_split, bytes_chunk_extract):
Be consistent with new byte_split.
* tests/split/b-chunk.sh, tests/split/l-chunk.sh: Test new behavior.
maint: update all copyright year number ranges2023-01-01T14:50:15ZPádraig BradyP@draigBrady.com2023-01-01T14:50:15Zurn:sha1:01755d36e7389aef48f712193976205e7381115b
Update to latest gnulib with new copyright year.
Run "make update-copyright" and then...
* tests/init.sh: Sync with gnulib to pick up copyright year.
* bootstrap: Manually update copyright year,
until we fully sync with gnulib at a later stage.
* tests/sample-test: Adjust to use the single most recent year.
maint: update all copyright year number ranges2022-01-02T16:15:55ZPádraig BradyP@draigBrady.com2022-01-02T15:42:45Zurn:sha1:3067a9293af07ba2cf1ababe6b4482196717f806
Run "make update-copyright" and then...
* gnulib: Update to latest with copyright year adjusted.
* tests/init.sh: Sync with gnulib to pick up copyright year.
* bootstrap: Likewise.
* tests/sample-test: Adjust to use the single most recent year.
split: fix --number=K/N to output correct part of file2021-01-25T21:39:09ZPádraig BradyP@draigBrady.com2021-01-25T14:12:48Zurn:sha1:bb21daa125aeb4e32546309d370918ca47e612db
This functionality regressed with the adjustments
in commit v8.25-4-g62e7af032
* src/split.c (bytes_chunk_extract): Account for already read data
when seeking into the file.
* tests/split/b-chunk.sh: Use the hidden ---io-blksize option,
to test this functionality.
* NEWS: Mention the bug fix.
Fixes https://bugs.gnu.org/46048
maint: update all copyright year number ranges2021-01-01T16:36:09ZPádraig BradyP@draigBrady.com2021-01-01T16:36:09Zurn:sha1:32ff1d1313ff566685b9092ac929251a4c22e7c4
Run "make update-copyright" and then...
* gnulib: Update to latest with copyright year adjusted.
* tests/init.sh: Sync with gnulib to pick up copyright year.
* bootstrap: Likewise.
* tests/sample-test: Adjust to use the single most recent year.
maint: update all copyright year number ranges2020-01-01T14:16:56ZPádraig BradyP@draigBrady.com2020-01-01T14:16:56Zurn:sha1:aaba82431ceca97441d56152d8c7ec2d84fa1d12
Run "make update-copyright" and then...
* gnulib: Update to latest with copyright year adjusted.
* tests/init.sh: Sync with gnulib to pick up copyright year.
* bootstrap: Likewise.
* tests/sample-test: Adjust to use the single most recent year.
split: fix failure for certain number of specified files2019-06-08T21:58:01ZPádraig BradyP@draigBrady.com2019-06-08T21:49:01Zurn:sha1:738a746d825aff96821da535e36b0f60e7a65946
* src/split.c (set_suffix_length): Use a more standard
zero based logN calculation for the number of units.
* tests/split/suffix-auto-length.sh: Add a test case.
* THANKS.in: Mention the reporter.
* NEWS: Mention the fix.
Fixes https://bugs.gnu.org/35291