coreutils/tests/split, branch v9.5Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/
https://git.shady.money/coreutils/atom?h=v9.52024-01-18T16:52:36Zdoc: split -C: test and document a heap overflow2024-01-18T16:52:36ZPádraig BradyP@draigBrady.com2024-01-18T00:05:18Zurn:sha1:c01ee1893448bdf1bbd81fa15a35472d07a356b8
This was introduced in coreutils 9.2 through commit v9.1-184-g40bf1591b,
and was fixed in coreutils 9.5 through commit v9.4-111-gc4c5ed8f4.
This issue has been assigned CVE-2024-0684.
* NEWS: Mention the bug fix.
* tests/split/line-bytes.sh: Add a test case.
Reported by Valentin Metz.
tests: make ulimit -v interact better with ASAN2024-01-17T23:59:49ZPádraig BradyP@draigBrady.com2024-01-17T23:49:52Zurn:sha1:aa50ea55ea68aa5f5475bf46357bcf5febcde1bb
ulimit -v is generally not supported with ASAN, giving errors like:
"ReserveShadowMemoryRange failed while trying to map 0x... bytes.
Perhaps you're using ulimit -v"
* tests/cp/link-heap.sh: Mention ASAN as a possible reason for skipping.
* tests/csplit/csplit-heap.sh: Likewise.
* tests/cut/cut-huge-range.sh: Likewise.
* tests/dd/no-allocate.sh: Likewise.
* tests/printf/printf-surprise.sh: Likewise.
* tests/rm/many-dir-entries-vs-OOM.sh: Likewise.
* tests/head/head-c.sh: Only skip the part of the test needing ulimit.
* tests/split/line-bytes.sh: Likewise.
maint: update all copyright year number ranges2024-01-01T13:27:23ZPádraig BradyP@draigBrady.com2024-01-01T13:22:42Zurn:sha1:a966dcdb69e2f49f2587e1b7d4ade7efcff29f40
Update to latest gnulib with new copyright year.
Run "make update-copyright" and then...
* gnulib: Update included in this commit as copyright years
are the only change from the previous gnulib commit.
* tests/init.sh: Sync with gnulib to pick up copyright year.
* bootstrap: Manually update copyright year,
until we fully sync with gnulib at a later stage.
* tests/sample-test: Adjust to use the single most recent year.
maint: comment spelling fix2023-08-19T15:45:17ZPádraig BradyP@draigBrady.com2023-08-19T15:45:17Zurn:sha1:27c76b83b44e0d6660dbe46ac86db43a0cecb59c
* tests/split/l-chunk-root.sh: Fix recently introduced typo.
tests: split: provide more isolated /tmp handling2023-07-18T22:11:24ZPádraig BradyP@draigBrady.com2023-07-18T11:40:57Zurn:sha1:8fd50b86729a7f848c25b62086fcaf5332b5c2f0
* tests/split/l-chunk.sh: Move the "expensive" portion to ...
* tests/split/l-chunk-root.sh: .. A new test split from l-chunk.sh
which uses an isolated TMPDIR, rather than exhausting /tmp,
as that gives false positive failures with some other coreutils tests
like tac-2-nonseekable.sh and shuf-reservoir.sh at least.
* tests/local.mk: Reference the new test.
split: --additional-suffix: disallow trailing '/'2023-05-31T16:26:13ZPádraig BradyP@draigBrady.com2023-05-28T14:17:46Zurn:sha1:0147288d20169113cdc7075c787c4dbb8c67187c
Note mktemp --suffix has the same inconsistency,
but mktemp -d does support creating dirs
so probably best to leave that as is.
* src/split.c (main): Check for trailing /.
* tests/split/additional-suffix.sh: Augment the test.
Reported in https://bugs.debian.org/1036827
tests: provide more info on DEBUG=yes2023-05-02T21:39:03ZPádraig BradyP@draigBrady.com2023-05-02T21:39:03Zurn:sha1:7223651ad194a5868b58c1be6c7452fd3ca2f75a
* README: State that DEBUG=yes is particularly useful with perl tests.
* tests/split/l-chunk.sh: Use the more standard $DEBUG variable
rather than an internal $DEBUGGING variable.
tests: more cases for read input diagnostics2023-04-26T15:20:50ZPádraig BradyP@draigBrady.com2023-04-26T15:20:50Zurn:sha1:5e1c5f2d71eb99bc3c73619eeb0b79c3d36b5a3b
* tests/misc/read-errors.sh: Exercise more modes of
various utilities for better read error coverage.
* tests/split/fail.sh: Remove part refactored into the above test.
split: support split -n on larger pipe input2023-03-07T21:41:46ZPaul Eggerteggert@cs.ucla.edu2023-03-07T20:58:12Zurn:sha1:bb9dbcbbfd5c3159f975f39336a33319c6c5df04
* bootstrap.conf (gnulib_modules): Add free-posix, tmpfile.
* src/split.c (copy_to_tmpfile): New function.
(input_file_size): Use it to split larger files when sizes cannot
easily be determined via fstat or lseek. See Bug#61386#235.
* tests/split/l-chunk.sh: Mark tests of /dev/zero as
very expensive since they exhaust /tmp.
split: handle large numbers better2023-03-04T22:49:46ZPaul Eggerteggert@cs.ucla.edu2023-03-04T19:42:16Zurn:sha1:3434cdcec18c918de992bc28b0e9f52b6f168d9b
Prefer signed types to uintmax_t, as this allows for better
runtime checking with gcc -fsanitize=undefined.
Also, when an integer overflows just use the maximal value
when the code will do the right thing anyway.
* src/split.c (set_suffix_length, bytes_split, lines_split)
(line_bytes_split, lines_chunk_split, bytes_chunk_extract)
(lines_rr, parse_chunk, main):
Prefer a signed type (typically intmax_t) to uintmax_t.
(strtoint_die): New function.
(OVERFLOW_OK): New macro. Use it elsewhere, where we now allow
LONGINT_OVERFLOW because the code then does the right thing on all
practical platforms (they have int wide enough so that it cannot
be practically exhausted). We can do this now that we can safely
assume intmax_t has at least 64 bits.
(parse_n_units): New function.
(parse_chunk, main): Use it.
(main): Do not worry about integer overflow when the code
will do the right thing anyway with the extreme value.
Just use the extreme value.
* tests/split/fail.sh: Adjust to match new behavior.