Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/ https://git.shady.money/coreutils/atom?h=master 2026-03-14T03:37:10Z 2026-03-14T03:37:10Z Collin Funk collin.funk1@gmail.com 2026-03-14T03:37:10Z urn:sha1:e644eea122462aa7fa98cbe9b8f93088074588a0 * src/timeout.c (main): Save the process ID before creating a child process. Check if the result of getppid is different than the saved process ID instead of checking if it is 1. * tests/timeout/init-parent.sh: New file. * tests/local.mk (all_tests): Add the new test. * NEWS: Mention the bug fix. Also mention that this change allows 'timeout' to work when reparented by a subreaper process instead of init. 2026-02-24T19:25:58Z Pádraig Brady P@draigBrady.com 2026-02-24T15:44:41Z urn:sha1:8fab3c6d30d812cd681e51221bae27930f62615a This avoids the test harness being terminated like: make[1]: *** [Makefile:24419: check-recursive] Hangup make[3]: *** [Makefile:24668: check-TESTS] Hangup make: *** [Makefile:24922: check] Hangup make[2]: *** [Makefile:24920: check-am] Hangup make[4]: *** [Makefile:24685: tests/misc/usage_vs_refs.log] Error 129 ... This happened sometimes when the tests were being run non interactively. For example when run like: setsid make TESTS="tests/timeout/timeout.sh \ tests/tail/overlay-headers.sh" SUBDIRS=. -j2 check Note the race window can be made bigger by adding a sleep after tail is stopped in overlay-headers.sh The race can trigger the kernel to induce its job control mechanism to prevent stuck processes. I.e. where it sends SIGHUP + SIGCONT to a process group when it determines that group may become orphaned, and there are stopped processes in that group. * tests/tail/overlay-headers.sh: Use setsid(1) to keep the stopped tail process in a separate process group, thus avoiding any kernel job control protection mechanism. * tests/timeout/timeout.sh: Use setsid(1) to avoid the kernel checking the main process group when sleep(1) is reparented. Fixes https://bugs.gnu.org/80477 2026-01-01T18:56:16Z Collin Funk collin.funk1@gmail.com 2026-01-01T18:56:16Z urn:sha1:73d3a49f45770c45808e4fdab35ae4fe248a3cd9 2025-12-03T03:16:23Z Collin Funk collin.funk1@gmail.com 2025-12-03T03:16:23Z urn:sha1:c00a0941881e36a71c999f50a51ac6d36b31558f POSIX.1-2024 added sig2str but leaves the behavior when called with signal 0 unspecified. FreeBSD 15.0 does not return the signal name EXIT like Gnulib's version causing a test failure. This fixes that and changes the behavior to print 0 instead of EXIT, to avoid confusion when the program does not exit. * NEWS: Mention the change. * src/timeout.c (cleanup): Use snprintf instead of sig2str if the signal is 0. * tests/timeout/timeout.sh: Updated the expected output. 2025-12-02T17:20:19Z Pádraig Brady P@draigBrady.com 2025-12-02T17:15:06Z urn:sha1:86061ddbbdb4194362ede72f9900297d8d31d051 * src/timeout.c (cleanup): Reset the default exit status to EXIT_TIMEDOUT, if we have in fact received an ALARM. Otherwise we would exit with status EXIT_CANCELED if there was an issue writing --verbose output for example. This also ensures a consistent exit status with ASAN enabled, as with ASAN stderr is not explicitly closed by gnulib's close_stdout handler. 2025-11-29T12:17:27Z Pádraig Brady P@draigBrady.com 2025-11-28T17:39:20Z urn:sha1:faa566372d54f12bc4d89b367e386fc38bf127cd Recently we've not built our kill command by default, so reduce test dependence on that. * tests/sort/sort-compress-proc.sh: `kill -l [exit_status]` is well supported, and is a POSIX requirement. * tests/timeout/timeout.sh: There were actually no kill invocations in this test at all. 2025-11-29T12:17:27Z Pádraig Brady P@draigBrady.com 2025-11-28T17:34:23Z urn:sha1:fc5c7b2e47fbe55034f4c8aa2f67caabcc5933dd * src/timeout.c (main): Use PR_SET_PDEATHSIG to ensure the child is terminated even if the parent terminates abnormally. * tests/timeout/timeout-group.sh: Add a case to ensure sending SIGKILL results in the termination of the monitored command. * NEWS: Mention the improvement. 2025-11-22T08:49:20Z Pádraig Brady P@draigBrady.com 2025-11-21T11:43:35Z urn:sha1:8c24619334114a2524c8f87dd831fa0912560555 This behavior was depended on in our trap_sigpipe_or_skip_ helper, and now that we're handling all terminating signals, we should consistently honor their ignored signal dispositions. * NEWS: Mention the change in behavior, especially in regard to shell background jobs. * src/timeout.c (sig_needs_handling): A new helper that return TRUE, for --signal, SIG_ALRM, or non ignored signals. (cleanup_install): Filter handled signals with the helper. (block_cleanup_and_chld): Likewise. * tests/timeout/timeout-group.sh: Adjust to use the now required `env --default-signal=...` wrapper to reset (auto) ignored signals. Also change the termination signal from SIGINT to SIGUSR1 to generalize the test signals not specially handled by the shell, and newly handled by timeout(1). * tests/timeout/timeout.sh: Add a test case for SIGPIPE to ensure the ignored signal disposition is honored. 2025-11-21T12:12:28Z Pádraig Brady P@draigBrady.com 2025-11-20T16:02:43Z urn:sha1:d0a51c614def6cf4f39fafe8ca7dcef925c4a503 * src/timeout.c (term_sig): A new global list of all signals whose default disposition is to terminate the process. (install_cleanup): Iterate over the TERM_SIG list, rather than installing the handler for a specific subset. (block_cleanup_and_chld): Likewise. * tests/timeout/timeout.sh: Add a test case for SIGPIPE. * NEWS: Mention the bug fix. 2025-04-05T10:37:58Z Pádraig Brady P@draigBrady.com 2025-04-05T10:27:32Z urn:sha1:4368d21fbddaf5397087210c49b398414e02c933 * .gitignore: Add /lib/fenv.h to ignore list. * tests/timeout/timeout-parameters.sh: Use a sleep length of 10s to be consistent with the pattern where we use this larger time when it does not slow down a test, but also provides protection against a hung test, and better avoidance of false failures due to races on very loaded systems. Also fix the setting of FAIL. * tests/timeout/timeout-large-parameters.sh: Remove duplicated test.