Mirror of https://https.git.savannah.gnu.org/git/coreutils.git/ https://git.shady.money/coreutils/atom?h=v8.7 2010-11-11T07:16:24Z 2010-11-11T07:16:24Z Paul Eggert eggert@cs.ucla.edu 2010-11-11T04:34:52Z urn:sha1:6568b173db1c98f39a53eadd9b09e0a0e5c11920 * doc/coreutils.texi (csplit invocation): Say that %d and %i are aliases for %u. * src/csplit.c (FLAG_THOUSANDS, FLAG_ALTERNATIVE): New constants. (get_format_flags): Now take char const * and int * and return size_t. It now stores info about the flags instead of merely scanning them. Also, it handles '0' correctly. Drop support for the undocumented '+' and ' ' flags since the value is unsigned. Add support for the (undocumented) "'" flag. All uses changed. (get_format_width, get_format_prec): Remove. (check_format_conv_type): Renamed from get_format_conv_type, with a different signature. It now converts the format to one that is compatible with unsigned int, and checks flags. All uses changed. (max_out): Have snprintf compute the number of bytes needed rather than attempting to do it ourselves (which doesn't work portably with outlandish formats such as %4294967296d). (check_format_conv_type, main): Check for overflow in size calculations. Don't assume size_t fits in unsigned int. * tests/misc/csplit: Check for proper handling of flags, with %0#6.3x. Coreutils 8.6 mishandles this somewhat-weird example. 2010-11-11T01:40:12Z Pádraig Brady P@draigBrady.com 2010-11-10T14:35:17Z urn:sha1:0339eb4598600024cedca14a7e882c1737dd2d82 * src/csplit.c (free_buffer): Also free the line offsets buffers (remove_line): Also free the containing structure * tests/misc/csplit-heap: A new test to trigger with leaks of this magnitude. * tests/Makefile.am: Reference the new test * NEWS: Mention the fix Reported by David Hofstee 2010-11-10T21:08:05Z Jim Meyering meyering@redhat.com 2010-11-10T20:54:57Z urn:sha1:7727908335ef1049deac42851026ed8bf5ae2734 * tests/misc/csplit-1000: Fix comments and --version invocation. 2010-11-10T13:28:03Z Jim Meyering meyering@redhat.com 2010-11-10T12:53:38Z urn:sha1:0cfd4f2161de5e942cbd7c273d03a90c1dfd2062 Without this fix, seq 1000 | csplit - /./ '{*}' would write the NUL-terminated file name, xx1000, into a buffer of size 6. * src/csplit.c (main): Use properly sized file name buffer. * NEWS (Bug fixes): Mention it. * tests/misc/csplit-1000: New test to trigger the bug. * tests/Makefile.am (TESTS): Add misc/csplit-1000. 2010-11-09T12:43:20Z Pádraig Brady P@draigBrady.com 2010-11-09T12:43:20Z urn:sha1:425503c8073a17df5ace9bb9330ce283804b07e1 * tests/mv/i-3: Adjust so that the symlink is resolved before redirecting to the background command, as otherwise the stdin descriptor passed to the command will fail the isatty() or ttyname() test. 2010-11-08T10:26:08Z Pádraig Brady P@draigBrady.com 2010-11-08T10:26:08Z urn:sha1:4a14a80bd1a88dde4e361aa259264a54c4ffa3ea * tests/init.cfg (retry_delay_): Adjust awk script to print a single floating point value, rather than many. 2010-11-07T20:08:37Z Jim Meyering meyering@redhat.com 2010-11-07T13:23:32Z urn:sha1:dd45755406861fc192284d7e2b28f3c33e0433d3 because dash-0.5.6-2.fc14.x86_64 would also be disqualified. This reverts part of yesterday's commit 6c058b2d, "tests: avoid failure due to bug in FreeBSD 8.1's /bin/sh". Note that the offending aspect of those shells is not officially a bug, since "local" is not specified by POSIX. However, it is very unintuitive that prepending "local" to an existing, standards-compliant assignment would evoke such a fundamental change in semantics. * tests/init.sh: Remove snippet requiring sane "local" support. Upstream dash bug report: http://thread.gmane.org/gmane.comp.shells.dash/419 2010-11-07T01:09:44Z Paul Eggert eggert@cs.ucla.edu 2010-11-06T20:57:08Z urn:sha1:ca9aa7596094c4af094edb7eb63648570d53c100 * src/stat.c (digits, printf_flags): New static vars. (make_format): New function. (out_string, out_int, out_uint, out_uint_o, out_uint_x): (out_minus_zero): Use it to avoid undefined behavior when invoking printf. (print_it): Check for invalid conversion specifications such as %..X and %1-X, which would otherwise rely on undefined behavior when invoking printf. * tests/misc/stat-nanoseconds: Check that the "I" printf flag doesn't mess up in the C locale, as it formerly did on non-GNU hosts. 2010-11-06T14:24:53Z Jim Meyering meyering@redhat.com 2010-11-06T14:20:06Z urn:sha1:6c058b2dabe2e577d56e8c2c82cec550ff82f085 * tests/init.sh: Arrange not to accept FreeBSD 8.1's /bin/sh, since it fails this test: /bin/sh -c 'f(){ local s=$IFS; test -n "$s"; }; f' * tests/init.cfg (sanitize_path_): Stop-gap measure to work around a bug in FreeBSD 8.1's /bin/sh. We'll un-do this change once all 300+ tests use init.sh. 2010-11-06T14:24:49Z Paul Eggert eggert@cs.ucla.edu 2010-11-06T02:35:12Z urn:sha1:c7375c236ca5fa23661388e9f9c41e8312eb0cce * NEWS: Document this. * doc/coreutils.texi (stat invocation): Likewise. * gl/lib/fstimeprec.c, gl/lib/fstimeprec.h, gl/modules/fstimeprec: * gl/modules/fstimeprec-tests, gl/tests/test-fstimeprec.c: New files. * bootstrap.conf (gnulib_modules): Add fstimeprec. * src/stat.c: Include fstimeprec.h. Don't include xstrtol.h. (decimal_point, decimal_point_len): New static vars. (main): Initialize them. (epoch_sec, out_ns): Remove. (out_int, out_uint): Now returns whatever printf returned. (out_minus_zero, out_epoch_secs): New functions. (print_stat): Use out_epoch_sec instead of out_ns and epoch_sec. (print_stat, print_it, usage): Remove the %:X-style formats. * tests/misc/stat-nanoseconds: Set TZ=UTC0 to avoid problems with weird time zones. Use a time stamp near the Epoch so that we don't have to worry about leap seconds. Redo test cases to match new behavior. * tests/touch/60-seconds: Change %Y.%:Y to %.9Y, to adjust to new behavior.