aboutsummaryrefslogtreecommitdiffstats
path: root/scripts/git-hooks/commit-msg (unfollow)
AgeCommit message (Collapse)AuthorFilesLines
2011-11-02scripts: reject references to long-form bug URLsJim Meyering1-0/+6
* scripts/git-hooks/commit-msg: Require the normalized/shortened form of bugzilla.redhat.com and bugs.gnu.org bug URLs.
2011-11-01doc: date: mention that the hardware clock might not be setPádraig Brady1-6/+8
* doc/coreutils.texi (Setting the time): Reorganize slightly and mention that the hardware clock might need to be explicitly updated by the user as is the case on Fedora 16 currently. See http://bugzilla.redhat.com/749516
2011-11-01build: adapt to gnulib's recent openat/fchownat separationJim Meyering2-0/+1
* bootstrap.conf (gnulib_modules): Add fchownat, now that gnulib has moved it into its own module. * gnulib: Update to latest.
2011-10-30build: update gnulib for GNUmakefile fixJim Meyering1-0/+0
2011-10-30maint: avoid new "make syntax-check" failure due to stdalign definitionJim Meyering2-1/+2
* gl/modules/randread (Depends-on): Add stdalign. * gl/lib/randread.c: Include <stdalign.h>, so we can ... [!_STRING_ARCH_unaligned]: remove definition of stdalign.
2011-10-30tests: update gnulib to latest to avoid FP DST-related test failureJim Meyering1-0/+0
Otherwise, "make check" would fail after e.g., a CEST-to-CST daylight savings transition. See http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/28825
2011-10-30tests: doc: fix stale comment in new rm/many-dir-entries-vs-OOMJim Meyering1-1/+1
2011-10-29tests: don't make tail's pipe-f2 test take the full 10 secondsJim Meyering1-2/+13
* tests/tail-2/pipe-f2: Don't always wait 10 seconds. Before, this test would always wait 10 seconds. Now, it stops early when it detects that tail -f has written output. BTW, the race condition that prompted changing the timeout from 1 second to 10 was that tail -f could be killed by the timeout before producing any output.
2011-10-27date: reinstate the --iso-8601 (-I) optionJim Meyering2-1/+33
We deprecated and undocumented the --iso-8601 (-I) option mostly because date could not parse that particular format. Now that it can, it's time to restore the documentation. * src/date.c (usage): Document it. * doc/coreutils.texi (Options for date): Reinstate documentation. Reported by Hubert Depesz Lubaczewski in http://bugs.gnu.org/7444.
2011-10-27build: avoid bootstrap failure when using patch-2.5.8Jim Meyering1-5/+5
* gl/modules/tempname.diff: Regenerate to correct bogus offsets and adjust for 1-line offset. Eric Blake reported that this patch failed to apply when using patch-2.5.8. Note that it applies fine using patch-2.6.1.
2011-10-25build: do not remove definition of ENODATA, after allJim Meyering2-0/+8
* src/system.h (ENODATA): Restore definition. gnulib defines it only on native Windows systems, so removing our definition would have provoked build failure on systems that use it, like FreeBSD. Reported by Bruno Haible in http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/28739/focus=28795 * gnulib: Update to latest, to get new ENODATA-exempting maint.mk rule.
2011-10-24doc: NEWS: correct "bug introduced in ..." version numberEric Blake1-1/+1
* NEWS: s/7.0/8.0/
2011-10-24rm: update gnulib to get an fts fix for Cygwin+NWFS/NcFsd file systemsJim Meyering3-11/+4
* NEWS (Bug fixes): Mention it. As far as we know, this fix affects only Cygwin with NWFS or NcFsd file systems. See these: http://git.sv.gnu.org/cgit/gnulib.git/commit/?id=71f13422f3e634 http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/28739 http://cygwin.com/ml/cygwin/2011-10/msg00365.html * src/system.h (ENODATA): Remove fall-back definition, now that gnulib provides one. Caught by the sc_prohibit_always-defined_macros syntax-check rule. Also remove now-irrelevant "Don't use bcopy..." comment.
2011-10-23maint: add git hook scriptsJim Meyering4-4/+145
We find it worthwhile to use consistent commit summary prefixes. To that end, the commit-msg script requires that all commits I make start with "$P: " (where $P is one of ~100 programs in coreutils) or one of a few other words, like gnulib tests maint doc build. It allows more than one word, so e.g., "cat tail head: " would also be accepted. Pádraig Brady wrote the initial version, with its 72-column and blank-if-present second line checks. The pre-commit script is the same as the git-supplied sample script, modulo a bug fix and the "exec 1>&2" redirection. * scripts/git-hooks/commit-msg: New file. * scripts/git-hooks/pre-commit: New file. * scripts/git-hooks/applypatch-msg: New file. Verbatim from .sample. * cfg.mk: Exempt two of the new scripts from the no-leading-TABs check, since they're nearly verbatim from git, and we want to stay in sync. Exempt the commit-msg script from the no-"fail=0" check.
2011-10-21tail: with -f, use nanosleep (not inotify) on a GPFS file systemMartial Bornet2-0/+5
Because tail's fremote function did not designate GPFS as a remote file system type, tail -f would mistakenly attempt to use inotify, which cannot work with a remote file system. * src/tail.c (fremote): List GPFS as a remote file system type. * NEWS (Bug fixes): Mention it. Reported in http://bugs.debian.org/646022.
2011-10-20build: include man-pages for non-default progsMike Frysinger1-1/+2
At the moment, things like man/arch.1 are not included in the tarball. This makes perl a requirement if you want to build/install the arch helper. * man/Makefile.am (EXTRA_DIST): Add $(NO_INSTALL_PROGS_DEFAULT:%=%.1).
2011-10-19maint: tac: prefer "failed to" diagnostic over "cannot"Jim Meyering2-4/+6
* src/tac.c: Change wording in diagnostic: "failed to open" seems clearer than "cannot open".
2011-10-19tac: do not let failed allocation cause immediate exitJim Meyering1-1/+6
* src/tac.c (temp_stream): Don't exit immediately upon failed heap allocation, here. That would inhibit processing of any additional command-line arguments.
2011-10-19tac: use only one temporary file, with multiple nonseekable inputsJim Meyering2-49/+72
* src/tac.c (temp_stream): New function, factored out of... (copy_to_temp): ...here. (tac_nonseekable): Don't free or fclose, now that we reuse the file. Suggested by Ambrose Feinstein. * THANKS.in: Update.
2011-10-18maint: make tac.c slightly cleanerPaul Eggert1-6/+3
* src/tac.c (copy_to_temp): Now that the template string tacXXXXXX is used in only one place, don't bother using a separate variable. Also, using three unconditional assignments seems slightly clearer.
2011-10-17tac: don't leak a file descriptor for each non-seekable inputJim Meyering1-9/+6
* src/tac.c (tac_nonseekable): Call fclose and free tmp_file after each successful call to copy_to_temp.
2011-10-17tac: don't misbehave with multiple non-seekable inputsJim Meyering4-4/+48
* src/tac.c (copy_to_temp): Do not reuse the template buffer. Instead, scribble only on a freshly-xstrdup'd copy each time. Free that buffer both here, upon failure, and ... (tac_nonseekable): ...free the buffer in caller, upon success. * tests/misc/tac-2-nonseekable: New file. * tests/Makefile.am (TESTS): Add it. * NEWS (Bug fixes): Mention it. Reported by Ambrose Feinstein in http://debbugs.gnu.org/9762.
2011-10-17maint: tac: remove sole use of sprintf in favor of filenamecatJim Meyering1-10/+6
* src/tac.c: Include filenamecat.h. (copy_to_temp): Use filenamecat rather than xmalloc and sprintf. Move some declarations "down" to point of initialization.
2011-10-17maint: speed up make check (vc_exe_in_TESTS)Pádraig Brady1-14/+10
* tests/check.mk (vc_exe_in_TESTS): The main change is to not start a sed process for each file under tests/, which was taking around 2.5s on a 2.1GHz i3-2310M. Also adjust the rule to no longer use temporary files.
2011-10-12maint: post-release administriviaJim Meyering3-2/+5
* NEWS: Add header line for next release. * .prev-version: Record previous version. * cfg.mk (old_NEWS_hash): Auto-update.
2011-10-12version 8.14v8.14Jim Meyering1-1/+1
* NEWS: Record release date.
2011-10-12tests: avoid a false failure on systems without inotifyPádraig Brady1-0/+4
* tests/tail-2/follow-name: Exclude the inotify warning from the comparison. Reported by Bruno Haible.
2011-10-09build: update gnulib to latest to fix MacOS X 10.5 test link failureJim Meyering1-0/+0
Details here: http://thread.gmane.org/gmane.comp.gnu.coreutils.general/1726/focus=1743
2011-10-09rm: do not resort to stat'ing very long names even on deficient systemsJim Meyering6-184/+5
This change affects only systems that have neither *at function support nor the /proc/self/fd support required to emulate those *at functions. * src/remove.c (write_protected_non_symlink): Call faccessat unconditionally. Thus we no longer need euidaccess_stat, which was the sole function used here to operate on a full relative file name. Remove full_name parameter and update caller. * lib/euidaccess-stat.h: Remove file. * lib/euidaccess-stat.c: Likewise. * m4/euidaccess-stat.m4: Likewise. * po/POTFILES.in: Remove lib/euidaccess-stat.c. * m4/prereq.m4 (gl_PREREQ): Don't require gl_EUIDACCESS_STAT. Prompted by a report from Bruno Haible that the rm/deep-2 test was failing on HP-UX 11.31. See http://thread.gmane.org/gmane.comp.gnu.coreutils.general/1748
2011-10-09tests: skip rather than failing when perl is not availableJim Meyering2-1/+3
* tests/df/total-verify: Use require_perl_, so that this test is skipped when perl is not available. * tests/rm/deep-2: Likewise, and fix wording in a comment. Reported by Bruno Haible.
2011-10-08tests: avoid tail-2/F-vs-missing failure on NFSJim Meyering1-0/+15
* tests/tail-2/F-vs-missing: This test would fail about 80% of the time on linux/powerpc when run in an NFS-mounted directory. Reported by Bruno Haible in http://thread.gmane.org/gmane.comp.gnu.coreutils.general/1726/focus=1727
2011-10-08tests: avoid ls/slink-acl test failure on Solaris 10Jim Meyering1-1/+1
* tests/ls/slink-acl: Use setfacl's "-m user::r" option rather than less-portable "-m m::r". The latter did not work with Solaris 10's version of setfacl. Reported by Bruno Haible in http://thread.gmane.org/gmane.comp.gnu.coreutils.general/1726/focus=1737
2011-10-08tests: avoid false-positive failures on linux/sparc64Jim Meyering1-0/+9
* tests/init.cfg (require_strace_): Detect a version of strace that fails on linux/sparc64 for 64-bit executables. Report and most of the suggested fix from Bruno Haible: http://thread.gmane.org/gmane.comp.gnu.coreutils.general/1726/focus=1728
2011-10-06build: let bootstrap resort to wget for downloading .po filesBernhard Voelker1-0/+8
* bootstrap (download_po_files): Fallback to wget when downloading the .po files via rsync failed. This is necessary to bootstrap behind a strict firewall.
2011-10-05doc: clean up NEWSJim Meyering1-4/+5
* NEWS: Mention when the sort -g infloop bug was introduced and alphabetize entries. Clarify a sentence in the pwd-improvement entry.
2011-10-05tests: add a test to exercise today's ls-lL-vs-ACL bugJim Meyering5-0/+43
* tests/ls/slink-acl: New file. * tests/Makefile.am (TESTS): Add it. * tests/init.cfg (require_setfacl_): New function. * gnulib: Update to latest, for file-has-acl changes. * NEWS (Bug fixes): Mention it. See http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/28538. This ":>k; setfacl -m m::r k; ln -s k s; ls -Log s" should print e.g., -rw-r-----+ 1 0 Oct 5 19:22 s With the ls from coreutils-8.13, it would print this (with "." or nothing in place of the "+"): -rw-r-----. 1 0 Oct 5 19:22 s
2011-10-03build: don't use automake's obsolete AM_C_PROTOTYPES macroJim Meyering1-5/+0
* m4/jm-macros.m4 (gl_CHECK_ALL_TYPES): Remove use of AM_C_PROTOTYPES, now that automake rejects it.
2011-10-01maint: clean up m4 syntaxJim Meyering1-27/+27
* m4/jm-macros.m4 (coreutils_MACROS, gl_CHECK_ALL_HEADERS): Remove unnecessary backslashes and add quotes around multi-line argument lists.
2011-10-01build: use getgr*_nomembers functions on InterixMarkus Duft2-0/+28
Interix provides faster replacements for getgr{gid,nam,ent} where group member information is not fetched from domain controllers. This makes 'id' usable on domain controlled interix boxes. * m4/jm-macros.m4: Check for _nomembers functions. * src/system.h: Redefine function to _nomembers when available.
2011-10-01build: accommodate missing setgroups on InterixMarkus Duft1-0/+11
Add a dummy, non-functional, always-successful replacement setgroups function, to keep the original code untouched and simple. * src/chroot.c (setgroups) [! HAVE_SETGROUPS]: Define.
2011-10-01build: stop distributing gzip'd releases; xz is enoughJim Meyering2-1/+7
* configure.ac (AM_INIT_AUTOMAKE): Add no-dist-gzip. * NEWS (Build-related): Mention that we're dropping .tar.gz.
2011-10-01build: update gnulib submodule to latestJim Meyering1-0/+0
2011-10-01doc: mention the recent ls -L "argetm" fix in NEWSPádraig Brady1-0/+4
* NEWS: Mention the bug fix
2011-10-01ls: fix output of dangling symlinks colored as targetPádraig Brady2-4/+50
This is related to commit b7f2b51c, 2010-01-01, "ls: fix color of broken symlinks colored as target" which didn't handle the --dereference case. The simplest way to reproduce the resultant erroneous "argetm" is as follows: $ ln -s /no-such dangle $ env LS_COLORS=ln=target ls --dereference --color ls: cannot access dangle: No such file or directory argetmdangle This is also an issue with the `tree` utility, reported here: http://bugs.debian.org/586765 * src/ls.c (print_color_indicator): Move the handling of 'ln=target' in $LS_COLORS (color_symlink_as_referent == true) to a higher scope, to handle all cases where type == C_LINK. * tests/misc/ls-misc: Add a test case for the specific issue, and 2 further test cases to verify other code paths in this area. Reported by Jason Glassey.
2011-09-30ls: avoid reading beyond end of color indicatorJim Meyering2-2/+2
At first this looked like a buffer overrun, since there was no test to ensure that the buffer length was 6. However, since the LS_COLORS string is NUL-terminated and since settings within it are separated by ":" there was neither the risk of reading beyond end of buffer nor risk of a false-positive match. * src/ls.c (print_color_indicator): Use color_symlink_as_referent rather than manually comparing against "target" again. * src/system.h (STRNCMP_LIT): Correct description in comment.
2011-09-28tests: update gnulib to latest, to fix test link failureJim Meyering1-0/+0
2011-09-27sort: avoid a NaN-induced infloopJim Meyering4-1/+52
These commands would fail to terminate: yes -- -nan | head -156903 | sort -g > /dev/null echo nan > F; sort -m -g F F That can happen with any strtold implementation that includes uninitialized data in its return value. The problem arises in the mergefps function when bubble-sorting the two or more lines, each from one of the input streams being merged: compare(a,b) returns 64, yet compare(b,a) also returns a positive value. With a broken comparison function like that, the bubble sort never terminates. Why do the long-double bit strings corresponding to two identical "nan" strings not compare equal? Because some parts of the result are uninitialized and thus depend on the state of the stack. For more details, see http://bugs.gnu.org/9612. * src/sort.c (nan_compare): New function. (general_numcompare): Use it rather than bare memcmp. Reported by Aaron Denney in http://bugs.debian.org/642557. * NEWS (Bug fixes): Mention it. * tests/misc/sort-NaN-infloop: New file. * tests/Makefile.am (TESTS): Add it.
2011-09-24build: update gnulib submodule to latestJim Meyering1-0/+0
2011-09-24maint: avoid new syntax-check failureJim Meyering1-1/+2
Pulling in the latest gnulib triggered a new false-positive syntax-check failure. * cfg.mk (exclude_file_name_regexp--sc_prohibit_always-defined_macros): Exempt remove.c; its definitions of DT_UNKNOWN, DT_DIR and DT_LNK are harmless.
2011-09-24tests: mention new check-expensive/check-very-expensive in test logsBernhard Voelker1-0/+8
* tests/init.cfg: (very_expensive_): Mention toplevel make target, check-very-expensive. (expensive_): Likewise for check-expensive.