<feed xmlns='http://www.w3.org/2005/Atom'>
<title>git, branch v2.43.3</title>
<subtitle>Mirror of https://git.kernel.org/pub/scm/git/git.git/
</subtitle>
<id>https://git.shady.money/git/atom?h=v2.43.3</id>
<link rel='self' href='https://git.shady.money/git/atom?h=v2.43.3'/>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/'/>
<updated>2024-02-23T00:13:38Z</updated>
<entry>
<title>Git 2.43.3</title>
<updated>2024-02-23T00:13:38Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-23T00:13:38Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=0d464a4e6a5a19bd8fbea1deae22d48d14dccb01'/>
<id>urn:sha1:0d464a4e6a5a19bd8fbea1deae22d48d14dccb01</id>
<content type='text'>
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
</entry>
<entry>
<title>Merge branch 'la/trailer-cleanups' into maint-2.43</title>
<updated>2024-02-23T00:09:45Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-23T00:09:45Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=5dc73662976e81de19a5b3a76f4733962f541df5'/>
<id>urn:sha1:5dc73662976e81de19a5b3a76f4733962f541df5</id>
<content type='text'>
* la/trailer-cleanups:
  trailer: fix comment/cut-line regression with opts-&gt;no_divider
</content>
</entry>
<entry>
<title>trailer: fix comment/cut-line regression with opts-&gt;no_divider</title>
<updated>2024-02-20T03:06:18Z</updated>
<author>
<name>Jeff King</name>
<email>peff@peff.net</email>
</author>
<published>2024-02-20T01:09:36Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=bc47139f4ff6c0c41d4c854ca74c35b1006a464a'/>
<id>urn:sha1:bc47139f4ff6c0c41d4c854ca74c35b1006a464a</id>
<content type='text'>
Commit 97e9d0b78a (trailer: find the end of the log message, 2023-10-20)
combined two code paths for finding the end of the log message. For the
"no_divider" case, we used to use find_trailer_end(), and that has now
been rolled into find_end_of_log_message(). But there's a regression;
that function returns early when no_divider is set, returning the whole
string.

That's not how find_trailer_end() behaved. Although it did skip the
"---" processing (which is what "no_divider" is meant to do), we should
still respect ignored_log_message_bytes(), which covers things like
comments, "commit -v" cut lines, and so on.

The bug is actually in the interpret-trailers command, but the obvious
way to experience it is by running "commit -v" with a "--trailer"
option. The new trailer will be added at the end of the verbose diff,
rather than before it (and consequently will be ignored entirely, since
everything after the diff's intro scissors line is thrown away).

I've added two tests here: one for interpret-trailers directly, which
shows the bug via the parsing routines, and one for "commit -v".

The fix itself is pretty simple: instead of returning early, no_divider
just skips the "---" handling but still calls ignored_log_message_bytes().

Reported-by: Philippe Blain &lt;levraiphilippeblain@gmail.com&gt;
Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
</entry>
<entry>
<title>Git 2.43.2</title>
<updated>2024-02-13T22:44:51Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-13T22:44:20Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=efb050becb6bc703f76382e1f1b6273100e6ace3'/>
<id>urn:sha1:efb050becb6bc703f76382e1f1b6273100e6ace3</id>
<content type='text'>
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
</content>
</entry>
<entry>
<title>Merge branch 'pb/template-for-single-commit-pr' into maint-2.43</title>
<updated>2024-02-13T22:44:51Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-13T22:44:51Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=dc55772259bdda60b33828cb99831af4d0479bfa'/>
<id>urn:sha1:dc55772259bdda60b33828cb99831af4d0479bfa</id>
<content type='text'>
Doc update.

* pb/template-for-single-commit-pr:
  .github/PULL_REQUEST_TEMPLATE.md: add a note about single-commit PRs
</content>
</entry>
<entry>
<title>Merge branch 'jc/bisect-doc' into maint-2.43</title>
<updated>2024-02-13T22:44:51Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-13T22:44:51Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=1e73351fefbe7b414e8937e891e31d18c4c46fa1'/>
<id>urn:sha1:1e73351fefbe7b414e8937e891e31d18c4c46fa1</id>
<content type='text'>
Doc update.

* jc/bisect-doc:
  bisect: document command line arguments for "bisect start"
  bisect: document "terms" subcommand more fully
</content>
</entry>
<entry>
<title>Merge branch 'js/win32-retry-pipe-write-on-enospc' into maint-2.43</title>
<updated>2024-02-13T22:44:51Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-13T22:44:51Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=8d792dcd5aa8a412670bd12f07cdc8290e3b9a68'/>
<id>urn:sha1:8d792dcd5aa8a412670bd12f07cdc8290e3b9a68</id>
<content type='text'>
Update to the code that writes to pipes on Windows.

* js/win32-retry-pipe-write-on-enospc:
  win32: special-case `ENOSPC` when writing to a pipe
</content>
</entry>
<entry>
<title>Merge branch 'tb/pack-bitmap-drop-unused-struct-member' into maint-2.43</title>
<updated>2024-02-13T22:44:51Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-13T22:44:50Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=08b7e46bb1a6d02b906efce9a52fc29f0d8e1bce'/>
<id>urn:sha1:08b7e46bb1a6d02b906efce9a52fc29f0d8e1bce</id>
<content type='text'>
Code clean-up.

* tb/pack-bitmap-drop-unused-struct-member:
  pack-bitmap: drop unused `reuse_objects`
</content>
</entry>
<entry>
<title>Merge branch 'jt/p4-spell-re-with-raw-string' into maint-2.43</title>
<updated>2024-02-13T22:44:50Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-13T22:44:50Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=8f1c4a7db1bb9aff15573b152a2e08aeb75cd012'/>
<id>urn:sha1:8f1c4a7db1bb9aff15573b152a2e08aeb75cd012</id>
<content type='text'>
"git p4" update to squelch warnings from Python.

* jt/p4-spell-re-with-raw-string:
  git-p4: use raw string literals for regular expressions
</content>
</entry>
<entry>
<title>Merge branch 'jc/coc-whitespace-fix' into maint-2.43</title>
<updated>2024-02-13T22:44:50Z</updated>
<author>
<name>Junio C Hamano</name>
<email>gitster@pobox.com</email>
</author>
<published>2024-02-13T22:44:50Z</published>
<link rel='alternate' type='text/html' href='https://git.shady.money/git/commit/?id=b6fdf929ee4c6fd4b3ab9dd003fd0ee32d82f5e6'/>
<id>urn:sha1:b6fdf929ee4c6fd4b3ab9dd003fd0ee32d82f5e6</id>
<content type='text'>
Docfix.

* jc/coc-whitespace-fix:
  CoC: whitespace fix
</content>
</entry>
</feed>
