git/Documentation/CodingGuidelines, branch v2.30.2

Merge branch 'dl/python-2.7-is-the-floor-version'

2020-06-18T04:54:05Z

Document that we do not support Python 2.6 or older. * dl/python-2.7-is-the-floor-version: CodingGuidelines: specify Python 2.7 is the oldest version

CodingGuidelines: specify Python 2.7 is the oldest version

2020-06-08T17:32:42Z

In 0b4396f068 (git-p4: make python2.7 the oldest supported version, 2019-12-13), git-p4 was updated to only support 2.7 and newer. Since Python 2.6 is pretty much ancient history, update CodingGuidelines to show that 2.7 is the oldest version supported. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano

Merge branch 'jc/codingstyle-compare-with-null'

2020-05-14T21:39:42Z

Doc update. * jc/codingstyle-compare-with-null: CodingGuidelines: do not ==/!= compare with 0 or '\0' or NULL

Merge branch 'jk/arith-expansion-coding-guidelines'

2020-05-08T21:25:07Z

The coding guideline for shell scripts instructed to refer to a variable with dollar-sign inside arithmetic expansion to work around a bug in old versions of dash, which is a thing of the past. Now we are not forbidden from writing $((var+1)). * jk/arith-expansion-coding-guidelines: CodingGuidelines: drop arithmetic expansion advice to use "$x"

CodingGuidelines: do not ==/!= compare with 0 or '\0' or NULL

2020-05-08T18:25:12Z

Signed-off-by: Junio C Hamano Signed-off-by: Eric Sunshine Signed-off-by: Junio C Hamano

CodingGuidelines: drop arithmetic expansion advice to use "$x"

2020-05-04T19:36:07Z

The advice to use "$x" rather than "x" in arithmetric expansion was working around a dash bug fixed in 0.5.4. Even Debian oldstable has 0.5.8 these days. And in the meantime, we've added almost two dozen instances of the "x" form which you can find with: git grep '$(([a-z]' and nobody seems to have complained. Let's declare this workaround obsolete and simplify our style guide. Helped-by: Danh Doan Signed-off-by: Jeff King Reviewed-by: Carlo Marcelo Arenas Belón Signed-off-by: Junio C Hamano

Merge branch 'jc/allow-strlen-substitution-in-shell-scripts'

2020-04-22T20:42:48Z

Coding guideline update. * jc/allow-strlen-substitution-in-shell-scripts: CodingGuidelines: allow ${#posix} == strlen($posix)

CodingGuidelines: allow ${#posix} == strlen($posix)

2020-03-29T15:41:54Z

The construct has been in POSIX for the past 10+ years, and we have used in t9xxx (subversion) series of the tests, so we know it is at portable across systems that people have run those tests, which is almost everything we'd care about. Let's loosen the rule; luckily, the check-non-portable-shell script does not have any rule to find its use, so the only change needed is a removal of one paragraph from the documentation. Helped-by: Jeff King Signed-off-by: Junio C Hamano

Documentation: fix a bunch of typos, both old and new

2019-11-07T04:42:00Z

Reported-by: Jens Schleusener Signed-off-by: Elijah Newren Signed-off-by: Junio C Hamano

Merge branch 'jc/post-c89-rules-doc'

2019-07-25T20:59:23Z

We have been trying out a few language features outside c89; the coding guidelines document did not talk about them and instead had a blanket ban against them. * jc/post-c89-rules-doc: CodingGuidelines: spell out post-C89 rules