git/Documentation/CodingGuidelines, branch v2.32.2

Merge branch 'jc/test-allows-local'

2021-05-11T06:27:22Z

Document that our test can use "local" keyword. * jc/test-allows-local: CodingGuidelines: explicitly allow "local" for test scripts

CodingGuidelines: explicitly allow "local" for test scripts

2021-05-03T05:24:11Z

01d3a526 (t0000: check whether the shell supports the "local" keyword, 2017-10-26) raised a test balloon to see if those who build and test Git use a platform with a shell that lacks support for the "local" keyword. After two years, 7f0b5908 (t0000: reword comments for "local" test, 2019-08-08) documented that "local" keyword, even though is outside POSIX, is allowed in our test scripts. Let's write it in the CodingGuidelines, too. It might be tempting to allow it in scripted Porcelains (we have avoided getting them contaminiated by "local" so far), but they are on their way out and getting rewritten in C. Signed-off-by: Junio C Hamano

doc: clarify "do not capitalize the first word" rule

2021-04-15T06:41:00Z

The same "do not capitalize the first word" rule is applied to both our patch titles and error messages, but the existing description was fuzzy in two aspects. * For error messages, it was not said that this was only about the first word that begins the sentence. * For both, it was not clear when a capital letter there was not an error. We avoid capitalizing the first word when the only reason you would capitalize it is because it happens to be the first word in the sentence. If a proper noun, which is usually spelled in capital letters, happens to come at the beginning of the sentence, it should be kept in capital letters. Signed-off-by: Junio C Hamano

Merge branch 'dl/python-2.7-is-the-floor-version'

2020-06-18T04:54:05Z

Document that we do not support Python 2.6 or older. * dl/python-2.7-is-the-floor-version: CodingGuidelines: specify Python 2.7 is the oldest version

CodingGuidelines: specify Python 2.7 is the oldest version

2020-06-08T17:32:42Z

In 0b4396f068 (git-p4: make python2.7 the oldest supported version, 2019-12-13), git-p4 was updated to only support 2.7 and newer. Since Python 2.6 is pretty much ancient history, update CodingGuidelines to show that 2.7 is the oldest version supported. Signed-off-by: Denton Liu Signed-off-by: Junio C Hamano

Merge branch 'jc/codingstyle-compare-with-null'

2020-05-14T21:39:42Z

Doc update. * jc/codingstyle-compare-with-null: CodingGuidelines: do not ==/!= compare with 0 or '\0' or NULL

Merge branch 'jk/arith-expansion-coding-guidelines'

2020-05-08T21:25:07Z

The coding guideline for shell scripts instructed to refer to a variable with dollar-sign inside arithmetic expansion to work around a bug in old versions of dash, which is a thing of the past. Now we are not forbidden from writing $((var+1)). * jk/arith-expansion-coding-guidelines: CodingGuidelines: drop arithmetic expansion advice to use "$x"

CodingGuidelines: do not ==/!= compare with 0 or '\0' or NULL

2020-05-08T18:25:12Z

Signed-off-by: Junio C Hamano Signed-off-by: Eric Sunshine Signed-off-by: Junio C Hamano

CodingGuidelines: drop arithmetic expansion advice to use "$x"

2020-05-04T19:36:07Z

The advice to use "$x" rather than "x" in arithmetric expansion was working around a dash bug fixed in 0.5.4. Even Debian oldstable has 0.5.8 these days. And in the meantime, we've added almost two dozen instances of the "x" form which you can find with: git grep '$(([a-z]' and nobody seems to have complained. Let's declare this workaround obsolete and simplify our style guide. Helped-by: Danh Doan Signed-off-by: Jeff King Reviewed-by: Carlo Marcelo Arenas Belón Signed-off-by: Junio C Hamano

Merge branch 'jc/allow-strlen-substitution-in-shell-scripts'

2020-04-22T20:42:48Z

Coding guideline update. * jc/allow-strlen-substitution-in-shell-scripts: CodingGuidelines: allow ${#posix} == strlen($posix)