git/blob.h, branch jch

blob: drop unused parts of parse_blob_buffer()

2022-12-13T13:16:22Z

Our parse_blob_buffer() takes a ptr/len combo, just like parse_tree_buffer(), etc, and returns success or failure. But it doesn't actually do anything with them; we just set the "parsed" flag in the object and return success, without even looking at the contents. There could be some value to keeping these unused parameters: - it's consistent with the parse functions for other object types. But we already lost that consistency in 837d395a5c (Replace parse_blob() with an explanatory comment, 2010-01-18). - As the comment from 837d395a5c explains, callers are supposed to make sure they have the object content available. So in theory asking for these parameters could serve as a signal. But there are only two callers, and one of them always passes NULL (after doing a streaming check of the object hash). This shows that there aren't likely to be a lot of callers (since everyone either uses the type-generic parse functions, or handles blobs individually), and that they need to take special care anyway (because we usually want to avoid loading whole blobs in memory if we can avoid it). So let's just drop these unused parameters, and likewise the useless return value. While we're touching the header file, let's move the declaration of parse_blob_buffer() right below that explanatory comment, where it's more likely to be seen by people looking for the function. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

blob: allow lookup_blob to handle arbitrary repositories

2018-06-29T17:43:39Z

Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano

blob: add repository argument to lookup_blob

2018-06-29T17:43:38Z

Add a repository argument to allow the callers of lookup_blob to be more specific about which repository to act on. This is a small mechanical change; it doesn't change the implementation to handle repositories other than the_repository yet. As with the previous commits, use a macro to catch callers passing a repository other than the_repository at compile time. Signed-off-by: Jonathan Nieder Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano

Convert lookup_blob to struct object_id

2017-05-08T06:12:57Z

Convert lookup_blob to take a pointer to struct object_id. The commit was created with manual changes to blob.c and blob.h, plus the following semantic patch: @@ expression E1; @@ - lookup_blob(E1.hash) + lookup_blob(&E1) @@ expression E1; @@ - lookup_blob(E1->hash) + lookup_blob(E1) Signed-off-by: brian m. carlson Signed-off-by: Junio C Hamano

Replace parse_blob() with an explanatory comment

2010-01-19T01:04:02Z

parse_blob() has never actually been used; it has served simply to avoid having a confusing gap in the API. Instead of leaving it, put in a comment that explains what "parsing a blob" entails (making sure the object is actually readable), and why code might care whether a blob has been parsed or not. Signed-off-by: Daniel Barkalow Signed-off-by: Junio C Hamano

[PATCH] Anal retentive 'const unsigned char *sha1'

2005-06-08T20:04:53Z

Make 'sha1' parameters const where possible Signed-off-by: Jason McMullan Signed-off-by: Linus Torvalds

[PATCH] don't load and decompress objects twice with parse_object()

2005-05-06T18:02:01Z

It turns out that parse_object() is loading and decompressing given object to free it just before calling the specific object parsing function which does mmap and decompress the same object again. This patch introduces the ability to parse specific objects directly from a memory buffer. Without this patch, running git-fsck-cache on the kernel repositorytake: real 0m13.006s user 0m11.421s sys 0m1.218s With this patch applied: real 0m8.060s user 0m7.071s sys 0m0.710s The performance increase is significant, and this is kind of a prerequisite for sane delta object support with fsck. Signed-off-by: Nicolas Pitre Signed-off-by: Linus Torvalds

[PATCH] Mark blobs as parsed when they're actually parsed

2005-04-28T14:46:33Z

This eliminates the special case for blobs versus other types of objects. Now the scheme is entirely regular and I won't introduce stupid bugs. (And fsck-cache doesn't have to do the do-nothing parse) Signed-Off-By: Daniel Barkalow Signed-off-by: Linus Torvalds

[PATCH] Header files for object parsing

2005-04-18T18:39:48Z

This adds the structs and function declarations for parsing git objects. Signed-Off-By: Daniel Barkalow Signed-off-by: Linus Torvalds