git/builtin/push.c, branch v2.20.2

push: change needlessly ambiguous example in error

2018-11-14T08:17:09Z

Change an example push added in b55e677522 ("push: introduce new push.default mode "simple"", 2012-04-24) to always mean the same thing whether the current setting happens to be "simple" or not. This error is only emitted under "simple", but message is explaining to the user that they can get two sorts of different behaviors by these two invocations. Let's use "git push HEAD" which always means push the current branch name to that remote, instead of "git push

" which will do that under "simple", but is not guaranteed to do under "upstream". Signed-off-by: Ævar Arnfjörð Bjarmason Signed-off-by: Junio C Hamano

Merge branch 'rs/opt-updates'

2018-08-27T21:33:43Z

"git cmd -h" updates. * rs/opt-updates: parseopt: group literal string alternatives in argument help remote: improve argument help for add --mirror checkout-index: improve argument help for --stage

parseopt: group literal string alternatives in argument help

2018-08-21T18:35:54Z

This formally clarifies that the "--option=" part is the same for all alternatives. Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

Merge branch 'rs/parse-opt-lithelp'

2018-08-17T20:09:56Z

The parse-options machinery learned to refrain from enclosing placeholder string inside a "" pair automatically without PARSE_OPT_LITERAL_ARGHELP. Existing help text for option arguments that are not formatted correctly have been identified and fixed. * rs/parse-opt-lithelp: parse-options: automatically infer PARSE_OPT_LITERAL_ARGHELP shortlog: correct option help for -w send-pack: specify --force-with-lease argument help explicitly pack-objects: specify --index-version argument help explicitly difftool: remove angular brackets from argument help add, update-index: fix --chmod argument help push: use PARSE_OPT_LITERAL_ARGHELP instead of unbalanced brackets

push: use PARSE_OPT_LITERAL_ARGHELP instead of unbalanced brackets

2018-08-03T15:31:28Z

The option help text for the force-with-lease option to "git push" reads like this: $ git push -h 2>&1 | grep -e force-with-lease --force-with-lease[=:] which comes from having N_("refname>:" at both ends. It turns out that parse-options machinery takes the whole string and encloses it inside a pair of "<>", to make it easier for majority cases that uses a single token placeholder. The help string was written in a funnily unbalanced way knowing that the end result would balance out, by somebody who forgot the presence of PARSE_OPT_LITERAL_ARGHELP, which is the escape hatch mechanism designed to help such a case. We just should use the official escape hatch instead. Because ":" part can be omitted to ask Git to guess, it may be more correct to spell it as "[:]", but that is not the focus of this topic. Signed-off-by: Ævar Arnfjörð Bjarmason Helped-by: René Scharfe Signed-off-by: Junio C Hamano

transport: convert transport_push to take a struct refspec

2018-05-17T21:19:44Z

Convert 'transport_push()' to take a 'struct refspec' as a parameter instead of an array of strings which represent refspecs. Signed-off-by: Brandon Williams Signed-off-by: Junio C Hamano

push: convert to use struct refspec

2018-05-17T21:19:44Z

Convert the refspecs in builtin/push.c to be stored in a 'struct refspec' instead of being stored in a list of 'struct refspec_item's. Signed-off-by: Brandon Williams Signed-off-by: Junio C Hamano

push: check for errors earlier

2018-05-17T21:19:44Z

Move the error checking for using the "--mirror", "--all", and "--tags" options earlier and explicitly check for the presence of the flags instead of checking for a side-effect of the flag. Signed-off-by: Brandon Williams Signed-off-by: Junio C Hamano

remote: convert query_refspecs to take a struct refspec

2018-05-17T21:19:43Z

Convert 'query_refspecs()' to take a 'struct refspec' as a parameter instead of a list of 'struct refspec_item'. Signed-off-by: Brandon Williams Signed-off-by: Junio C Hamano

remote: convert push refspecs to struct refspec

2018-05-17T21:19:42Z

Convert the set of push refspecs stored in 'struct remote' to use 'struct refspec'. Signed-off-by: Brandon Williams Signed-off-by: Junio C Hamano