git/builtin/push.c, branch v2.33.6Mirror of https://git.kernel.org/pub/scm/git/git.git/
https://git.shady.money/git/atom?h=v2.33.62021-06-02T01:12:03Zpush: don't get a full remote object2021-06-02T01:12:03ZFelipe Contrerasfelipe.contreras@gmail.com2021-05-31T19:51:24Zurn:sha1:7088ce71918a0f9fde2ceb421d4b332888a202c7
All we need to know is that their names are the same.
Additionally this might be easier to parse for some since
remote_for_branch is more descriptive than remote_get(NULL).
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
push: only check same_remote when needed2021-06-02T01:12:02ZFelipe Contrerasfelipe.contreras@gmail.com2021-05-31T19:51:23Zurn:sha1:e0c91cffde8477ababb5163180f08e29da54db3e
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
push: remove trivial function2021-06-02T01:12:02ZFelipe Contrerasfelipe.contreras@gmail.com2021-05-31T19:51:22Zurn:sha1:c5b09cf771ea3c340335aeff501ebec342f78aa4
It's a single line that is used in a single place, and the variable has
the same name as the function.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
push: remove redundant check2021-06-02T01:12:02ZFelipe Contrerasfelipe.contreras@gmail.com2021-05-31T19:51:21Zurn:sha1:1afd78fb5c29b8ad95de072bb8a0edacc69db61a
If fetch_remote is NULL (i.e. the branch remote is invalid), then it
can't possibly be same as remote, which can't be NULL.
The check is redundant, and so is the extra variable.
Also, fix the Yoda condition: we want to check if remote is the same as
the branch remote, not the other way around.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
push: factor out the typical case2021-06-02T01:12:02ZFelipe Contrerasfelipe.contreras@gmail.com2021-05-31T19:51:20Zurn:sha1:1f934725f7597366c981b72be6597124e2c21a77
Only override dst on the odd case.
This allows a preemptive break on the `simple` case.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
push: get rid of all the setup_push_* functions2021-06-02T01:12:02ZFelipe Contrerasfelipe.contreras@gmail.com2021-05-31T19:51:19Zurn:sha1:0add899baf5a9ee478659821327db719ce74454a
Their code is much simpler now and can move into the parent function.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
push: trivial simplifications2021-06-02T01:12:01ZFelipe Contrerasfelipe.contreras@gmail.com2021-05-31T19:51:18Zurn:sha1:d371a9ef4cfc4610989b0a3d71c79cbe19e0073a
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
push: make setup_push_* return the dst2021-06-02T01:12:01ZFelipe Contrerasfelipe.contreras@gmail.com2021-05-31T19:51:17Zurn:sha1:00458dc5f191f52ef965ca7185b739e8c800b7cb
All of the setup_push_* functions are appending a refspec. Do this only
once on the parent function.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
push: only get the branch when needed2021-06-02T01:12:01ZFelipe Contrerasfelipe.contreras@gmail.com2021-05-31T19:51:16Zurn:sha1:65c63a005434306e7c064eb463ff1f61de56d38e
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
push: factor out null branch check2021-06-02T01:12:01ZFelipe Contrerasfelipe.contreras@gmail.com2021-05-31T19:51:15Zurn:sha1:cc16f95d212d8e0bba07ddfb82aaf416dc4df1c2
No need to do it in every single function.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>