git/builtin, branch v2.44.0

Merge branch 'js/check-null-from-read-object-file'

2024-02-14T23:36:06Z

The code paths that call repo_read_object_file() have been tightened to react to errors. * js/check-null-from-read-object-file: Always check the return value of `repo_read_object_file()`

Merge branch 'rs/receive-pack-remove-find-header'

2024-02-14T23:36:05Z

Code simplification. * rs/receive-pack-remove-find-header: receive-pack: use find_commit_header() in check_nonce() receive-pack: use find_commit_header() in check_cert_push_options()

Merge branch 'tb/multi-pack-reuse-experiment'

2024-02-12T21:16:11Z

Setting `feature.experimental` opts the user into multi-pack reuse experiment * tb/multi-pack-reuse-experiment: pack-objects: enable multi-pack reuse via `feature.experimental` t5332-multi-pack-reuse.sh: extract pack-objects helper functions

Merge branch 'pw/show-ref-pseudorefs'

2024-02-12T21:16:11Z

"git show-ref --verify" did not show things like "CHERRY_PICK_HEAD", which has been corrected. * pw/show-ref-pseudorefs: t1400: use show-ref to check pseudorefs show-ref --verify: accept pseudorefs

Merge branch 'ps/report-failure-from-git-stash'

2024-02-12T21:16:11Z

"git stash" sometimes was silent even when it failed due to unwritable index file, which has been corrected. * ps/report-failure-from-git-stash: builtin/stash: report failure to write to index

Merge branch 'jc/sign-buffer-failure-propagation-fix'

2024-02-12T21:16:11Z

A failed "git tag -s" did not necessarily result in an error depending on the crypto backend, which has been corrected. * jc/sign-buffer-failure-propagation-fix: ssh signing: signal an error with a negative return value tag: fix sign_buffer() call to create a signed tag

receive-pack: use find_commit_header() in check_nonce()

2024-02-12T17:22:20Z

Use the public function find_commit_header() and remove find_header(), as it becomes unused. This is safe and appropriate because we pass the NUL-terminated payload buffer to check_nonce() instead of its start and length. The underlying strbuf push_cert cannot contain NULs, as it is built using strbuf_addstr(), only. We no longer need to call strlen(), as find_commit_header() returns the length of nonce already. Signed-off-by: René Scharfe Signed-off-by: Junio C Hamano

receive-pack: use find_commit_header() in check_cert_push_options()

2024-02-09T22:03:15Z

Use the public function find_commit_header() instead of find_header() to simplify the code. This is possible and safe because we're operating on a strbuf, which is always NUL-terminated, so there is no risk of running over the end of the buffer. It cannot contain NUL within the buffer, as it is built using strbuf_addstr(), only. The string comparison becomes more complicated because we need to check for NUL explicitly after comparing the length-limited option, but on the flip side we don't need to clean up allocations or track the remaining buffer length. Signed-off-by: René Scharfe Signed-off-by: Junio C Hamano

Merge branch 'jk/index-pack-lsan-false-positive-fix' into maint-2.43

2024-02-09T00:22:12Z

Fix false positive reported by leak sanitizer. * jk/index-pack-lsan-false-positive-fix: index-pack: spawn threads atomically

Merge branch 'rs/fast-import-simplify-mempool-allocation' into maint-2.43

2024-02-09T00:22:11Z

Code simplification. * rs/fast-import-simplify-mempool-allocation: fast-import: use mem_pool_calloc()