git/commit-reach.c, branch v2.23.2

Merge branch 'sb/more-repo-in-api'

2019-02-05T22:26:09Z

The in-core repository instances are passed through more codepaths. * sb/more-repo-in-api: (23 commits) t/helper/test-repository: celebrate independence from the_repository path.h: make REPO_GIT_PATH_FUNC repository agnostic commit: prepare free_commit_buffer and release_commit_memory for any repo commit-graph: convert remaining functions to handle any repo submodule: don't add submodule as odb for push submodule: use submodule repos for object lookup pretty: prepare format_commit_message to handle arbitrary repositories commit: prepare logmsg_reencode to handle arbitrary repositories commit: prepare repo_unuse_commit_buffer to handle any repo commit: prepare get_commit_buffer to handle any repo commit-reach: prepare in_merge_bases[_many] to handle any repo commit-reach: prepare get_merge_bases to handle any repo commit-reach.c: allow get_merge_bases_many_0 to handle any repo commit-reach.c: allow remove_redundant to handle any repo commit-reach.c: allow merge_bases_many to handle any repo commit-reach.c: allow paint_down_to_common to handle any repo commit: allow parse_commit* to handle any repo object: parse_object to honor its repository argument object-store: prepare has_{sha1, object}_file to handle any repo object-store: prepare read_object_file to deal with any repo ...

commit-reach: prepare in_merge_bases[_many] to handle any repo

2018-11-14T08:22:40Z

Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano

commit-reach: prepare get_merge_bases to handle any repo

2018-11-14T08:22:40Z

Similarly to previous patches, the get_merge_base functions are used often in the code base, which makes migrating them hard. Implement the new functions, prefixed with 'repo_' and hide the old functions behind a wrapper macro. Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano

commit-reach.c: allow get_merge_bases_many_0 to handle any repo

2018-11-14T08:22:40Z

Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano

commit-reach.c: allow remove_redundant to handle any repo

2018-11-14T08:22:40Z

Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano

commit-reach.c: allow merge_bases_many to handle any repo

2018-11-14T08:22:40Z

Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano

commit-reach.c: allow paint_down_to_common to handle any repo

2018-11-14T08:22:40Z

As the function is file local and not widely used, migrate it all at once. Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano

commit-reach: implement get_reachable_subset

2018-11-02T15:12:06Z

The existing reachability algorithms in commit-reach.c focus on finding merge-bases or determining if all commits in a set X can reach at least one commit in a set Y. However, for two commits sets X and Y, we may also care about which commits in Y are reachable from at least one commit in X. Implement get_reachable_subset() which answers this question. Given two arrays of commits, 'from' and 'to', return a commit_list with every commit from the 'to' array that is reachable from at least one commit in the 'from' array. The algorithm is a simple walk starting at the 'from' commits, using the PARENT2 flag to indicate "this commit has already been added to the walk queue". By marking the 'to' commits with the PARENT1 flag, we can determine when we see a commit from the 'to' array. We remove the PARENT1 flag as we add that commit to the result list to avoid duplicates. The order of the resulting list is a reverse of the order that the commits are discovered in the walk. There are a couple shortcuts to avoid walking more than we need: 1. We determine the minimum generation number of commits in the 'to' array. We do not walk commits with generation number below this minimum. 2. We count how many distinct commits are in the 'to' array, and decrement this count when we discover a 'to' commit during the walk. If this number reaches zero, then we can terminate the walk. Tests will be added using the 'test-tool reach' helper in a subsequent commit. Signed-off-by: Derrick Stolee Signed-off-by: Junio C Hamano

Merge branch 'ds/reachable'

2018-10-30T06:43:47Z

Trivial bugfix. * ds/reachable: commit-reach: fix cast in compare_commits_by_gen()

commit-reach: fix cast in compare_commits_by_gen()

2018-10-22T22:57:47Z

The elements of the array to be sorted are commit pointers, so the comparison function gets handed references to these pointers, not pointers to commit objects. Cast to the right type and dereference once to correctly get the commit reference. Found using Clang's ASan and t5500. Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano