git/compat/msvc.c, branch jchMirror of https://git.kernel.org/pub/scm/git/git.git/
https://git.shady.money/git/atom?h=jch2010-11-24T00:06:50Zwin32: use our own dirent.h2010-11-24T00:06:50ZErik Faye-Lundkusmabite@gmail.com2010-11-23T18:38:29Zurn:sha1:d1b6e6e015501272c7491b3a4adf3cd3904edefa
The mingw-runtime implemenation of opendir, readdir and closedir
sets errno to 0 on success, something that POSIX explicitly
forbids. 3ba7a06 ("A loose object is not corrupt if it cannot be
read due to EMFILE") introduce a dependency on this behaviour,
leading to a broken "git clone" on Windows.
compat/mingw.c contains an implementation of readdir, and
compat/msvc.c contains implementations of opendir and closedir.
Move these to compat/win32/dirent.[ch], and change to our own DIR
structure at the same time.
This provides a generic Win32-implementation of opendir, readdir
and closedir which works on both MinGW and MSVC and does not reset
errno, and as a result git clone is working again on Windows.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
msvc: opendir: handle paths ending with a slash2010-11-24T00:06:47ZErik Faye-Lundkusmabite@gmail.com2010-11-23T18:38:28Zurn:sha1:e7772600e94146ddbf5ef6b08d0ea7d6fc8fbcad
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
win32: dirent: handle errors2010-11-24T00:06:47ZErik Faye-Lundkusmabite@gmail.com2010-11-23T18:38:27Zurn:sha1:9585ed519c59d5ac46f8e12b339220cdd0567b7d
Previously all error conditions were ignored. Be nice, and set errno
when we should.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
msvc: opendir: do not start the search2010-11-24T00:06:46ZErik Faye-Lundkusmabite@gmail.com2010-11-23T18:38:26Zurn:sha1:20c6788aced1237489824db3b25285afed0ad169
compat/mingw.c's readdir expects to be the one that starts the search,
and if it isn't, then the first entry will be missing or incorrect.
Fix this by removing the call to _findfirst, and initializing dd_handle
to INVALID_HANDLE_VALUE.
At the same time, make sure we use FindClose instead of _findclose,
which is symmetric to readdir's FindFirstFile. Take into account that
the find-handle might already be closed by readdir.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
msvc: opendir: allocate enough memory2010-11-24T00:06:46ZErik Faye-Lundkusmabite@gmail.com2010-11-23T18:38:25Zurn:sha1:17194c1e96eddb43d2608fe7bd121256d17118ee
The defintion of DIR expects the allocating function to extend
dd_name by over-allocating. This is not currently done in our
implementation of opendir. Fix this.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
msvc: opendir: fix malloc-failure2010-11-24T00:06:46ZErik Faye-Lundkusmabite@gmail.com2010-11-23T18:38:24Zurn:sha1:599b0bf438e387dbaf00dbadcbe41b2a0de90db1
Previsouly, the code checked for malloc-failure after it had accessed
the returned pointer. Move the check a bit earlier to avoid segfault.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Add platform files for porting to MSVC2009-09-19T03:00:42ZFrank Lilznuaa@gmail.com2009-09-16T08:20:25Zurn:sha1:d75f8e61315cc502c34aec6600db00a7c7192ffd
Add msvc.c and msvc.h to build git under MSVC.
Signed-off-by: Frank Li <lznuaa@gmail.com>
Signed-off-by: Marius Storm-Olsen <mstormo@gmail.com>
Acked-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>