git/compat, branch v2.37.4

Merge branch 'jk/pipe-command-nonblock' into maint

2022-09-13T19:21:08Z

Fix deadlocks between main Git process and subprocess spawned via the pipe_command() API, that can kill "git add -p" that was reimplemented in C recently. * jk/pipe-command-nonblock: pipe_command(): mark stdin descriptor as non-blocking pipe_command(): handle ENOSPC when writing to a pipe pipe_command(): avoid xwrite() for writing to pipe git-compat-util: make MAX_IO_SIZE define globally available nonblock: support Windows compat: add function to enable nonblocking pipes

Merge branch 'js/safe-directory-plus' into maint

2022-08-26T18:13:12Z

Platform-specific code that determines if a directory is OK to use as a repository has been taught to report more details, especially on Windows. source: * js/safe-directory-plus: mingw: handle a file owned by the Administrators group correctly mingw: be more informative when ownership check fails on FAT32 mingw: provide details about unsafe directories' ownership setup: prepare for more detailed "dubious ownership" messages setup: fix some formatting

Merge branch 'js/lstat-mingw-enotdir-fix' into maint

2022-08-26T18:13:10Z

Fix to lstat() emulation on Windows. source: * js/lstat-mingw-enotdir-fix: lstat(mingw): correctly detect ENOTDIR scenarios

nonblock: support Windows

2022-08-17T16:21:40Z

Implement enable_pipe_nonblock() using the Windows API. This works only for pipes, but that is sufficient for this limited interface. Despite the API calls used, it handles both "named" and anonymous pipes from our pipe() emulation. Signed-off-by: René Scharfe Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

compat: add function to enable nonblocking pipes

2022-08-17T16:21:40Z

We'd like to be able to make some of our pipes nonblocking so that poll() can be used effectively, but O_NONBLOCK isn't portable. Let's introduce a compat wrapper so this can be abstracted for each platform. The interface is as narrow as possible to let platforms do what's natural there (rather than having to implement fcntl() and a fake O_NONBLOCK for example, or having to handle other types of descriptors). The next commit will add Windows support, at which point we should be covering all platforms in practice. But if we do find some other platform without O_NONBLOCK, we'll return ENOSYS. Arguably we could just trigger a build-time #error in this case, which would catch the problem earlier. But since we're not planning to use this compat wrapper in many code paths, a seldom-seen runtime error may be friendlier for such a platform than blocking compilation completely. Our test suite would still notice it. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

mingw: handle a file owned by the Administrators group correctly

2022-08-08T16:33:13Z

When an Administrator creates a file or directory, the created file/directory is owned not by the Administrator SID, but by the _Administrators Group_ SID. The reason is that users with administrator privileges usually run in unprivileged ("non-elevated") mode, and their user SID does not change when running in elevated mode. This is is relevant e.g. when running a GitHub workflow on a build agent, which runs in elevated mode: cloning a Git repository in a script step will cause the worktree to be owned by the Administrators Group SID, for example. Let's handle this case as following: if the current user is an administrator, Git should consider a worktree owned by the Administrators Group as if it were owned by said user. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano

mingw: be more informative when ownership check fails on FAT32

2022-08-08T16:31:41Z

The FAT file system has no concept of ACLs. Therefore, it cannot store any ownership information anyway, and the `GetNamedSecurityInfoW()` call pretends that everything is owned "by the world". Let's special-case that scenario and tell the user what's going on. This addresses https://github.com/git-for-windows/git/issues/3886 Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano

mingw: provide details about unsafe directories' ownership

2022-08-08T16:29:29Z

When Git refuses to use an existing repository because it is owned by someone else than the current user, it can be a bit tricky on Windows to figure out what is going on. Let's help with that by providing more detailed information. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano

setup: prepare for more detailed "dubious ownership" messages

2022-08-08T16:25:40Z

When verifying the ownership of the Git directory, we sometimes would like to say a bit more about it, e.g. when using a platform-dependent code path (think: Windows has the permission model that is so different from Unix'), but only when it is a appropriate to actually say something. To allow for that, collect that information and hand it back to the caller (whose responsibility it is to show it or not). Note: We do not actually fill in any platform-dependent information yet, this commit just adds the infrastructure to be able to do so. Based-on-an-idea-by: Junio C Hamano Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano

Merge branch 'ds/win-syslog-compiler-fix' into maint

2022-08-05T22:51:37Z

Workaround for a false positive compiler warning. source: * ds/win-syslog-compiler-fix: compat/win32: correct for incorrect compiler warning