git/connect.c, branch v0.99

[PATCH] Use sq_quote() to properly quote the parameter to call shell.

2005-07-08T18:01:10Z

This tries to be more lenient to the users and stricter to the attackers by quoting the input properly for shell safety, instead of forbidding certain characters from the input. Things to note: - We do not quote "prog" parameter (which comes from --exec). The user should know what he is doing. --exec='echo foo' will supply the first two parameters to the resulting command, while --exec="'echo foo'" will give the first parameter, a single string with a space inside. - We do not care too much about leaking the sq_quote() output just before running exec(). Signed-off-by: Junio C Hamano Signed-off-by: Linus Torvalds

Mark more characters shell-safe.

2005-07-08T00:59:23Z

I still worry about just quoting things when passing it off to "ssh" or "sh -c", so I'm being anal. But _, ^ and , are certainly ok and while both ~ and @ can have speacial meaning to shell/ssh they are benign.

Move "get_ack()" to common git_connect functions

2005-07-05T22:44:09Z

git-clone-pack will want it too. Soon.

Move ref path matching to connect.c library

2005-07-04T20:24:30Z

It's a generic thing for matching refs from the other side.

Factor out the ssh connection stuff from send-pack.c

2005-07-04T18:57:58Z

I want to use it for git-fetch-pack too.