git/connected.c, branch v2.16.2

Convert check_connected to use struct object_id

2017-10-16T02:05:50Z

Convert check_connected and the callbacks it takes to use struct object_id. Signed-off-by: brian m. carlson Signed-off-by: Junio C Hamano

pack: move {,re}prepare_packed_git and approximate_object_count

2017-08-23T22:12:07Z

Signed-off-by: Jonathan Tan Signed-off-by: Junio C Hamano

pack: move add_packed_git()

2017-08-23T22:12:07Z

Signed-off-by: Jonathan Tan Signed-off-by: Junio C Hamano

check_connected: accept an env argument

2016-10-10T20:54:02Z

This lets callers influence the environment seen by rev-list, which will be useful when we start providing quarantined objects. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

check_connected: add progress flag

2016-07-20T19:11:09Z

Connectivity checks have to traverse the entire object graph in the worst case (e.g., a full clone or a full push). For large repositories like linux.git, this can take 30-60 seconds, during which time git may produce little or no output. Let's add the option of showing progress, which is taken care of by rev-list. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

check_connected: relay errors to alternate descriptor

2016-07-20T19:11:01Z

Unless the "quiet" flag is given, check_connected sends any errors to the stderr of the caller (because the child rev-list inherits that descriptor). However, server-side callers may want to send these over a sideband channel instead. Let's make that possible. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

check_everything_connected: use a struct with named options

2016-07-20T19:10:53Z

The number of variants of check_everything_connected has grown over the years, so that the "real" function takes several possibly-zero, possibly-NULL arguments. We hid the complexity behind some wrapper functions, but this doesn't scale well when we want to add new options. If we add more wrapper variants to handle the new options, then we can get a combinatorial explosion when those options might be used together (right now nobody wants to use both "shallow" and "transport" together, so we get by with just a few wrappers). If instead we add new parameters to each function, each of which can have a default value, then callers who want the defaults end up with confusing invocations like: check_everything_connected(fn, 0, data, -1, 0, NULL); where it is unclear which parameter is which (and every caller needs updated when we add new options). Instead, let's add a struct to hold all of the optional parameters. This is a little more verbose for the callers (who have to declare the struct and fill it in), but it makes their code much easier to follow, because every option is named as it is set (and unused options do not have to be mentioned at all). Note that we could also stick the iteration function and its callback data into the option struct, too. But since those are required for each call, by avoiding doing so, we can let very simple callers just pass "NULL" for the options and not worry about the struct at all. While we're touching each site, let's also rename the function to check_connected(). The existing name was quite long, and not all of the wrappers even used the full name. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

check_everything_connected: convert to argv_array

2016-07-20T19:10:51Z

This avoids the magic "9" array-size which we must avoid overflowing, making further patches simpler. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

check_everything_connected: always pass --quiet to rev-list

2016-07-20T19:09:31Z

The check_everything_connected function takes a "quiet" parameter which does two things if non-zero: 1. redirect rev-list's stderr to /dev/null to avoid showing errors to the user 2. pass "--quiet" to rev-list Item (1) is obviously useful. But item (2) is surprisingly not. For rev-list, "--quiet" does not have anything to do with chattiness on stderr; it tells rev-list not to bother writing the list of traversed objects to stdout, for efficiency. And since we always redirect rev-list's stdout to /dev/null in this function, there is no point in asking it to ever write anything to stdout. The efficiency gains are modest; a best-of-five run of "git rev-list --objects --all" on linux.git dropped from 32.013s to 30.502s when adding "--quiet". That's only about 5%, but given how easy it is, it's worth doing. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

connected.c: use error_errno()

2016-05-09T19:29:08Z

Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano