git/contrib/thunderbird-patch-inline, branch v2.50.0Mirror of https://git.kernel.org/pub/scm/git/git.git/
https://git.shady.money/git/atom?h=v2.50.02025-02-11T00:16:19Zthunderbird-patch-inline: avoid bashism2025-02-11T00:16:19Zbrian m. carlsonsandals@crustytoothpaste.net2025-02-10T23:49:47Zurn:sha1:59d26bd9619c1bb37b1ccb4a93a71221bec46e12
The use of "echo -e" is not portable and not specified by POSIX. dash
does not support any options except "-n", and so this script will not
work on operating systems which use that as /bin/sh.
Fortunately, the solution is easy: switch to printf(1), which is
specified by POSIX and allows the escape sequences we want to use. This
will allow the script to work with any POSIX shell.
Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/thunderbird-patch-inline/appp.sh: use the $( ... ) construct for command substitution2015-12-27T23:33:13ZElia Pintogitter.spiros@gmail.com2015-12-22T14:10:28Zurn:sha1:57eb1bef7d86507437ebdfa5a855508e6ab05035
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
appp.sh: use the $( ... ) construct for command substitution2014-04-23T22:17:01ZElia Pintogitter.spiros@gmail.com2014-04-23T13:43:56Zurn:sha1:faf58f4ee6a5599c3b8790b770d6e1736174b7a3
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/thunderbird-patch-inline: do not require bash to run the script2011-03-30T19:29:39ZMaxin johnmaxin@maxinbjohn.info2011-03-30T08:52:23Zurn:sha1:806e0aba2e5d976233703e6ff517af10329e4048
The script does not have to be run under bash, but any POSIX compliant
shell would do, as it does not use any bash-isms.
It may be written under a different style than what is recommended in
Documentation/CodingGuidelines, but that is a different matter.
While at it, fix obvious typos in the comment.
Signed-off-by: Maxin B. John <maxin@maxinbjohn.info>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Documentation: fix typos / spelling mistakes2009-04-20T22:56:07ZMike Ralphsonmike@abacus.co.uk2009-04-17T18:13:28Zurn:sha1:680ebc01806187b33cab9093c39102468298350f
Signed-off-by: Mike Ralphson <mike@abacus.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Add a helper script to send patches with Mozilla Thunderbird2008-06-20T05:40:42ZLukas Sandströmlukass@etek.chalmers.se2008-06-19T23:21:33Zurn:sha1:0c3d26d24ab913a8cc6f478d176f5896af28c03c
The script appp.sh can be used with the External Editor extension for
Mozilla Thunderbird in order to be able to send inline patches in an
easy way.
Signed-off-by: Lukas Sandström <lukass@etek.chalmers.se>
Signed-off-by: Junio C Hamano <gitster@pobox.com>