git/daemon.c, branch v1.6.3

daemon.c: fix segfault on OS X

2009-04-29T23:50:21Z

On OS X (and maybe other unices), getaddrinfo(3) returns NULL in the ai_canonname field if it's called with an IP address for the hostname. We'll now use the IP address for the hostname if ai_canonname was NULL, this also matches the behaviour on Linux. steps to reproduce: $ git daemon --export-all $ git clone git://127.0.0.1/frotz => git daemon's fork (silently) segfaults. Remove the pointless loop while at it. There is only one iteration because of the break; on the last line and there are no continues. Signed-off-by: Benjamin Kramer Signed-off-by: Junio C Hamano

improve missing repository error message

2009-03-05T04:37:21Z

Certain remote commands, when asked to do something in a particular directory that was not actually a git repository, would say "unable to chdir or not a git archive". The "chdir" bit is an unnecessary detail, and the term "git archive" is much less common these days than "git repository". So let's switch them all to: fatal: '%s' does not appear to be a git repository Signed-off-by: Jeff King Acked-by: Shawn O. Pearce Signed-off-by: Junio C Hamano

Add calls to git_extract_argv0_path() in programs that call git_config_*

2009-01-26T08:26:05Z

Programs that use git_config need to find the global configuration. When runtime prefix computation is enabled, this requires that git_extract_argv0_path() is called early in the program's main(). This commit adds the necessary calls. Signed-off-by: Steffen Prohaska Acked-by: Johannes Sixt Signed-off-by: Junio C Hamano

remove trailing LF in die() messages

2009-01-05T21:01:01Z

LF at the end of format strings given to die() is redundant because die already adds one on its own. Signed-off-by: Alexander Potashev Signed-off-by: Junio C Hamano

daemon: cleanup: factor out xstrdup_tolower()

2008-12-27T03:09:56Z

Add xstrdup_tolower(), a helper to get a lower case copy of a string, and use it in two cases. Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

daemon: cleanup: replace loop with if

2008-12-27T03:08:32Z

Replace a loop around an enter_repo() call, which was used to retry a single time with a different parameter in case the first call fails, with two calls and an if. This is shorter and cleaner. Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

daemon: handle freopen() failure

2008-12-27T03:07:56Z

Die if stderr couldn't be sent to /dev/null when operating in inetd mode and report the error message from the OS. This fixes a compiler warning about the return value of freopen() being ignored on Ubuntu 8.10. Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

daemon: deglobalize variable 'directory'

2008-11-24T03:56:36Z

Remove the global variable 'directory' and pass it as a parameter of the two functions that use it instead, (almost) restoring their interface to how it was before 49ba83fb67d9e447b86953965ce5f949c6a93b81. Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

daemon: inline fill_in_extra_table_entries()

2008-11-24T03:56:26Z

Having fill_in_extra_table_entries() as a separate function has no advantage -- a function with no parameters and return values might as well be an anonymous block of code. Its name still refers to the table of interpolate() which has been removed earlier, so it's better to inline it at its only call site. Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano

daemon: use strbuf_expand() instead of interpolate()

2008-11-24T03:56:06Z

Signed-off-by: Rene Scharfe Signed-off-by: Junio C Hamano