git/ewah, branch v2.26.1

Merge branch 'jk/object-filter-with-bitmap'

2020-03-02T23:07:18Z

The object reachability bitmap machinery and the partial cloning machinery were not prepared to work well together, because some object-filtering criteria that partial clones use inherently rely on object traversal, but the bitmap machinery is an optimization to bypass that object traversal. There however are some cases where they can work together, and they were taught about them. * jk/object-filter-with-bitmap: rev-list --count: comment on the use of count_right++ pack-objects: support filters with bitmaps pack-bitmap: implement BLOB_LIMIT filtering pack-bitmap: implement BLOB_NONE filtering bitmap: add bitmap_unset() function rev-list: use bitmap filters for traversal pack-bitmap: basic noop bitmap filter infrastructure rev-list: allow commit-only bitmap traversals t5310: factor out bitmap traversal comparison rev-list: allow bitmaps when counting objects rev-list: make --count work with --objects rev-list: factor out bitmap-optimized routines pack-bitmap: refuse to do a bitmap traversal with pathspecs rev-list: fallback to non-bitmap traversal when filtering pack-bitmap: fix leak of haves/wants object lists pack-bitmap: factor out type iterator initialization

bitmap: add bitmap_unset() function

2020-02-14T18:46:22Z

We've never needed to unset an individual bit in a bitmap until now. Typically they start with all bits unset and we bitmap_set() them, or we are applying another bitmap as a mask. But the easiest way to apply an object filter to a bitmap result will be to unset the individual bits. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

ewah/bitmap: introduce bitmap_word_alloc()

2020-01-23T18:51:50Z

In a following commit we will need to allocate a variable number of bitmap words, instead of always 32, so let's add bitmap_word_alloc() for this purpose. Note that we have to adjust the block growth in bitmap_set(), since a caller could now use an initial size of "0" (we don't plan to do that, but it doesn't hurt to be defensive). Helped-by: Jonathan Tan Signed-off-by: Jeff King Signed-off-by: Christian Couder Signed-off-by: Junio C Hamano

ewok_rlw.h: add missing 'inline' to function definition

2018-10-29T01:14:19Z

The 'ewok_rlw.h' header file contains the rlw_get_run_bit() function definition, which is marked as 'static' but not 'inline'. At least when compiled by gcc, with the default -O2 optimization level, the function is actually inlined and leaves no static version in the ewah_bitmap.o and ewah_rlw.o object files. Despite this, add the missing 'inline' keyword to better describe the intended behaviour. Signed-off-by: Ramsay Jones Signed-off-by: Junio C Hamano

ewah/ewok_rlw.h: add missing include (hdr-check)

2018-09-20T18:50:00Z

Signed-off-by: Ramsay Jones Signed-off-by: Junio C Hamano

ewah: delete unused 'rlwit_discharge_empty()'

2018-06-21T16:39:48Z

Complete the removal of unused 'ewah bitmap' code by removing the now unused 'rlwit_discharge_empty()' function. Also, the 'ewah_clear()' function can now be made a file-scope static symbol. Signed-off-by: Ramsay Jones Signed-off-by: Junio C Hamano

ewah: drop ewah_serialize_native function

2018-06-18T17:16:19Z

We don't call this function, and never have. The on-disk bitmap format uses network-byte-order integers, meaning that we cannot use the native-byte-order format written here. Let's drop it in the name of simplicity. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

ewah: drop ewah_deserialize function

2018-06-18T17:16:19Z

We don't call this function, and in fact never have since it was added (at least not in iterations of the ewah patches that got merged). Instead we use ewah_read_mmap(). Let's drop the unused code. Note to anybody who later wants to resurrect this: it does not check for integer overflow in the ewah data size, meaning it may be possible to convince the code to allocate a too-small buffer and read() into it. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano

ewah_io: delete unused 'ewah_serialize()'

2018-06-18T17:16:19Z

Reported-by: Ramsay Jones Signed-off-by: Derrick Stolee Signed-off-by: Junio C Hamano

ewah_bitmap: delete unused 'ewah_or()'

2018-06-18T17:16:19Z

Reported-by: Ramsay Jones Signed-off-by: Derrick Stolee Signed-off-by: Junio C Hamano