git/git-compat-util.h, branch v2.4.4

Merge branch 'ep/do-not-feed-a-pointer-to-array-size' into maint

2015-06-16T21:33:41Z

Catch a programmer mistake to feed a pointer not an array to ARRAY_SIZE() macro, by using a couple of GCC extensions. * ep/do-not-feed-a-pointer-to-array-size: git-compat-util.h: implement a different ARRAY_SIZE macro for for safely deriving the size of array

git-compat-util.h: implement a different ARRAY_SIZE macro for for safely deriving the size of array

2015-05-05T22:26:48Z

To get number of elements in an array git use the ARRAY_SIZE macro defined as: #define ARRAY_SIZE(x) (sizeof(x)/sizeof((x)[0])) The problem with it is a possibility of mistakenly passing to it a pointer instead an array. The ARRAY_SIZE macro as conventionally defined does not provide good type-safety and the open-coded approach is more fragile, more verbose and provides no improvement in type-safety. Use instead a different but compatible ARRAY_SIZE() macro, which will also break compile if you try to use it on a pointer. This implemention revert to the original code if the compiler doesn't know the typeof and __builtin_types_compatible_p GCC extensions. This can ensure our code is robust to changes, without needing a gratuitous macro or constant. A similar ARRAY_SIZE implementation also exists in the linux kernel. Credits to Rusty Russell and his ccan library. Signed-off-by: Elia Pinto Signed-off-by: Junio C Hamano

Merge branch 'km/bsd-sysctl'

2015-03-20T20:11:49Z

We now detect number of CPUs on older BSD-derived systems. * km/bsd-sysctl: thread-utils.c: detect CPU count on older BSD-like systems configure: support HAVE_BSD_SYSCTL option

Merge branch 'km/bsd-shells'

2015-03-20T20:11:48Z

Portability fixes and workarounds for shell scripts have been added to help BSD-derived systems. * km/bsd-shells: t5528: do not fail with FreeBSD shell help.c: use SHELL_PATH instead of hard-coded "/bin/sh" git-compat-util.h: move SHELL_PATH default into header git-instaweb: use @SHELL_PATH@ instead of /bin/sh git-instaweb: allow running in a working tree subdirectory

configure: support HAVE_BSD_SYSCTL option

2015-03-10T22:13:25Z

On BSD-compatible systems some information such as the number of available CPUs may only be available via the sysctl function. Add support for a HAVE_BSD_SYSCTL option complete with autoconf support and include the sys/syctl.h header when the option is enabled to make the sysctl function available. Signed-off-by: Kyle J. McKay Signed-off-by: Junio C Hamano

git-compat-util.h: move SHELL_PATH default into header

2015-03-10T22:11:24Z

If SHELL_PATH is not defined we use "/bin/sh". However, run-command.c is not the only file that needs to use the default value so move it into a common header. Signed-off-by: Kyle J. McKay Signed-off-by: Junio C Hamano

Merge branch 'bw/kwset-use-unsigned'

2015-03-06T23:02:33Z

The borrowed code in kwset API did not follow our usual convention to use "unsigned char" to store values that range from 0-255. * bw/kwset-use-unsigned: kwset: use unsigned char to store values with high-bit set

Merge branch 'rj/no-xopen-source-for-cygwin' into maint

2015-03-06T22:57:58Z

Code cleanups. * rj/no-xopen-source-for-cygwin: git-compat-util.h: remove redundant code

Merge branch 'es/squelch-openssl-warnings-on-macosx' into maint

2015-03-05T21:13:07Z

An earlier workaround to squelch unhelpful deprecation warnings from the complier on Mac OSX unnecessarily set minimum required version of the OS, which the user might want to raise (or lower) for other reasons. * es/squelch-openssl-warnings-on-macosx: git-compat-util: do not step on MAC_OS_X_VERSION_MIN_REQUIRED

Merge branch 'rj/no-xopen-source-for-cygwin'

2015-03-05T20:45:41Z

Code cleanups. * rj/no-xopen-source-for-cygwin: git-compat-util.h: remove redundant code