git/git-cvsserver.perl, branch v2.30.2

git-cvsserver: port to SHA-256

2020-06-22T18:21:07Z

The code of git-cvsserver currently has several hard-coded 20 and 40 constants that are the length of SHA-1. When parsing the configuration file, read the extensions.objectformat configuration setting as well as CVS-related ones and adjust the hash sizes accordingly. Use these computed values in all the places we match object IDs. Signed-off-by: brian m. carlson Acked-by: Eric Wong Signed-off-by: Junio C Hamano

cvsserver: use safe_pipe_capture for `constant commands` as well

2017-09-11T05:52:29Z

This is not strictly necessary, but it is a good code hygiene. Signed-off-by: Junio C Hamano

cvsserver: use safe_pipe_capture instead of backticks

2017-09-11T05:52:29Z

This makes the script pass arguments that are derived from end-user input in safer way when invoking subcommands. Reported-by: joernchen Signed-off-by: joernchen Signed-off-by: Junio C Hamano

cvsserver: move safe_pipe_capture() to the main package

2017-09-11T05:52:29Z

As a preparation for replacing `command` with a call to this function from outside GITCVS::updater package, move it to the main package. Signed-off-by: Junio C Hamano

typofix: assorted typofixes in comments, documentation and messages

2016-05-06T20:16:37Z

Many instances of duplicate words (e.g. "the the path") and a few typoes are fixed, originally in multiple patches. wildmatch: fix duplicate words of "the" t: fix duplicate words of "output" transport-helper: fix duplicate words of "read" Git.pm: fix duplicate words of "return" path: fix duplicate words of "look" pack-protocol.txt: fix duplicate words of "the" precompose-utf8: fix typo of "sequences" split-index: fix typo worktree.c: fix typo remote-ext: fix typo utf8: fix duplicate words of "the" git-cvsserver: fix duplicate words Signed-off-by: Li Peng Signed-off-by: Junio C Hamano

git-cvsserver.perl: fix typo

2016-02-17T18:00:53Z

Signed-off-by: GyuYong Jung Signed-off-by: Junio C Hamano

Merge branch 'ak/cvsserver-stabilize-use-of-hash-keys'

2013-11-04T22:58:05Z

* ak/cvsserver-stabilize-use-of-hash-keys: cvsserver: Determinize output to combat Perl 5.18 hash randomization

cvsserver: Determinize output to combat Perl 5.18 hash randomization

2013-10-30T17:30:30Z

Perl 5.18 randomizes the seed used by its hash function, so iterating through hashes results in different orders from run to run: http://perldoc.perl.org/perl5180delta.html#Hash-overhaul This usually broke t9400 (gitcvs.dbname, gitcvs.ext.dbname, when running cmp on two .sqlite files) and t9402 (check [cvswork3] diff, when running test_cmp on two diffs). To fix this, hide the internal order of hashes with sort when sending output or running database queries. (An alternative workaround is PERL_HASH_SEED=0, but this seems nicer.) Signed-off-by: Anders Kaseorg Signed-off-by: Junio C Hamano

Merge branch 'jc/cvsserver-perm-bit-fix'

2013-09-18T18:48:02Z

"git cvsserver" computed the permission mode bits incorrectly for executable files. * jc/cvsserver-perm-bit-fix: cvsserver: pick up the right mode bits

cvsserver: pick up the right mode bits

2013-09-11T16:32:30Z

When determining the file mode from either ls-tree or diff-tree output, we used to grab these octal mode string (typically 100644 or 100755) and then did $git_perms .= "r" if ( $mode & 4 ); $git_perms .= "w" if ( $mode & 2 ); $git_perms .= "x" if ( $mode & 1 ); which was already wrong, as (100644 & 4) is very different from oct("100644") & 4. An earlier refactoring 2c3af7e7 (cvsserver: factor out git-log parsing logic, 2012-10-13) further changed it to pick the third octal digit (10*0*644 or 10*0*755) from the left and then do the above conversion, which does not make sense, either. Let's use the third digit from the last of the octal mode string to make sure we get the executable and read bits right. Signed-off-by: Junio C Hamano Tested-by: Michael Cronenworth